From patchwork Tue Apr 16 06:02:22 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sachin Kamat X-Patchwork-Id: 17981 X-Patchwork-Delegate: sylvester.nawrocki@gmail.com Received: from mail.tu-berlin.de ([130.149.7.33]) by www.linuxtv.org with esmtp (Exim 4.72) (envelope-from ) id 1URzAJ-00067G-Sj; Tue, 16 Apr 2013 08:14:51 +0200 X-tubIT-Incoming-IP: 209.132.180.67 Received: from vger.kernel.org ([209.132.180.67]) by mail.tu-berlin.de (exim-4.75/mailfrontend-2) with esmtp id 1URzAJ-0001Mn-GW; Tue, 16 Apr 2013 08:14:51 +0200 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754065Ab3DPGOt (ORCPT + 1 other); Tue, 16 Apr 2013 02:14:49 -0400 Received: from mail-da0-f42.google.com ([209.85.210.42]:55392 "EHLO mail-da0-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753725Ab3DPGOs (ORCPT ); Tue, 16 Apr 2013 02:14:48 -0400 Received: by mail-da0-f42.google.com with SMTP id n15so94399dad.1 for ; Mon, 15 Apr 2013 23:14:48 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=x-received:from:to:cc:subject:date:message-id:x-mailer:in-reply-to :references:x-gm-message-state; bh=Zj5k1p71wj54eGblEkQxf3bh9yozr5Kw823LS/0W8Gs=; b=mmyw1wPf4TY8DUHYmdJpZwQnScKEVA+tcdpnXvzlYS0JhXa77DzhVaYrZfvfF7c+mb fy+mArfwjq/fXv6c+WTqMEhiPBKMPYxnfBWte/RTRCXd+7Tt18qPQdYKTxEMCfw3ZxoL /z5s4qHAduhC6eL8vOmZpVxXARdYkNSSj3PrHb1PDwvNrMlL9m9OAcKG3/veNzyptv54 JE5YK9+aI2n6XlGO/38G0rhu1QLRhkztLOPDAFWeMfAqkCt3WF/Pb3m1t9k7vgk+Ie52 uX6ZBfWaSrfeIw+dzi7Zi2RpzHW2nPxebpjShl2XGzNEio71QcYg4BdjGDHxjQO/BS/8 J7ug== X-Received: by 10.68.194.195 with SMTP id hy3mr1118436pbc.179.1366092888342; Mon, 15 Apr 2013 23:14:48 -0700 (PDT) Received: from linaro.sisodomain.com ([115.113.119.130]) by mx.google.com with ESMTPS id li15sm1333239pab.2.2013.04.15.23.14.45 (version=TLSv1.1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Mon, 15 Apr 2013 23:14:47 -0700 (PDT) From: Sachin Kamat To: linux-media@vger.kernel.org Cc: s.nawrocki@samsung.com, sachin.kamat@linaro.org, patches@linaro.org Subject: [PATCH 4/5] [media] exynos4-is: Initialize 'sensor' before using Date: Tue, 16 Apr 2013 11:32:22 +0530 Message-Id: <1366092143-5482-4-git-send-email-sachin.kamat@linaro.org> X-Mailer: git-send-email 1.7.9.5 In-Reply-To: <1366092143-5482-1-git-send-email-sachin.kamat@linaro.org> References: <1366092143-5482-1-git-send-email-sachin.kamat@linaro.org> X-Gm-Message-State: ALoCoQm9V3rfciLWDsAQm+86/aZm1YebMyYs2o+7czf8+0/W1mZI/Yj4PXJMBgLupTv7V8hW0JjU Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org X-PMX-Version: 5.6.1.2065439, Antispam-Engine: 2.7.2.376379, Antispam-Data: 2013.4.16.60318 X-PMX-Spam: Gauge=IIIIIIII, Probability=8%, Report=' MULTIPLE_RCPTS 0.1, HTML_00_01 0.05, HTML_00_10 0.05, BODYTEXTP_SIZE_3000_LESS 0, BODY_SIZE_1100_1199 0, BODY_SIZE_2000_LESS 0, BODY_SIZE_5000_LESS 0, BODY_SIZE_7000_LESS 0, URI_ENDS_IN_HTML 0, __ANY_URI 0, __CP_URI_IN_BODY 0, __HAS_FROM 0, __HAS_MSGID 0, __HAS_X_MAILER 0, __HAS_X_MAILING_LIST 0, __IN_REP_TO 0, __MIME_TEXT_ONLY 0, __MULTIPLE_RCPTS_CC_X2 0, __SANE_MSGID 0, __SUBJ_ALPHA_END 0, __TO_MALFORMED_2 0, __TO_NO_NAME 0, __URI_NO_WWW 0, __URI_NS , __YOUTUBE_RCVD 0' Add missing initialization code to the 'sensor' data structure variable before using it. Signed-off-by: Sachin Kamat --- Only compile tested. --- drivers/media/platform/exynos4-is/fimc-is-sensor.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/media/platform/exynos4-is/fimc-is-sensor.c b/drivers/media/platform/exynos4-is/fimc-is-sensor.c index 02b2719..bda9093 100644 --- a/drivers/media/platform/exynos4-is/fimc-is-sensor.c +++ b/drivers/media/platform/exynos4-is/fimc-is-sensor.c @@ -268,7 +268,8 @@ err_gpio: static int fimc_is_sensor_remove(struct i2c_client *client) { - struct fimc_is_sensor *sensor; + struct v4l2_subdev *sd = i2c_get_clientdata(client); + struct fimc_is_sensor *sensor = sd_to_fimc_is_sensor(sd); regulator_bulk_free(SENSOR_NUM_SUPPLIES, sensor->supplies); media_entity_cleanup(&sensor->subdev.entity);