From patchwork Wed Mar 27 21:06:35 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Frank Schaefer X-Patchwork-Id: 17688 Received: from mail.tu-berlin.de ([130.149.7.33]) by www.linuxtv.org with esmtp (Exim 4.72) (envelope-from ) id 1UKxYS-00043U-Hi; Wed, 27 Mar 2013 22:06:44 +0100 X-tubIT-Incoming-IP: 209.132.180.67 Received: from vger.kernel.org ([209.132.180.67]) by mail.tu-berlin.de (exim-4.75/mailfrontend-4) with esmtp id 1UKxYR-00025f-Cg; Wed, 27 Mar 2013 22:06:44 +0100 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753585Ab3C0VGl (ORCPT + 1 other); Wed, 27 Mar 2013 17:06:41 -0400 Received: from mail-ea0-f179.google.com ([209.85.215.179]:54997 "EHLO mail-ea0-f179.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753218Ab3C0VGi (ORCPT ); Wed, 27 Mar 2013 17:06:38 -0400 Received: by mail-ea0-f179.google.com with SMTP id f15so3574969eak.24 for ; Wed, 27 Mar 2013 14:06:37 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=googlemail.com; s=20120113; h=x-received:from:to:cc:subject:date:message-id:x-mailer:in-reply-to :references:mime-version:content-type:content-transfer-encoding; bh=hJinMORd4HRAHlECU4u7hUzPRUtJju7oK9wSqSOdUHk=; b=saKlAQ1XultamdcILj/s+gSXMKVqEHm3uRoh+X/C4kGTw7yfwy/pz4Illw3EHYekI2 6ZSxlYTLBSpW2LCwnAOHsFgy7eoL9sLIFyL3x4Jtzx3VQ0UlmlsVfeTgKqzDXzSY8yyS d0lMZrRQmPMb1FWr/bmxH8JnnvNufdM5mJOp4SUZtyn1QXhbxb3Q8Xi7vRLv0B7SyWm+ QsNQH9dgBI30LYhiAEatQiOojIL66VhgLppVs3NnzXICprfYB45y2joS5XATDcvmo/uT GJoFGTsVoRMI5Ta0eMEEQRZoV5b/8rce5jSCTuCnTwnK6uvCtETNqMOpUayIqS/OTSmP Jxww== X-Received: by 10.14.109.71 with SMTP id r47mr32938519eeg.25.1364418397677; Wed, 27 Mar 2013 14:06:37 -0700 (PDT) Received: from Athlon64X2-5000.site (ip-88-152-229-14.unitymediagroup.de. [88.152.229.14]) by mx.google.com with ESMTPS id t4sm33797582eel.0.2013.03.27.14.06.36 (version=TLSv1.2 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Wed, 27 Mar 2013 14:06:36 -0700 (PDT) From: =?UTF-8?q?Frank=20Sch=C3=A4fer?= To: mchehab@redhat.com Cc: linux-media@vger.kernel.org, =?UTF-8?q?Frank=20Sch=C3=A4fer?= Subject: [PATCH 8/9] em28xx: add comment about Samsung and Kodak sensor probing addresses Date: Wed, 27 Mar 2013 22:06:35 +0100 Message-Id: <1364418396-8191-9-git-send-email-fschaefer.oss@googlemail.com> X-Mailer: git-send-email 1.7.10.4 In-Reply-To: <1364418396-8191-1-git-send-email-fschaefer.oss@googlemail.com> References: <1364418396-8191-1-git-send-email-fschaefer.oss@googlemail.com> MIME-Version: 1.0 Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org X-PMX-Version: 5.6.1.2065439, Antispam-Engine: 2.7.2.376379, Antispam-Data: 2013.3.27.205715 X-PMX-Spam: Gauge=IIIIIIII, Probability=8%, Report=' MULTIPLE_RCPTS 0.1, HTML_00_01 0.05, HTML_00_10 0.05, BODYTEXTP_SIZE_3000_LESS 0, BODY_SIZE_1300_1399 0, BODY_SIZE_2000_LESS 0, BODY_SIZE_5000_LESS 0, BODY_SIZE_7000_LESS 0, CT_TEXT_PLAIN_UTF8_CAPS 0, DKIM_SIGNATURE 0, URI_ENDS_IN_HTML 0, __ANY_URI 0, __CP_URI_IN_BODY 0, __CT 0, __CTE 0, __CT_TEXT_PLAIN 0, __FRAUD_BODY_WEBMAIL 0, __FRAUD_WEBMAIL 0, __FRAUD_WEBMAIL_FROM 0, __HAS_FROM 0, __HAS_MSGID 0, __HAS_X_MAILER 0, __HAS_X_MAILING_LIST 0, __IN_REP_TO 0, __MIME_TEXT_ONLY 0, __MIME_VERSION 0, __MULTIPLE_RCPTS_CC_X2 0, __PHISH_SPEAR_STRUCTURE_1 0, __SANE_MSGID 0, __SUBJ_ALPHA_END 0, __TO_MALFORMED_2 0, __TO_NO_NAME 0, __URI_NO_WWW 0, __URI_NS , __YOUTUBE_RCVD 0' The Windows driver also probes at least two further i2c addresses (0x22 >> 1 and 0x66 >> 1). I've got some hints that they are very likely used by Samsung and Kodak sensors, which are known to be used in Empia devices, too. We havn't seen any devices using these sensors yet and don't know how to probe them properly, so leave a comment. Signed-off-by: Frank Schäfer --- drivers/media/usb/em28xx/em28xx-camera.c | 5 +++++ 1 Datei geändert, 5 Zeilen hinzugefügt(+) diff --git a/drivers/media/usb/em28xx/em28xx-camera.c b/drivers/media/usb/em28xx/em28xx-camera.c index e8b3322..64b70d4 100644 --- a/drivers/media/usb/em28xx/em28xx-camera.c +++ b/drivers/media/usb/em28xx/em28xx-camera.c @@ -301,6 +301,11 @@ int em28xx_detect_sensor(struct em28xx *dev) if (dev->em28xx_sensor == EM28XX_NOSENSOR && ret < 0) ret = em28xx_probe_sensor_omnivision(dev); + /* + * NOTE: the Windows driver also probes i2c addresses + * 0x22 (Samsung ?) and 0x66 (Kodak ?) + */ + if (dev->em28xx_sensor == EM28XX_NOSENSOR && ret < 0) { em28xx_info("No sensor detected\n"); return -ENODEV;