From patchwork Mon Mar 4 08:15:18 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sachin Kamat X-Patchwork-Id: 17081 Received: from mail.tu-berlin.de ([130.149.7.33]) by www.linuxtv.org with esmtp (Exim 4.72) (envelope-from ) id 1UCQiW-0000k5-FH; Mon, 04 Mar 2013 09:25:52 +0100 X-tubIT-Incoming-IP: 209.132.180.67 Received: from vger.kernel.org ([209.132.180.67]) by mail.tu-berlin.de (exim-4.75/mailfrontend-3) with esmtp id 1UCQiU-0001nv-F3; Mon, 04 Mar 2013 09:25:51 +0100 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755493Ab3CDIZs (ORCPT + 1 other); Mon, 4 Mar 2013 03:25:48 -0500 Received: from mail-da0-f44.google.com ([209.85.210.44]:59748 "EHLO mail-da0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755457Ab3CDIZr (ORCPT ); Mon, 4 Mar 2013 03:25:47 -0500 Received: by mail-da0-f44.google.com with SMTP id z20so2434135dae.17 for ; Mon, 04 Mar 2013 00:25:47 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=x-received:from:to:cc:subject:date:message-id:x-mailer :x-gm-message-state; bh=GR6sb9FqOgmEAUxFuVMZE1D7W6ptunedjz7bo58fdgA=; b=Nf2Z/IEpPXNQhd0qXCf4pylsYcLfr2xfMzxA52iceN36Zb6u/mkKrcn7hg2OoZhDc3 golPhZ5z7AZD893kY6hjrC+AiLml7Jv6lC3r9AkeqpFpdG7hzfqClENUNFEwT3SUkijE O6/80NsF+bO/R8eN9FxcFb57u94v/zyVoyeA/pIueCFBX6ebDpyrxHSRNYgpC4l03xtk 20VoNb4WWZgQhueWF3z4al3l5Xkds0y2Hqdn8Hpahz7XYBEx+VL+gekznuxkLlD+sCt/ 6Onx7r9MtAAGU78iQ35hEloONJwP7JSg60GD+vvG8A2f0FRsB8xLQ/bWcI7FCOi48o8g wB0w== X-Received: by 10.68.33.98 with SMTP id q2mr27289642pbi.135.1362385547399; Mon, 04 Mar 2013 00:25:47 -0800 (PST) Received: from localhost.localdomain ([115.113.119.130]) by mx.google.com with ESMTPS id 1sm21552973pbg.18.2013.03.04.00.25.44 (version=TLSv1 cipher=RC4-SHA bits=128/128); Mon, 04 Mar 2013 00:25:46 -0800 (PST) From: Sachin Kamat To: linux-media@vger.kernel.org Cc: g.liakhovetski@gmx.de, sachin.kamat@linaro.org, thierry.reding@avionic-design.de Subject: [PATCH 1/4] [media] sh_veu.c: Convert to devm_ioremap_resource() Date: Mon, 4 Mar 2013 13:45:18 +0530 Message-Id: <1362384921-7344-1-git-send-email-sachin.kamat@linaro.org> X-Mailer: git-send-email 1.7.4.1 X-Gm-Message-State: ALoCoQl75OJTztWXHxiYrMBR8guzC4K4KNKUHEiSvTCOPAW/dTHKyuAl4R+GqrH1zJeXzVfY21jO Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org X-PMX-Version: 5.6.1.2065439, Antispam-Engine: 2.7.2.376379, Antispam-Data: 2013.3.4.81815 X-PMX-Spam: Gauge=IIIIIIII, Probability=8%, Report=' MULTIPLE_RCPTS 0.1, HTML_00_01 0.05, HTML_00_10 0.05, BODYTEXTP_SIZE_3000_LESS 0, BODY_SIZE_1300_1399 0, BODY_SIZE_2000_LESS 0, BODY_SIZE_5000_LESS 0, BODY_SIZE_7000_LESS 0, URI_ENDS_IN_HTML 0, __ANY_URI 0, __CP_URI_IN_BODY 0, __FRAUD_BODY_WEBMAIL 0, __FRAUD_WEBMAIL 0, __HAS_FROM 0, __HAS_MSGID 0, __HAS_X_MAILER 0, __HAS_X_MAILING_LIST 0, __MIME_TEXT_ONLY 0, __MULTIPLE_RCPTS_CC_X2 0, __SANE_MSGID 0, __TO_MALFORMED_2 0, __TO_NO_NAME 0, __URI_NO_WWW 0, __URI_NS , __YOUTUBE_RCVD 0' Use the newly introduced devm_ioremap_resource() instead of devm_request_and_ioremap() which provides more consistent error handling. Signed-off-by: Sachin Kamat Cc: Guennadi Liakhovetski Reviewed-by: Thierry Reding --- drivers/media/platform/sh_veu.c | 7 ++++--- 1 files changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/media/platform/sh_veu.c b/drivers/media/platform/sh_veu.c index cb54c69..362d88e 100644 --- a/drivers/media/platform/sh_veu.c +++ b/drivers/media/platform/sh_veu.c @@ -10,6 +10,7 @@ * published by the Free Software Foundation */ +#include #include #include #include @@ -1164,9 +1165,9 @@ static int sh_veu_probe(struct platform_device *pdev) veu->is_2h = resource_size(reg_res) == 0x22c; - veu->base = devm_request_and_ioremap(&pdev->dev, reg_res); - if (!veu->base) - return -ENOMEM; + veu->base = devm_ioremap_resource(&pdev->dev, reg_res); + if (IS_ERR(veu->base)) + return PTR_ERR(veu->base); ret = devm_request_threaded_irq(&pdev->dev, irq, sh_veu_isr, sh_veu_bh, 0, "veu", veu);