From patchwork Tue Jan 29 06:32:30 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sachin Kamat X-Patchwork-Id: 16511 Received: from mail.tu-berlin.de ([130.149.7.33]) by www.linuxtv.org with esmtp (Exim 4.72) (envelope-from ) id 1U04t1-00043U-Sa; Tue, 29 Jan 2013 07:41:39 +0100 X-tubIT-Incoming-IP: 209.132.180.67 Received: from vger.kernel.org ([209.132.180.67]) by mail.tu-berlin.de (exim-4.75/mailfrontend-4) with esmtp id 1U04t1-0005AY-A3; Tue, 29 Jan 2013 07:41:39 +0100 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753044Ab3A2Glf (ORCPT + 1 other); Tue, 29 Jan 2013 01:41:35 -0500 Received: from mail-pa0-f52.google.com ([209.85.220.52]:48295 "EHLO mail-pa0-f52.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753525Ab3A2Glf (ORCPT ); Tue, 29 Jan 2013 01:41:35 -0500 Received: by mail-pa0-f52.google.com with SMTP id kp6so200051pab.11 for ; Mon, 28 Jan 2013 22:41:34 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=x-received:from:to:cc:subject:date:message-id:x-mailer :x-gm-message-state; bh=XFJsFESERFLnuJWKWv+hJ5VPNgapB4gPFNFm3SkqgcU=; b=BKDgseKU9X46qaYMH9IlC7gg+gn2liCx6W5sMrLAQITU07bV6ObtlXThMF7sd7I22q fjPc/IikwlQcwSSjNBfFfhKZepAfEPH/6Xj28DGDzLo8DlUaRankshSC815JYzI9QzM9 oYciOn2tM4rHdULSMTEssjuzG9MreWiRGPdzyRfCKtsimxGVZ90h65qO1Ao9e9ZS4uLo XPA3Xe7ddN7gsuRfw6hvNIJ9b/Q4USksTYohjUsUn4uJZZ8fKZK3YvnDESlwL6368wSk LXx2rgZnZBhlb7DJXs7InyIKGcmtcQe0JoLpxgG/hNvU5le4/RRw0VfO+OVGNzwNeQFb P/Sw== X-Received: by 10.69.1.9 with SMTP id bc9mr1329879pbd.61.1359441694845; Mon, 28 Jan 2013 22:41:34 -0800 (PST) Received: from localhost.localdomain ([115.113.119.130]) by mx.google.com with ESMTPS id jo6sm7824448pbb.5.2013.01.28.22.41.32 (version=TLSv1 cipher=RC4-SHA bits=128/128); Mon, 28 Jan 2013 22:41:34 -0800 (PST) From: Sachin Kamat To: linux-media@vger.kernel.org Cc: sachin.kamat@linaro.org, a.hajda@samsung.com, s.nawrocki@samsung.com Subject: [PATCH 1/1] [media] s5c73m3: Staticize some symbols Date: Tue, 29 Jan 2013 12:02:30 +0530 Message-Id: <1359441150-25872-1-git-send-email-sachin.kamat@linaro.org> X-Mailer: git-send-email 1.7.4.1 X-Gm-Message-State: ALoCoQmNwiwtp4xgPZuN1dJclFG3Tij59W4aQ8owNFn146g/H1ElV+nhjN3+17qN56AKbWocw1iC Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org X-PMX-Version: 5.6.1.2065439, Antispam-Engine: 2.7.2.376379, Antispam-Data: 2013.1.29.63024 X-PMX-Spam: Gauge=IIIIIIII, Probability=8%, Report=' MULTIPLE_RCPTS 0.1, HTML_00_01 0.05, HTML_00_10 0.05, BODYTEXTP_SIZE_3000_LESS 0, BODY_SIZE_1600_1699 0, BODY_SIZE_2000_LESS 0, BODY_SIZE_5000_LESS 0, BODY_SIZE_7000_LESS 0, URI_ENDS_IN_HTML 0, __ANY_URI 0, __CP_URI_IN_BODY 0, __HAS_FROM 0, __HAS_MSGID 0, __HAS_X_MAILER 0, __HAS_X_MAILING_LIST 0, __MIME_TEXT_ONLY 0, __MULTIPLE_RCPTS_CC_X2 0, __SANE_MSGID 0, __SUBJ_ALPHA_END 0, __TO_MALFORMED_2 0, __TO_NO_NAME 0, __URI_NO_WWW 0, __URI_NS , __YOUTUBE_RCVD 0' Fixes the following sparse warnings: drivers/media/i2c/s5c73m3/s5c73m3-core.c:42:5: warning: symbol 'boot_from_rom' was not declared. Should it be static? drivers/media/i2c/s5c73m3/s5c73m3-core.c:45:5: warning: symbol 'update_fw' was not declared. Should it be static? drivers/media/i2c/s5c73m3/s5c73m3-core.c:298:5: warning: symbol 's5c73m3_isp_comm_result' was not declared. Should it be static? Signed-off-by: Sachin Kamat --- drivers/media/i2c/s5c73m3/s5c73m3-core.c | 7 ++++--- 1 files changed, 4 insertions(+), 3 deletions(-) diff --git a/drivers/media/i2c/s5c73m3/s5c73m3-core.c b/drivers/media/i2c/s5c73m3/s5c73m3-core.c index 600909d..b063b4d 100644 --- a/drivers/media/i2c/s5c73m3/s5c73m3-core.c +++ b/drivers/media/i2c/s5c73m3/s5c73m3-core.c @@ -39,10 +39,10 @@ int s5c73m3_dbg; module_param_named(debug, s5c73m3_dbg, int, 0644); -int boot_from_rom = 1; +static int boot_from_rom = 1; module_param(boot_from_rom, int, 0644); -int update_fw; +static int update_fw; module_param(update_fw, int, 0644); #define S5C73M3_EMBEDDED_DATA_MAXLEN SZ_4K @@ -295,7 +295,8 @@ int s5c73m3_isp_command(struct s5c73m3 *state, u16 command, u16 data) return s5c73m3_write(state, REG_STATUS, 0x0001); } -int s5c73m3_isp_comm_result(struct s5c73m3 *state, u16 command, u16 *data) +static int s5c73m3_isp_comm_result(struct s5c73m3 *state, u16 command, + u16 *data) { return s5c73m3_read(state, COMM_RESULT_OFFSET + command, data); }