From patchwork Wed Jan 23 14:07:07 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Federico Vaga X-Patchwork-Id: 16414 Received: from mail.tu-berlin.de ([130.149.7.33]) by www.linuxtv.org with esmtp (Exim 4.72) (envelope-from ) id 1Ty0wz-0005iY-VH; Wed, 23 Jan 2013 15:05:13 +0100 X-tubIT-Incoming-IP: 209.132.180.67 Received: from vger.kernel.org ([209.132.180.67]) by mail.tu-berlin.de (exim-4.75/mailfrontend-2) with esmtp id 1Ty0wz-00077a-Gn; Wed, 23 Jan 2013 15:05:13 +0100 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755480Ab3AWOFI (ORCPT + 1 other); Wed, 23 Jan 2013 09:05:08 -0500 Received: from mail-bk0-f53.google.com ([209.85.214.53]:47678 "EHLO mail-bk0-f53.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755362Ab3AWOFH (ORCPT ); Wed, 23 Jan 2013 09:05:07 -0500 Received: by mail-bk0-f53.google.com with SMTP id je9so1863445bkc.40 for ; Wed, 23 Jan 2013 06:05:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=x-received:from:to:cc:subject:date:message-id:x-mailer:in-reply-to :references; bh=2I+MTqus2TN+H2qls1KK8pEJlVwDVJAXRWbBlP9sjog=; b=0stoiNAz3AnXe/xwmbuFlknZguai+Y5tZsXHJYVthdtKqwtdFTUU02OtDX5cqJEsk5 /OexIwJYCkOsc9BeRTqlG4nbrlfYJ+PqzbCk2xjuXjTt/jtam/kyv/ePbdoMtq6tUrhJ SQ4o2A9O9oamfhvcX5okG8RK6CE5uuUtVPKmGinr6Ne5Uv5kJf4rB6WpMpdvdesV1XSY foDNY7yu6avYw+12LZH+KL07fBtxeA41207A06xDGX6OnC7iKNL454wRHZkcZ310HnH8 kbiuHO1NX2D6JBGIucpVGks0+pafOi3xb+KAjqmgUJRQjClrz8XK0hCBF+0RXN3VFpdb BIYA== X-Received: by 10.204.12.202 with SMTP id y10mr516965bky.51.1358949905550; Wed, 23 Jan 2013 06:05:05 -0800 (PST) Received: from harkonnen.i.gnudd.com (mail2.gnudd.com. [213.203.150.91]) by mx.google.com with ESMTPS id f24sm14215673bkv.7.2013.01.23.06.05.02 (version=TLSv1 cipher=RC4-SHA bits=128/128); Wed, 23 Jan 2013 06:05:04 -0800 (PST) From: Federico Vaga To: Mauro Carvalho Chehab , Marek Szyprowski , Hans Verkuil Cc: Mauro Carvalho Chehab , Giancarlo Asnaghi , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, Federico Vaga Subject: [PATCH v6 2/2] adv7180: remove {query/g_/s_}ctrl Date: Wed, 23 Jan 2013 15:07:07 +0100 Message-Id: <1358950027-27419-2-git-send-email-federico.vaga@gmail.com> X-Mailer: git-send-email 1.7.11.7 In-Reply-To: <1358950027-27419-1-git-send-email-federico.vaga@gmail.com> References: <1358950027-27419-1-git-send-email-federico.vaga@gmail.com> Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org X-PMX-Version: 5.6.1.2065439, Antispam-Engine: 2.7.2.376379, Antispam-Data: 2013.1.23.135125 X-PMX-Spam: Gauge=IIIIIIIII, Probability=9%, Report=' FORGED_FROM_GMAIL 0.1, MULTIPLE_RCPTS 0.1, HTML_00_01 0.05, HTML_00_10 0.05, BODYTEXTP_SIZE_3000_LESS 0, BODY_SIZE_1000_1099 0, BODY_SIZE_2000_LESS 0, BODY_SIZE_5000_LESS 0, BODY_SIZE_7000_LESS 0, DKIM_SIGNATURE 0, URI_ENDS_IN_HTML 0, __ANY_URI 0, __CP_URI_IN_BODY 0, __FRAUD_BODY_WEBMAIL 0, __FRAUD_WEBMAIL 0, __FRAUD_WEBMAIL_FROM 0, __FROM_GMAIL 0, __HAS_FROM 0, __HAS_MSGID 0, __HAS_X_MAILER 0, __HAS_X_MAILING_LIST 0, __MIME_TEXT_ONLY 0, __MULTIPLE_RCPTS_CC_X2 0, __PHISH_SPEAR_STRUCTURE_1 0, __SANE_MSGID 0, __TO_MALFORMED_2 0, __URI_NO_WWW 0, __URI_NS , __YOUTUBE_RCVD 0' All drivers which use this subdevice use also the control framework. The v4l2_subdev_core_ops operations {query/g_/s_}ctrl are useless because device drivers will inherit controls from this subdevice. Signed-off-by: Federico Vaga --- drivers/media/i2c/adv7180.c | 3 --- 1 file modificato, 3 rimozioni(-) diff --git a/drivers/media/i2c/adv7180.c b/drivers/media/i2c/adv7180.c index 45ecf8d..43bc2b9 100644 --- a/drivers/media/i2c/adv7180.c +++ b/drivers/media/i2c/adv7180.c @@ -402,9 +402,6 @@ static const struct v4l2_subdev_video_ops adv7180_video_ops = { static const struct v4l2_subdev_core_ops adv7180_core_ops = { .g_chip_ident = adv7180_g_chip_ident, .s_std = adv7180_s_std, - .queryctrl = v4l2_subdev_queryctrl, - .g_ctrl = v4l2_subdev_g_ctrl, - .s_ctrl = v4l2_subdev_s_ctrl, }; static const struct v4l2_subdev_ops adv7180_ops = {