From patchwork Tue Jan 22 05:00:06 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sachin Kamat X-Patchwork-Id: 16390 Received: from mail.tu-berlin.de ([130.149.7.33]) by www.linuxtv.org with esmtp (Exim 4.72) (envelope-from ) id 1TxW6Q-0005JG-W3; Tue, 22 Jan 2013 06:08:54 +0100 X-tubIT-Incoming-IP: 209.132.180.67 Received: from vger.kernel.org ([209.132.180.67]) by mail.tu-berlin.de (exim-4.75/mailfrontend-4) with esmtp id 1TxW6Q-0001q4-AW; Tue, 22 Jan 2013 06:08:54 +0100 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751003Ab3AVFIw (ORCPT + 1 other); Tue, 22 Jan 2013 00:08:52 -0500 Received: from mail-pb0-f45.google.com ([209.85.160.45]:64412 "EHLO mail-pb0-f45.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750931Ab3AVFIv (ORCPT ); Tue, 22 Jan 2013 00:08:51 -0500 Received: by mail-pb0-f45.google.com with SMTP id mc8so3719290pbc.4 for ; Mon, 21 Jan 2013 21:08:51 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=x-received:from:to:cc:subject:date:message-id:x-mailer :x-gm-message-state; bh=us0FmYJ8XN35KTb+tlwQStQhpIMpg908+F1baa/vfeo=; b=DM6+cup1OeuNpXR0fYde9B06LrE2ANUICoetZRIbq040z6tA3aDnQOPGDNn/WHNqgC +yz4IiS+7EEdjoshwut13PXafyvxqDSbUpd4FigcCJqVTjTC0TeG9rVWNIbH/avMInZX +DTvaoBIBQ+B1EwsbB4ehfnBKl573H1ZvoqEwfbSIQAkWnii1LPVex4qN0KegYXyqyov 8px4If+4ae9fxmVHX/XlRBCJXzgTGhD2KXqX6CAWKliup/ejVMmQ5FfnWAQFNkASQuAI u5yM0K0fEXt1Q3nyBapfcU+iiVz2s6qQpQ/cn8O4+5a7hPdHyempjar5fufNBiIawaM/ 6Q+g== X-Received: by 10.68.125.201 with SMTP id ms9mr36042580pbb.78.1358831331277; Mon, 21 Jan 2013 21:08:51 -0800 (PST) Received: from localhost.localdomain ([115.113.119.130]) by mx.google.com with ESMTPS id ue7sm9996023pbc.53.2013.01.21.21.08.48 (version=TLSv1 cipher=RC4-SHA bits=128/128); Mon, 21 Jan 2013 21:08:50 -0800 (PST) From: Sachin Kamat To: linux-media@vger.kernel.org Cc: k.debski@samsung.com, s.nawrocki@samsung.com, sachin.kamat@linaro.org, patches@linaro.org Subject: [PATCH 1/1] [media] s5p-mfc: Use WARN_ON(condition) directly Date: Tue, 22 Jan 2013 10:30:06 +0530 Message-Id: <1358830806-5610-1-git-send-email-sachin.kamat@linaro.org> X-Mailer: git-send-email 1.7.4.1 X-Gm-Message-State: ALoCoQn3TICDI+ty7RDQu8jdg2D7bveCUfkaR5Ud5vqrBNt8t7j0FpNX1tJ2Jx5uCkZMRwpVN0bT Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org X-PMX-Version: 5.6.1.2065439, Antispam-Engine: 2.7.2.376379, Antispam-Data: 2013.1.22.45722 X-PMX-Spam: Gauge=IIIIIIII, Probability=8%, Report=' MULTIPLE_RCPTS 0.1, HTML_00_01 0.05, HTML_00_10 0.05, BODYTEXTP_SIZE_3000_LESS 0, BODY_SIZE_1000_LESS 0, BODY_SIZE_2000_LESS 0, BODY_SIZE_5000_LESS 0, BODY_SIZE_7000_LESS 0, BODY_SIZE_900_999 0, URI_ENDS_IN_HTML 0, __ANY_URI 0, __CP_URI_IN_BODY 0, __HAS_FROM 0, __HAS_MSGID 0, __HAS_X_MAILER 0, __HAS_X_MAILING_LIST 0, __MIME_TEXT_ONLY 0, __MULTIPLE_RCPTS_CC_X2 0, __SANE_MSGID 0, __SUBJ_ALPHA_END 0, __TO_MALFORMED_2 0, __TO_NO_NAME 0, __URI_NO_WWW 0, __URI_NS , __YOUTUBE_RCVD 0' Use WARN_ON(condition) directly instead of wrapping around an if condition. Signed-off-by: Sachin Kamat --- drivers/media/platform/s5p-mfc/s5p_mfc.c | 3 +-- 1 files changed, 1 insertions(+), 2 deletions(-) diff --git a/drivers/media/platform/s5p-mfc/s5p_mfc.c b/drivers/media/platform/s5p-mfc/s5p_mfc.c index b1d7f9a..37a17b8 100644 --- a/drivers/media/platform/s5p-mfc/s5p_mfc.c +++ b/drivers/media/platform/s5p-mfc/s5p_mfc.c @@ -596,8 +596,7 @@ static void s5p_mfc_handle_stream_complete(struct s5p_mfc_ctx *ctx, clear_work_bit(ctx); - if (test_and_clear_bit(0, &dev->hw_lock) == 0) - WARN_ON(1); + WARN_ON(test_and_clear_bit(0, &dev->hw_lock) == 0); s5p_mfc_clock_off(); wake_up(&ctx->queue);