From patchwork Wed Jan 9 16:05:27 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Gianluca Gennari X-Patchwork-Id: 16195 Received: from mail.tu-berlin.de ([130.149.7.33]) by www.linuxtv.org with esmtp (Exim 4.72) (envelope-from ) id 1TsyAU-000673-AK; Wed, 09 Jan 2013 17:06:18 +0100 X-tubIT-Incoming-IP: 209.132.180.67 Received: from vger.kernel.org ([209.132.180.67]) by mail.tu-berlin.de (exim-4.75/mailfrontend-2) with esmtp id 1TsyAT-0000h2-Hr; Wed, 09 Jan 2013 17:06:18 +0100 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932154Ab3AIQGI (ORCPT + 1 other); Wed, 9 Jan 2013 11:06:08 -0500 Received: from mail-wi0-f170.google.com ([209.85.212.170]:45673 "EHLO mail-wi0-f170.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932146Ab3AIQGH (ORCPT ); Wed, 9 Jan 2013 11:06:07 -0500 Received: by mail-wi0-f170.google.com with SMTP id hq7so639639wib.5 for ; Wed, 09 Jan 2013 08:06:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=x-received:from:to:cc:subject:date:message-id:x-mailer; bh=B9+XpJ96xOeOiyHr9Y5IxRnNu5o/2NkSmS3Xazzx0/s=; b=S62T9a/BlGksPIV8xd0IxB+fh/ttF+YKKUqIrzAvm23MVKtzdsooi5Totnpj8EmCzp 1bqErae1NfDL7zhWDGbj3qXcHYTO7bqD1RVH9OQZ+OokrLXKg1lJWj0XrXfWFlNALt+a 6qafLGjUR+BIZ3kYHD0VkbLSTyESD/9WQez38ZBghjjpo06jKAFhhUDnwrhJwTN8lXOV eh0LFQDiP3hpQwEC1ZcY/Aa3WGcy7zacfhgQdHG87ESJh4Wf810gqITeL9S/r33kk+Qf 70uRfHDMgqdHYG62f6nceSOl3PHj5FIcL0sMZGlEuzmaaiknpG2BoOZGYCBuXrxtPJR5 JRCA== X-Received: by 10.180.93.133 with SMTP id cu5mr4054336wib.32.1357747565660; Wed, 09 Jan 2013 08:06:05 -0800 (PST) Received: from localhost.localdomain (93-50-34-119.ip150.fastwebnet.it. [93.50.34.119]) by mx.google.com with ESMTPS id s16sm4944719wii.0.2013.01.09.08.06.03 (version=TLSv1 cipher=RC4-SHA bits=128/128); Wed, 09 Jan 2013 08:06:04 -0800 (PST) From: Gianluca Gennari To: linux-media@vger.kernel.org, mchehab@redhat.com, hans.verkuil@cisco.com Cc: Gianluca Gennari Subject: [PATCH] media_build: enable em28xx-dvb again for old kernels Date: Wed, 9 Jan 2013 17:05:27 +0100 Message-Id: <1357747527-10305-1-git-send-email-gennarone@gmail.com> X-Mailer: git-send-email 1.8.0.3 Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org X-PMX-Version: 5.6.1.2065439, Antispam-Engine: 2.7.2.376379, Antispam-Data: 2013.1.9.155416 X-PMX-Spam: Gauge=IIIIIIII, Probability=8%, Report=' FORGED_FROM_GMAIL 0.1, HTML_00_01 0.05, HTML_00_10 0.05, BODYTEXTP_SIZE_3000_LESS 0, BODY_SIZE_2000_2999 0, BODY_SIZE_5000_LESS 0, BODY_SIZE_7000_LESS 0, DKIM_SIGNATURE 0, URI_ENDS_IN_HTML 0, __ANY_URI 0, __CP_URI_IN_BODY 0, __FRAUD_BODY_WEBMAIL 0, __FRAUD_WEBMAIL 0, __FRAUD_WEBMAIL_FROM 0, __FROM_GMAIL 0, __HAS_FROM 0, __HAS_MSGID 0, __HAS_X_MAILER 0, __HAS_X_MAILING_LIST 0, __LINES_OF_YELLING 0, __MIME_TEXT_ONLY 0, __PHISH_SPEAR_STRUCTURE_1 0, __SANE_MSGID 0, __SUBJ_ALPHA_END 0, __TO_MALFORMED_2 0, __TO_NO_NAME 0, __URI_NO_WWW 0, __URI_NS , __YOUTUBE_RCVD 0' The em28xx-dvb driver was disabled for old kernels due to lack of support for gpio_request_one() required by LNA control in the PCTV290e driver. Instead, this patch introduces a tiny backport patch that disables LNA control for the PCTV290e USB stick. The PCTV290e works fine with LNA disabled, and all the other em28xx-dvb devices can be used again with old kernels. Signed-off-by: Gianluca Gennari --- backports/backports.txt | 1 + backports/v2.6.33_no_gpio_request_one.patch | 25 +++++++++++++++++++++++++ v4l/versions.txt | 2 -- 3 files changed, 26 insertions(+), 2 deletions(-) create mode 100644 backports/v2.6.33_no_gpio_request_one.patch diff --git a/backports/backports.txt b/backports/backports.txt index 73ecbf6..f21cd53 100644 --- a/backports/backports.txt +++ b/backports/backports.txt @@ -60,6 +60,7 @@ add v2.6.34_fix_define_warnings.patch [2.6.33] add v2.6.33_input_handlers_are_int.patch add v2.6.33_pvrusb2_sysfs.patch +add v2.6.33_no_gpio_request_one.patch [2.6.32] add v2.6.32_kfifo.patch diff --git a/backports/v2.6.33_no_gpio_request_one.patch b/backports/v2.6.33_no_gpio_request_one.patch new file mode 100644 index 0000000..a114a6d --- /dev/null +++ b/backports/v2.6.33_no_gpio_request_one.patch @@ -0,0 +1,25 @@ +--- + drivers/media/usb/em28xx/em28xx-dvb.c | 4 ++-- + 1 file changed, 2 insertions(+), 2 deletions(-) + +--- a/drivers/media/usb/em28xx/em28xx-dvb.c ++++ b/drivers/media/usb/em28xx/em28xx-dvb.c +@@ -672,7 +672,7 @@ static int em28xx_pctv_290e_set_lna(struct dvb_frontend *fe) + { + struct dtv_frontend_properties *c = &fe->dtv_property_cache; + struct em28xx *dev = fe->dvb->priv; +-#ifdef CONFIG_GPIOLIB ++#if 0 + struct em28xx_dvb *dvb = dev->dvb; + int ret; + unsigned long flags; +@@ -1104,7 +1104,7 @@ static int em28xx_dvb_init(struct em28xx *dev) + goto out_free; + } + +-#ifdef CONFIG_GPIOLIB ++#if 0 + /* enable LNA for DVB-T, DVB-T2 and DVB-C */ + result = gpio_request_one(dvb->lna_gpio, + GPIOF_OUT_INIT_LOW, NULL); + diff --git a/v4l/versions.txt b/v4l/versions.txt index 406c8cf..0873c17 100644 --- a/v4l/versions.txt +++ b/v4l/versions.txt @@ -69,8 +69,6 @@ VIDEO_MT9P031 VIDEO_SMIAPP_PLL # Depends on VIDEO_SMIAPP_PLL and requires gpio_request_one VIDEO_SMIAPP -# Depends on gpio functions/defines -VIDEO_EM28XX_DVB [2.6.33] VIDEO_AK881X