From patchwork Sun Jan 6 17:29:03 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Federico Vaga X-Patchwork-Id: 16153 Received: from mail.tu-berlin.de ([130.149.7.33]) by www.linuxtv.org with esmtp (Exim 4.72) (envelope-from ) id 1TrtzI-0006uU-BX; Sun, 06 Jan 2013 18:26:20 +0100 X-tubIT-Incoming-IP: 209.132.180.67 Received: from vger.kernel.org ([209.132.180.67]) by mail.tu-berlin.de (exim-4.75/mailfrontend-3) with esmtp id 1TrtzH-0001ha-Fh; Sun, 06 Jan 2013 18:26:20 +0100 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756117Ab3AFRZz (ORCPT + 1 other); Sun, 6 Jan 2013 12:25:55 -0500 Received: from mail-ea0-f174.google.com ([209.85.215.174]:45861 "EHLO mail-ea0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756044Ab3AFRZu (ORCPT ); Sun, 6 Jan 2013 12:25:50 -0500 Received: by mail-ea0-f174.google.com with SMTP id e13so7678678eaa.33 for ; Sun, 06 Jan 2013 09:25:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=x-received:from:to:cc:subject:date:message-id:x-mailer:in-reply-to :references; bh=2I+MTqus2TN+H2qls1KK8pEJlVwDVJAXRWbBlP9sjog=; b=cL9d/vFoL/Y6Rq/LRAi0uv4bidbFOzGiTv20vbgDCahFrl+SFWcQqvw416SYpUH9rD sqvG1wN+oZPgwZ3dfc0tya1nkrVNU9rbB9zzPneQkuoRp0gM+4l5vGEJZlYtteuEI3Vf 6KixGwuTpTkz/V6K4aEPvIhp0/0o26LskgR/Jd1tng9Iy9lfXf10MUEh5r3Fvyj9AUuA qhmoGPd4RVHxOUPgbQxq+E1nN94KNWpsZ++me5XBbbFdVO0aLPwztq8IiI43tj57HCkv 9Klpko/T05VMe2mqPSM0jvB1amZ6ieNX6AuzqbXpHyaAJifyj+DAjzDKu7gW9B/zUosP Lzlg== X-Received: by 10.14.173.69 with SMTP id u45mr160969137eel.21.1357493149385; Sun, 06 Jan 2013 09:25:49 -0800 (PST) Received: from harkonnen.i.gnudd.com (mail2.gnudd.com. [213.203.150.91]) by mx.google.com with ESMTPS id z8sm125593936eeo.11.2013.01.06.09.25.47 (version=SSLv3 cipher=OTHER); Sun, 06 Jan 2013 09:25:48 -0800 (PST) From: Federico Vaga To: Mauro Carvalho Chehab , Pawel Osciak , Marek Szyprowski , Hans Verkuil Cc: Mauro Carvalho Chehab , Giancarlo Asnaghi , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, Jonathan Corbet , Federico Vaga Subject: [PATCH V4 3/3] adv7180: remove {query/g_/s_}ctrl Date: Sun, 6 Jan 2013 18:29:03 +0100 Message-Id: <1357493343-13090-3-git-send-email-federico.vaga@gmail.com> X-Mailer: git-send-email 1.7.11.7 In-Reply-To: <1357493343-13090-1-git-send-email-federico.vaga@gmail.com> References: <1357493343-13090-1-git-send-email-federico.vaga@gmail.com> Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org X-PMX-Version: 5.6.1.2065439, Antispam-Engine: 2.7.2.376379, Antispam-Data: 2013.1.6.171526 X-PMX-Spam: Gauge=IIIIIIIII, Probability=9%, Report=' FORGED_FROM_GMAIL 0.1, MULTIPLE_RCPTS 0.1, HTML_00_01 0.05, HTML_00_10 0.05, BODYTEXTP_SIZE_3000_LESS 0, BODY_SIZE_1000_1099 0, BODY_SIZE_2000_LESS 0, BODY_SIZE_5000_LESS 0, BODY_SIZE_7000_LESS 0, DKIM_SIGNATURE 0, URI_ENDS_IN_HTML 0, __ANY_URI 0, __CP_URI_IN_BODY 0, __FRAUD_BODY_WEBMAIL 0, __FRAUD_WEBMAIL 0, __FRAUD_WEBMAIL_FROM 0, __FROM_GMAIL 0, __HAS_FROM 0, __HAS_MSGID 0, __HAS_X_MAILER 0, __HAS_X_MAILING_LIST 0, __MIME_TEXT_ONLY 0, __MULTIPLE_RCPTS_CC_X2 0, __PHISH_SPEAR_STRUCTURE_1 0, __SANE_MSGID 0, __TO_MALFORMED_2 0, __URI_NO_WWW 0, __URI_NS , __YOUTUBE_RCVD 0' All drivers which use this subdevice use also the control framework. The v4l2_subdev_core_ops operations {query/g_/s_}ctrl are useless because device drivers will inherit controls from this subdevice. Signed-off-by: Federico Vaga --- drivers/media/i2c/adv7180.c | 3 --- 1 file modificato, 3 rimozioni(-) diff --git a/drivers/media/i2c/adv7180.c b/drivers/media/i2c/adv7180.c index 45ecf8d..43bc2b9 100644 --- a/drivers/media/i2c/adv7180.c +++ b/drivers/media/i2c/adv7180.c @@ -402,9 +402,6 @@ static const struct v4l2_subdev_video_ops adv7180_video_ops = { static const struct v4l2_subdev_core_ops adv7180_core_ops = { .g_chip_ident = adv7180_g_chip_ident, .s_std = adv7180_s_std, - .queryctrl = v4l2_subdev_queryctrl, - .g_ctrl = v4l2_subdev_g_ctrl, - .s_ctrl = v4l2_subdev_s_ctrl, }; static const struct v4l2_subdev_ops adv7180_ops = {