From patchwork Wed Jan 2 10:41:48 2013 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sachin Kamat X-Patchwork-Id: 16059 Received: from mail.tu-berlin.de ([130.149.7.33]) by www.linuxtv.org with esmtp (Exim 4.72) (envelope-from ) id 1TqLtN-0007X5-6e; Wed, 02 Jan 2013 11:49:49 +0100 X-tubIT-Incoming-IP: 209.132.180.67 Received: from vger.kernel.org ([209.132.180.67]) by mail.tu-berlin.de (exim-4.75/mailfrontend-3) with esmtp id 1TqLtM-0003p8-Ei; Wed, 02 Jan 2013 11:49:49 +0100 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752608Ab3ABKtq (ORCPT + 1 other); Wed, 2 Jan 2013 05:49:46 -0500 Received: from mail-pa0-f49.google.com ([209.85.220.49]:49418 "EHLO mail-pa0-f49.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752111Ab3ABKtp (ORCPT ); Wed, 2 Jan 2013 05:49:45 -0500 Received: by mail-pa0-f49.google.com with SMTP id bi1so7897000pad.8 for ; Wed, 02 Jan 2013 02:49:45 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=x-received:from:to:cc:subject:date:message-id:x-mailer :x-gm-message-state; bh=ni7RJU1j1ZU6txvHklhLWltjV4C/TwM0lmfqpjWqxcQ=; b=QrsixcdfUPxsnWJZCIoZci3O9OFHE91plAH7d2aRCxgRRJHvvDx6QPnDBZ0vTiT9gt lpveTHS0WvAeYll4e3JACVRqI46sVuMTs+RGx+2DsZ2D5cirgRsZHSjruH/9GjdKPPir jmEIVB0oLtlVK2/nLcbbDGL8K8f6ntHdhYw8UN2V5R4HV0if+OMbVipfvoOjZ/LOy0Jb VupQi/0+Uh/7MR5ViCoaAOq8DmVFuSqGoL35K5URI9qaVlzdRlyDSnMb/V/YNzcU2ZzB 9i33pyHU7WwuIntr6i86dJ3P6v43SD1b1QCw7DfSJXsISlPQQLCay+8c3M5I8CuqJQzl 5StQ== X-Received: by 10.68.229.194 with SMTP id ss2mr143740247pbc.17.1357123785301; Wed, 02 Jan 2013 02:49:45 -0800 (PST) Received: from localhost.localdomain ([115.113.119.130]) by mx.google.com with ESMTPS id jv1sm22962728pbc.36.2013.01.02.02.49.42 (version=TLSv1/SSLv3 cipher=OTHER); Wed, 02 Jan 2013 02:49:44 -0800 (PST) From: Sachin Kamat To: linux-media@vger.kernel.org Cc: k.debski@samsung.com, s.nawrocki@samsung.com, sylvester.nawrocki@gmail.com, sachin.kamat@linaro.org, patches@linaro.org Subject: [PATCH 1/1] [media] s5p-mfc: Fix an error check Date: Wed, 2 Jan 2013 16:11:48 +0530 Message-Id: <1357123308-7355-1-git-send-email-sachin.kamat@linaro.org> X-Mailer: git-send-email 1.7.4.1 X-Gm-Message-State: ALoCoQnkFsI1rN+AvtS7R5Wt69KxFTBDJbJ1KqTo54T+HqnJbBr7c3vXR8wd415go6Uz+E6Habyd Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org X-PMX-Version: 5.6.1.2065439, Antispam-Engine: 2.7.2.376379, Antispam-Data: 2013.1.2.103915 X-PMX-Spam: Gauge=IIIIIIII, Probability=8%, Report=' MULTIPLE_RCPTS 0.1, HTML_00_01 0.05, HTML_00_10 0.05, BODYTEXTP_SIZE_3000_LESS 0, BODY_SIZE_1000_1099 0, BODY_SIZE_2000_LESS 0, BODY_SIZE_5000_LESS 0, BODY_SIZE_7000_LESS 0, URI_ENDS_IN_HTML 0, __ANY_URI 0, __CP_URI_IN_BODY 0, __HAS_FROM 0, __HAS_MSGID 0, __HAS_X_MAILER 0, __HAS_X_MAILING_LIST 0, __MIME_TEXT_ONLY 0, __MULTIPLE_RCPTS_CC_X2 0, __SANE_MSGID 0, __SUBJ_ALPHA_END 0, __TO_MALFORMED_2 0, __TO_NO_NAME 0, __URI_NO_WWW 0, __URI_NS , __YOUTUBE_RCVD 0' Checking unsigned variable for negative value always returns false. Hence make this value signed as we expect it to be negative too. Signed-off-by: Sachin Kamat --- drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c b/drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c index 5f9a5e0..91d5087 100644 --- a/drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c +++ b/drivers/media/platform/s5p-mfc/s5p_mfc_opr_v6.c @@ -535,8 +535,8 @@ void s5p_mfc_get_enc_frame_buffer_v6(struct s5p_mfc_ctx *ctx, int s5p_mfc_set_enc_ref_buffer_v6(struct s5p_mfc_ctx *ctx) { struct s5p_mfc_dev *dev = ctx->dev; - size_t buf_addr1, buf_size1; - int i; + size_t buf_addr1; + int i, buf_size1; mfc_debug_enter();