From patchwork Mon Nov 26 04:49:06 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sachin Kamat X-Patchwork-Id: 15662 Received: from mail.tu-berlin.de ([130.149.7.33]) by www.linuxtv.org with esmtp (Exim 4.72) (envelope-from ) id 1Tcqjk-0006Cz-8g for patchwork@linuxtv.org; Mon, 26 Nov 2012 05:56:04 +0100 X-tubIT-Incoming-IP: 209.132.180.67 Received: from vger.kernel.org ([209.132.180.67]) by mail.tu-berlin.de (exim-4.75/mailfrontend-4) with esmtp for id 1Tcqjj-00057M-Bd; Mon, 26 Nov 2012 05:56:04 +0100 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754349Ab2KZEz4 (ORCPT ); Sun, 25 Nov 2012 23:55:56 -0500 Received: from mail-pb0-f46.google.com ([209.85.160.46]:60696 "EHLO mail-pb0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754203Ab2KZEzz (ORCPT ); Sun, 25 Nov 2012 23:55:55 -0500 Received: by mail-pb0-f46.google.com with SMTP id wy7so7718128pbc.19 for ; Sun, 25 Nov 2012 20:55:54 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=from:to:cc:subject:date:message-id:x-mailer:in-reply-to:references :x-gm-message-state; bh=ZH4cexRtGKQeSYnwVlyJRo0bOwO5y1pUq74bm4sqMNc=; b=mwVV0qqCOu/Kh+5crgcDFm/16RmswXqibOf3Po311G3YwA88jHZT/ivmMBZje8RzLw +Q6X0sejs9t9rJHO6JIFMk/FupR+Q70uybC0Inxxz/33rF1OpH7yXRjE0LxFcD9zTDnJ PTSMo1EFAq0rH5Khkbr+ivyyP2H+Qda1cfBq3DRieQ/MmAcEooNCFPVcizE1S+Z41XN8 zMDUrBTKBUdp0qxNIILW9PNYNxA7mzpNDYBpsKB/to96u++GZEYzdzFRiTGw4tul3oqv 0GGewoukLepWxwJTfGqfKqZcIftY1EzbsTdqU5Fw9CK5zi+h5BEM5HpssyGhqcRicD3u 2UfQ== Received: by 10.66.77.201 with SMTP id u9mr29714840paw.6.1353905754589; Sun, 25 Nov 2012 20:55:54 -0800 (PST) Received: from localhost.localdomain ([115.113.119.130]) by mx.google.com with ESMTPS id g1sm8082844pax.21.2012.11.25.20.55.51 (version=TLSv1/SSLv3 cipher=OTHER); Sun, 25 Nov 2012 20:55:54 -0800 (PST) From: Sachin Kamat To: linux-media@vger.kernel.org Cc: t.stanislaws@samsung.com, s.nawrocki@samsung.com, sachin.kamat@linaro.org, patches@linaro.org Subject: [PATCH 7/9] [media] s5p-tv: Use devm_clk_get APIs in sdo_drv.c Date: Mon, 26 Nov 2012 10:19:06 +0530 Message-Id: <1353905348-15475-8-git-send-email-sachin.kamat@linaro.org> X-Mailer: git-send-email 1.7.4.1 In-Reply-To: <1353905348-15475-1-git-send-email-sachin.kamat@linaro.org> References: <1353905348-15475-1-git-send-email-sachin.kamat@linaro.org> X-Gm-Message-State: ALoCoQl3fOdoQ5DsrP9/wwUoI4I3qnIUUyXppE0A+Uc2no6skaPaapVQvgoa0mqyobEO3sLHJcQ3 Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org X-PMX-Version: 5.6.1.2065439, Antispam-Engine: 2.7.2.376379, Antispam-Data: 2012.11.26.44816 X-PMX-Spam: Gauge=IIIIIIII, Probability=8%, Report=' MULTIPLE_RCPTS 0.1, HTML_00_01 0.05, HTML_00_10 0.05, BODY_SIZE_3000_3999 0, BODY_SIZE_5000_LESS 0, BODY_SIZE_7000_LESS 0, URI_ENDS_IN_HTML 0, __ANY_URI 0, __CP_URI_IN_BODY 0, __HAS_FROM 0, __HAS_MSGID 0, __HAS_X_MAILER 0, __HAS_X_MAILING_LIST 0, __INT_PROD_TV 0, __MIME_TEXT_ONLY 0, __MULTIPLE_RCPTS_CC_X2 0, __SANE_MSGID 0, __TO_MALFORMED_2 0, __TO_NO_NAME 0, __URI_NO_WWW 0, __URI_NS , __YOUTUBE_RCVD 0' devm_clk_get() is device managed function and makes error handling and exit code a bit simpler. Signed-off-by: Sachin Kamat --- drivers/media/platform/s5p-tv/sdo_drv.c | 39 +++++++++--------------------- 1 files changed, 12 insertions(+), 27 deletions(-) diff --git a/drivers/media/platform/s5p-tv/sdo_drv.c b/drivers/media/platform/s5p-tv/sdo_drv.c index 91e2de3..9e78adf 100644 --- a/drivers/media/platform/s5p-tv/sdo_drv.c +++ b/drivers/media/platform/s5p-tv/sdo_drv.c @@ -340,36 +340,33 @@ static int __devinit sdo_probe(struct platform_device *pdev) sdev->irq = res->start; /* acquire clocks */ - sdev->sclk_dac = clk_get(dev, "sclk_dac"); + sdev->sclk_dac = devm_clk_get(dev, "sclk_dac"); if (IS_ERR_OR_NULL(sdev->sclk_dac)) { dev_err(dev, "failed to get clock 'sclk_dac'\n"); ret = -ENXIO; goto fail; } - sdev->dac = clk_get(dev, "dac"); + sdev->dac = devm_clk_get(dev, "dac"); if (IS_ERR_OR_NULL(sdev->dac)) { dev_err(dev, "failed to get clock 'dac'\n"); - ret = -ENXIO; - goto fail_sclk_dac; + return -ENXIO; } - sdev->dacphy = clk_get(dev, "dacphy"); + sdev->dacphy = devm_clk_get(dev, "dacphy"); if (IS_ERR_OR_NULL(sdev->dacphy)) { dev_err(dev, "failed to get clock 'dacphy'\n"); - ret = -ENXIO; - goto fail_dac; + return -ENXIO; } - sclk_vpll = clk_get(dev, "sclk_vpll"); + sclk_vpll = devm_clk_get(dev, "sclk_vpll"); if (IS_ERR_OR_NULL(sclk_vpll)) { dev_err(dev, "failed to get clock 'sclk_vpll'\n"); - ret = -ENXIO; - goto fail_dacphy; + return -ENXIO; } clk_set_parent(sdev->sclk_dac, sclk_vpll); - clk_put(sclk_vpll); - sdev->fout_vpll = clk_get(dev, "fout_vpll"); + devm_clk_put(dev, sclk_vpll); + sdev->fout_vpll = devm_clk_get(dev, "fout_vpll"); if (IS_ERR_OR_NULL(sdev->fout_vpll)) { dev_err(dev, "failed to get clock 'fout_vpll'\n"); - goto fail_dacphy; + return -ENXIO; } dev_info(dev, "fout_vpll.rate = %lu\n", clk_get_rate(sclk_vpll)); @@ -377,12 +374,12 @@ static int __devinit sdo_probe(struct platform_device *pdev) sdev->vdac = devm_regulator_get(dev, "vdd33a_dac"); if (IS_ERR_OR_NULL(sdev->vdac)) { dev_err(dev, "failed to get regulator 'vdac'\n"); - goto fail_fout_vpll; + goto fail; } sdev->vdet = devm_regulator_get(dev, "vdet"); if (IS_ERR_OR_NULL(sdev->vdet)) { dev_err(dev, "failed to get regulator 'vdet'\n"); - goto fail_fout_vpll; + goto fail; } /* enable gate for dac clock, because mixer uses it */ @@ -406,14 +403,6 @@ static int __devinit sdo_probe(struct platform_device *pdev) dev_info(dev, "probe succeeded\n"); return 0; -fail_fout_vpll: - clk_put(sdev->fout_vpll); -fail_dacphy: - clk_put(sdev->dacphy); -fail_dac: - clk_put(sdev->dac); -fail_sclk_dac: - clk_put(sdev->sclk_dac); fail: dev_info(dev, "probe failed\n"); return ret; @@ -426,10 +415,6 @@ static int __devexit sdo_remove(struct platform_device *pdev) pm_runtime_disable(&pdev->dev); clk_disable(sdev->dac); - clk_put(sdev->fout_vpll); - clk_put(sdev->dacphy); - clk_put(sdev->dac); - clk_put(sdev->sclk_dac); dev_info(&pdev->dev, "remove successful\n"); return 0;