From patchwork Mon Nov 26 04:49:00 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sachin Kamat X-Patchwork-Id: 15657 Received: from mail.tu-berlin.de ([130.149.7.33]) by www.linuxtv.org with esmtp (Exim 4.72) (envelope-from ) id 1Tcqjc-0006C8-87 for patchwork@linuxtv.org; Mon, 26 Nov 2012 05:55:56 +0100 X-tubIT-Incoming-IP: 209.132.180.67 Received: from vger.kernel.org ([209.132.180.67]) by mail.tu-berlin.de (exim-4.75/mailfrontend-4) with esmtp for id 1Tcqjb-00057M-Br; Mon, 26 Nov 2012 05:55:56 +0100 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754300Ab2KZEzn (ORCPT ); Sun, 25 Nov 2012 23:55:43 -0500 Received: from mail-pb0-f46.google.com ([209.85.160.46]:60696 "EHLO mail-pb0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754227Ab2KZEzh (ORCPT ); Sun, 25 Nov 2012 23:55:37 -0500 Received: by mail-pb0-f46.google.com with SMTP id wy7so7718128pbc.19 for ; Sun, 25 Nov 2012 20:55:36 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=from:to:cc:subject:date:message-id:x-mailer:in-reply-to:references :x-gm-message-state; bh=FqocQkvPGjegKbk4JJNDJhgAlgsuudn74fDIX86ZA6Q=; b=o4HabC5tCFEthGJRdI1Vg/d+ShzphE/HUGNoifJhsO2Y4yINF7p7nL1tmueG1gOSdc ZOmIhV6S79QV8dGjcXDdqskMiH3sj5CXYE4H/djTrrgvNhfNuq7src3XN3A2hLiR8qRz 3pARKBZi25hG7D6Ua7CGE0YYfN1UJN79dHjTOorulAdFW7suAJpxDAFnw6FR3v3muDNs KT/SpCQyj/HjT56ab5Sq9odAo2feIWATdAhflB2ObIF+njA7Mn96azksv5QgcxEMYNhs 6Himrz14Qowt9R/xid/Mo7eN1AVwOcRTqF/DuRVawKKDeynMrsPIzGubJycSAp9/9vo1 yYkQ== Received: by 10.68.232.201 with SMTP id tq9mr34210931pbc.12.1353905736197; Sun, 25 Nov 2012 20:55:36 -0800 (PST) Received: from localhost.localdomain ([115.113.119.130]) by mx.google.com with ESMTPS id g1sm8082844pax.21.2012.11.25.20.55.33 (version=TLSv1/SSLv3 cipher=OTHER); Sun, 25 Nov 2012 20:55:35 -0800 (PST) From: Sachin Kamat To: linux-media@vger.kernel.org Cc: t.stanislaws@samsung.com, s.nawrocki@samsung.com, sachin.kamat@linaro.org, patches@linaro.org Subject: [PATCH 1/9] [media] s5p-tv: Add missing braces around sizeof in sdo_drv.c Date: Mon, 26 Nov 2012 10:19:00 +0530 Message-Id: <1353905348-15475-2-git-send-email-sachin.kamat@linaro.org> X-Mailer: git-send-email 1.7.4.1 In-Reply-To: <1353905348-15475-1-git-send-email-sachin.kamat@linaro.org> References: <1353905348-15475-1-git-send-email-sachin.kamat@linaro.org> X-Gm-Message-State: ALoCoQkjY6AY7cP2crew4EvXA2xt5PXTNiDBtokr3DGuS4TKht/h3utzy9Y3yLkV5gg4zOQUMpDa Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org X-PMX-Version: 5.6.1.2065439, Antispam-Engine: 2.7.2.376379, Antispam-Data: 2012.11.26.44816 X-PMX-Spam: Gauge=IIIIIIII, Probability=8%, Report=' MULTIPLE_RCPTS 0.1, HTML_00_01 0.05, HTML_00_10 0.05, BODYTEXTP_SIZE_3000_LESS 0, BODY_SIZE_1600_1699 0, BODY_SIZE_2000_LESS 0, BODY_SIZE_5000_LESS 0, BODY_SIZE_7000_LESS 0, URI_ENDS_IN_HTML 0, __ANY_URI 0, __CP_URI_IN_BODY 0, __HAS_FROM 0, __HAS_MSGID 0, __HAS_X_MAILER 0, __HAS_X_MAILING_LIST 0, __INT_PROD_TV 0, __MIME_TEXT_ONLY 0, __MULTIPLE_RCPTS_CC_X2 0, __SANE_MSGID 0, __TO_MALFORMED_2 0, __TO_NO_NAME 0, __URI_NO_WWW 0, __URI_NS , __YOUTUBE_RCVD 0' Silences the following checkpatch warnings: WARNING: sizeof *sdev should be sizeof(*sdev) FILE: media/platform/s5p-tv/sdo_drv.c:304: sdev = devm_kzalloc(&pdev->dev, sizeof *sdev, GFP_KERNEL); WARNING: sizeof sdev->sd.name should be sizeof(sdev->sd.name) FILE: media/platform/s5p-tv/sdo_drv.c:394: strlcpy(sdev->sd.name, "s5p-sdo", sizeof sdev->sd.name); Signed-off-by: Sachin Kamat --- drivers/media/platform/s5p-tv/sdo_drv.c | 4 ++-- 1 files changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/media/platform/s5p-tv/sdo_drv.c b/drivers/media/platform/s5p-tv/sdo_drv.c index ad68bbe..91e2de3 100644 --- a/drivers/media/platform/s5p-tv/sdo_drv.c +++ b/drivers/media/platform/s5p-tv/sdo_drv.c @@ -301,7 +301,7 @@ static int __devinit sdo_probe(struct platform_device *pdev) struct clk *sclk_vpll; dev_info(dev, "probe start\n"); - sdev = devm_kzalloc(&pdev->dev, sizeof *sdev, GFP_KERNEL); + sdev = devm_kzalloc(&pdev->dev, sizeof(*sdev), GFP_KERNEL); if (!sdev) { dev_err(dev, "not enough memory.\n"); ret = -ENOMEM; @@ -394,7 +394,7 @@ static int __devinit sdo_probe(struct platform_device *pdev) /* configuration of interface subdevice */ v4l2_subdev_init(&sdev->sd, &sdo_sd_ops); sdev->sd.owner = THIS_MODULE; - strlcpy(sdev->sd.name, "s5p-sdo", sizeof sdev->sd.name); + strlcpy(sdev->sd.name, "s5p-sdo", sizeof(sdev->sd.name)); /* set default format */ sdev->fmt = sdo_find_format(SDO_DEFAULT_STD);