From patchwork Fri Nov 23 04:45:01 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sachin Kamat X-Patchwork-Id: 15584 Received: from mail.tu-berlin.de ([130.149.7.33]) by www.linuxtv.org with esmtp (Exim 4.72) (envelope-from ) id 1TblEn-0002Vh-Aq for patchwork@linuxtv.org; Fri, 23 Nov 2012 05:51:37 +0100 X-tubIT-Incoming-IP: 209.132.180.67 Received: from vger.kernel.org ([209.132.180.67]) by mail.tu-berlin.de (exim-4.75/mailfrontend-4) with esmtp for id 1TblEm-0002ee-CB; Fri, 23 Nov 2012 05:51:37 +0100 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756249Ab2KWEve (ORCPT ); Thu, 22 Nov 2012 23:51:34 -0500 Received: from mail-pb0-f46.google.com ([209.85.160.46]:56796 "EHLO mail-pb0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755727Ab2KWEvd (ORCPT ); Thu, 22 Nov 2012 23:51:33 -0500 Received: by mail-pb0-f46.google.com with SMTP id wy7so6266460pbc.19 for ; Thu, 22 Nov 2012 20:51:33 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=from:to:cc:subject:date:message-id:x-mailer:in-reply-to:references :x-gm-message-state; bh=6/4vH9vhU47lKre9pO3cMdXj5rkiTeHpVCzF5ZDPUJE=; b=LR5qxa+zzewxjzKHobRL3qI+p1d2V/7Jq4XCqR2+szjbfXFyUg1m14+uGQJ7YyWgix zNmAgM9MVdjpJ0uh+vdsbNjZJ4DXp1IomZB5IfeO435rn6ejipFdl4y1TPTHl6ccQghN EOnQp4+mfagMMyWx8TvJjYujIeg+V0avOHyRwVoyHD16+e0b/coLTnuytdJqosYnqcDD 9QDkdqluNVqnjsWRlPoGyJ5m1QoKhj/NByzg6AjsdZtqdVStFtUOCAI2mapLga3kr91e zuJOFb8vbE9C/rLmDTZ5xdKbtY88pNp7LtKWC7VlgE5SXsNtWYf/+xosp1Fq16fuCqut U/RA== Received: by 10.68.223.131 with SMTP id qu3mr10497995pbc.89.1353646293018; Thu, 22 Nov 2012 20:51:33 -0800 (PST) Received: from localhost.localdomain ([115.113.119.130]) by mx.google.com with ESMTPS id x8sm3029746paw.16.2012.11.22.20.51.28 (version=TLSv1/SSLv3 cipher=OTHER); Thu, 22 Nov 2012 20:51:32 -0800 (PST) From: Sachin Kamat To: linux-media@vger.kernel.org Cc: s.nawrocki@samsung.com, sachin.kamat@linaro.org, patches@linaro.org, Shaik Ameer Basha Subject: [PATCH 3/4] [media] exynos-gsc: Use devm_clk_get() Date: Fri, 23 Nov 2012 10:15:01 +0530 Message-Id: <1353645902-7467-4-git-send-email-sachin.kamat@linaro.org> X-Mailer: git-send-email 1.7.4.1 In-Reply-To: <1353645902-7467-1-git-send-email-sachin.kamat@linaro.org> References: <1353645902-7467-1-git-send-email-sachin.kamat@linaro.org> X-Gm-Message-State: ALoCoQmzsB1D3hzIrNBthi8LeeTQst9/QsV4xrwx7EqAYoPBx8xDrPyBIZLGnWAI0kBoTF1upgZ1 Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org X-PMX-Version: 5.6.1.2065439, Antispam-Engine: 2.7.2.376379, Antispam-Data: 2012.11.23.43916 X-PMX-Spam: Gauge=IIIIIIII, Probability=8%, Report=' MULTIPLE_RCPTS 0.1, HTML_00_01 0.05, HTML_00_10 0.05, BODYTEXTP_SIZE_3000_LESS 0, BODY_SIZE_1500_1599 0, BODY_SIZE_2000_LESS 0, BODY_SIZE_5000_LESS 0, BODY_SIZE_7000_LESS 0, URI_ENDS_IN_HTML 0, __ANY_URI 0, __CP_URI_IN_BODY 0, __HAS_FROM 0, __HAS_MSGID 0, __HAS_X_MAILER 0, __HAS_X_MAILING_LIST 0, __MIME_TEXT_ONLY 0, __MULTIPLE_RCPTS_CC_X2 0, __SANE_MSGID 0, __TO_MALFORMED_2 0, __TO_NO_NAME 0, __URI_NO_WWW 0, __URI_NS , __YOUTUBE_RCVD 0' devm_clk_get() is a device managed function and makes error handling a bit simpler. Cc: Shaik Ameer Basha Signed-off-by: Sachin Kamat --- drivers/media/platform/exynos-gsc/gsc-core.c | 6 +----- 1 files changed, 1 insertions(+), 5 deletions(-) diff --git a/drivers/media/platform/exynos-gsc/gsc-core.c b/drivers/media/platform/exynos-gsc/gsc-core.c index 99ee1a9..b89afec 100644 --- a/drivers/media/platform/exynos-gsc/gsc-core.c +++ b/drivers/media/platform/exynos-gsc/gsc-core.c @@ -1006,8 +1006,6 @@ static void gsc_clk_put(struct gsc_dev *gsc) return; clk_unprepare(gsc->clock); - clk_put(gsc->clock); - gsc->clock = NULL; } static int gsc_clk_get(struct gsc_dev *gsc) @@ -1016,7 +1014,7 @@ static int gsc_clk_get(struct gsc_dev *gsc) dev_dbg(&gsc->pdev->dev, "gsc_clk_get Called\n"); - gsc->clock = clk_get(&gsc->pdev->dev, GSC_CLOCK_GATE_NAME); + gsc->clock = devm_clk_get(&gsc->pdev->dev, GSC_CLOCK_GATE_NAME); if (IS_ERR(gsc->clock)) { dev_err(&gsc->pdev->dev, "failed to get clock~~~: %s\n", GSC_CLOCK_GATE_NAME); @@ -1027,8 +1025,6 @@ static int gsc_clk_get(struct gsc_dev *gsc) if (ret < 0) { dev_err(&gsc->pdev->dev, "clock prepare failed for clock: %s\n", GSC_CLOCK_GATE_NAME); - clk_put(gsc->clock); - gsc->clock = NULL; goto err; }