From patchwork Fri Nov 16 04:55:28 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sachin Kamat X-Patchwork-Id: 15474 Received: from mail.tu-berlin.de ([130.149.7.33]) by www.linuxtv.org with esmtp (Exim 4.72) (envelope-from ) id 1TZE3b-0001Zw-Sz for patchwork@linuxtv.org; Fri, 16 Nov 2012 06:01:35 +0100 X-tubIT-Incoming-IP: 209.132.180.67 Received: from vger.kernel.org ([209.132.180.67]) by mail.tu-berlin.de (exim-4.75/mailfrontend-4) with esmtp for id 1TZE3a-0004aB-Cs; Fri, 16 Nov 2012 06:01:35 +0100 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751072Ab2KPFBa (ORCPT ); Fri, 16 Nov 2012 00:01:30 -0500 Received: from mail-pb0-f46.google.com ([209.85.160.46]:51745 "EHLO mail-pb0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750730Ab2KPFB2 (ORCPT ); Fri, 16 Nov 2012 00:01:28 -0500 Received: by mail-pb0-f46.google.com with SMTP id wy7so1672366pbc.19 for ; Thu, 15 Nov 2012 21:01:27 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=from:to:cc:subject:date:message-id:x-mailer:x-gm-message-state; bh=ubpy6j0l49OxUtg52UTaROJqtvd7Y3TrsSCTTTOQKF8=; b=E2dCr5kgrQCPYFAUhiAr+ikkGejYT+43Lo2YcYW1FrBDpEK9Ulzr/2keD9ayR7Wf4a FK24pBauGw6WprPeOflTAxS9fkMLbXQJO8dkffiPnTr6HksiCJTAPOu5wtw/+cA3xQQM gg0UhHh11WewvDfSq7Wbj5lw4tu2rrL0ua+x+4Z/ny9N2d+/aEHxesRyNAd+BFRFO3EF 7Gef9Gw9yzmyk8BG9urx3nWabzwVRbdtSPnfxlEisTrDfCPR0kBb10O1r28dZxQUYYJl 9jASQSTz9BU2BakMAzPYEHGbpGn4IwAw1zTl+HteY+x3TP5vm+Q/gzYRQjRr7smkLRO3 mTHg== Received: by 10.66.82.68 with SMTP id g4mr9753055pay.9.1353042087814; Thu, 15 Nov 2012 21:01:27 -0800 (PST) Received: from localhost.localdomain ([115.113.119.130]) by mx.google.com with ESMTPS id i10sm424739paz.17.2012.11.15.21.01.24 (version=TLSv1/SSLv3 cipher=OTHER); Thu, 15 Nov 2012 21:01:27 -0800 (PST) From: Sachin Kamat To: linux-media@vger.kernel.org Cc: t.stanislaws@samsung.com, sachin.kamat@linaro.org, patches@linaro.org, sylvester.nawrocki@gmail.com, s.nawrocki@samsung.com Subject: [PATCH 1/1] [media] s5p-tv: Use devm_gpio_request in sii9234_drv.c Date: Fri, 16 Nov 2012 10:25:28 +0530 Message-Id: <1353041728-11032-1-git-send-email-sachin.kamat@linaro.org> X-Mailer: git-send-email 1.7.4.1 X-Gm-Message-State: ALoCoQniE+f8dG9XfoBwB2xkVew3kXxVuWoZxeyOhYgkoJgHhIk3ByAMXgiQEd2XsUSEhsq7JuUS Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org X-PMX-Version: 5.6.1.2065439, Antispam-Engine: 2.7.2.376379, Antispam-Data: 2012.11.16.45425 X-PMX-Spam: Gauge=IIIIIIII, Probability=8%, Report=' MULTIPLE_RCPTS 0.1, HTML_00_01 0.05, HTML_00_10 0.05, BODYTEXTP_SIZE_3000_LESS 0, BODY_SIZE_1500_1599 0, BODY_SIZE_2000_LESS 0, BODY_SIZE_5000_LESS 0, BODY_SIZE_7000_LESS 0, URI_ENDS_IN_HTML 0, __ANY_URI 0, __CP_URI_IN_BODY 0, __HAS_FROM 0, __HAS_MSGID 0, __HAS_X_MAILER 0, __HAS_X_MAILING_LIST 0, __INT_PROD_TV 0, __MIME_TEXT_ONLY 0, __MULTIPLE_RCPTS_CC_X2 0, __SANE_MSGID 0, __TO_MALFORMED_2 0, __TO_NO_NAME 0, __URI_NO_WWW 0, __URI_NS , __YOUTUBE_RCVD 0' devm_gpio_request is a device managed function and will make error handling and cleanup a bit simpler. Signed-off-by: Sachin Kamat Acked-by: Tomasz Stanislawski --- drivers/media/platform/s5p-tv/sii9234_drv.c | 6 +----- 1 files changed, 1 insertions(+), 5 deletions(-) diff --git a/drivers/media/platform/s5p-tv/sii9234_drv.c b/drivers/media/platform/s5p-tv/sii9234_drv.c index 716d484..4597342 100644 --- a/drivers/media/platform/s5p-tv/sii9234_drv.c +++ b/drivers/media/platform/s5p-tv/sii9234_drv.c @@ -338,7 +338,7 @@ static int __devinit sii9234_probe(struct i2c_client *client, } ctx->gpio_n_reset = pdata->gpio_n_reset; - ret = gpio_request(ctx->gpio_n_reset, "MHL_RST"); + ret = devm_gpio_request(dev, ctx->gpio_n_reset, "MHL_RST"); if (ret) { dev_err(dev, "failed to acquire MHL_RST gpio\n"); return ret; @@ -370,7 +370,6 @@ fail_pm_get: fail_pm: pm_runtime_disable(dev); - gpio_free(ctx->gpio_n_reset); fail: dev_err(dev, "probe failed\n"); @@ -381,11 +380,8 @@ fail: static int __devexit sii9234_remove(struct i2c_client *client) { struct device *dev = &client->dev; - struct v4l2_subdev *sd = i2c_get_clientdata(client); - struct sii9234_context *ctx = sd_to_context(sd); pm_runtime_disable(dev); - gpio_free(ctx->gpio_n_reset); dev_info(dev, "remove successful\n");