From patchwork Mon Nov 12 08:01:29 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Tushar Behera X-Patchwork-Id: 15420 Received: from mail.tu-berlin.de ([130.149.7.33]) by www.linuxtv.org with esmtp (Exim 4.72) (envelope-from ) id 1TXp3W-0003b0-LE for patchwork@linuxtv.org; Mon, 12 Nov 2012 09:07:42 +0100 X-tubIT-Incoming-IP: 209.132.180.67 Received: from vger.kernel.org ([209.132.180.67]) by mail.tu-berlin.de (exim-4.75/mailfrontend-2) with esmtp for id 1TXp3V-0002ru-J7; Mon, 12 Nov 2012 09:07:42 +0100 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751370Ab2KLIHS (ORCPT ); Mon, 12 Nov 2012 03:07:18 -0500 Received: from mail-pb0-f46.google.com ([209.85.160.46]:64011 "EHLO mail-pb0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751255Ab2KLIHQ (ORCPT ); Mon, 12 Nov 2012 03:07:16 -0500 Received: by mail-pb0-f46.google.com with SMTP id rr4so4187093pbb.19 for ; Mon, 12 Nov 2012 00:07:16 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=from:to:cc:subject:date:message-id:x-mailer:x-gm-message-state; bh=Ef+fBnHSZD2DpLOIs9ETcVOQ2gzS4bnrznaNte0nyUk=; b=XQEPgHjAC1TyY3cWQ+XTc6YGA4G38R0RZdGHpgNN55bxG9My1rfe4tB/t3p7F7G3Nc kXJ0ApIiyPAmorzlg7L/Ln9mUoDb4T+2k/hzca+9nutg/7dddD2JiiQfhpIgRDfy2xNU sDeNncnPUY3yGYdqEb2dL8kdfug/PjF4r7e+4kfAl+EbFffaQN2Fl+q/0ooTbKE+z77+ tvA91jhEq52TgFy5mWskcihwUKjhQ9zpKoKFi8LRTlX2wFPCN3jWYmwQH4BopTK7i10j ahWnOgNbfg0iSfEmrhMEWtxJAs/RCfSM+QQ3MbTPZe9LL0czl5G9ahkDNpPweuv7uX7O tJxg== Received: by 10.68.227.162 with SMTP id sb2mr56602572pbc.4.1352707636526; Mon, 12 Nov 2012 00:07:16 -0800 (PST) Received: from localhost.localdomain ([115.113.119.130]) by mx.google.com with ESMTPS id d2sm3926994paw.19.2012.11.12.00.07.13 (version=TLSv1/SSLv3 cipher=OTHER); Mon, 12 Nov 2012 00:07:15 -0800 (PST) From: Tushar Behera To: linux-kernel@vger.kernel.org, linux-media@vger.kernel.org Cc: mchehab@redhat.com, patches@linaro.org Subject: [PATCH] [media] videobuf2-core: print current state of buffer in vb2_buffer_done Date: Mon, 12 Nov 2012 13:31:29 +0530 Message-Id: <1352707289-9349-1-git-send-email-tushar.behera@linaro.org> X-Mailer: git-send-email 1.7.4.1 X-Gm-Message-State: ALoCoQnTBV8bwo9Rw0hCiM1Vl8JYC8ZAvyPFwZQTVwHkpTEPnIBp00hn7gCoZ8hD1Jw3oFC/FF76 Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org X-PMX-Version: 5.6.1.2065439, Antispam-Engine: 2.7.2.376379, Antispam-Data: 2012.11.12.80037 X-PMX-Spam: Gauge=IIIIIIII, Probability=8%, Report=' MULTIPLE_RCPTS 0.1, HTML_00_01 0.05, HTML_00_10 0.05, BODYTEXTP_SIZE_3000_LESS 0, BODY_SIZE_1000_1099 0, BODY_SIZE_2000_LESS 0, BODY_SIZE_5000_LESS 0, BODY_SIZE_7000_LESS 0, URI_ENDS_IN_HTML 0, __ANY_URI 0, __CP_URI_IN_BODY 0, __HAS_FROM 0, __HAS_MSGID 0, __HAS_X_MAILER 0, __HAS_X_MAILING_LIST 0, __MIME_TEXT_ONLY 0, __MULTIPLE_RCPTS_CC_X2 0, __SANE_MSGID 0, __TO_MALFORMED_2 0, __TO_NO_NAME 0, __URI_NO_WWW 0, __URI_NS , __YOUTUBE_RCVD 0' In vb2_buffer_done, it would be better the print the value of 'state' (current state of buffer) than to print 'vb->state' which is always VB2_BUF_STATE_ACTIVE. Signed-off-by: Tushar Behera --- drivers/media/v4l2-core/videobuf2-core.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/media/v4l2-core/videobuf2-core.c b/drivers/media/v4l2-core/videobuf2-core.c index 432df11..91980d13 100644 --- a/drivers/media/v4l2-core/videobuf2-core.c +++ b/drivers/media/v4l2-core/videobuf2-core.c @@ -798,7 +798,7 @@ void vb2_buffer_done(struct vb2_buffer *vb, enum vb2_buffer_state state) return; dprintk(4, "Done processing on buffer %d, state: %d\n", - vb->v4l2_buf.index, vb->state); + vb->v4l2_buf.index, state); /* Add the buffer to the done buffers list */ spin_lock_irqsave(&q->done_lock, flags);