From patchwork Tue Nov 6 19:39:54 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: YAMANE Toshiaki X-Patchwork-Id: 15364 Received: from mail.tu-berlin.de ([130.149.7.33]) by www.linuxtv.org with esmtp (Exim 4.72) (envelope-from ) id 1TVp0a-0005BV-D4 for patchwork@linuxtv.org; Tue, 06 Nov 2012 20:40:24 +0100 X-tubIT-Incoming-IP: 209.132.180.67 Received: from vger.kernel.org ([209.132.180.67]) by mail.tu-berlin.de (exim-4.75/mailfrontend-4) with esmtp for id 1TVp0Z-0005ld-Be; Tue, 06 Nov 2012 20:40:24 +0100 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752584Ab2KFTkD (ORCPT ); Tue, 6 Nov 2012 14:40:03 -0500 Received: from mail-pb0-f46.google.com ([209.85.160.46]:35242 "EHLO mail-pb0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752254Ab2KFTkB (ORCPT ); Tue, 6 Nov 2012 14:40:01 -0500 Received: by mail-pb0-f46.google.com with SMTP id rr4so634015pbb.19 for ; Tue, 06 Nov 2012 11:40:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:x-mailer; bh=WWU1JRY5ek70BQp5sy/oeV6Tqa6SNoSXK35WX/i67kM=; b=ArQpEWEZ5EueSQfO2UAnxwR31A+fcqgRddCBjHulb02WcyF4veAKLyCuR1l4NilLfq lCrEiBvqsnQ7Zb+em23qyhnhhM3A8OX7oygQaaW6miZtr6fD6PgrzN4A7yNyL8ILqXbU SiRmXcvK/1Ly6Yt526iuUFzK3n2kxvTz1D6pX3tdsFHcqaMtGv+gtqlLHs25O3WCXf+C wFO7sf/zqst/6Rz8nSnkZqawhPzZrsMiBpU5iquk1D2mKu9WKqbZ0yF+XAwKHe1p0R/V PJdjiNBCuau6UIoJukaiW731on/Op8keGrcS0KbmE2KbgNA+JVUNEBhPu0BclnWflEFL 0wHw== Received: by 10.68.253.230 with SMTP id ad6mr6481579pbd.84.1352230800696; Tue, 06 Nov 2012 11:40:00 -0800 (PST) Received: from localhost (softbank220057059032.bbtec.net. [220.57.59.32]) by mx.google.com with ESMTPS id b6sm12899227pav.33.2012.11.06.11.39.58 (version=TLSv1/SSLv3 cipher=OTHER); Tue, 06 Nov 2012 11:40:00 -0800 (PST) From: YAMANE Toshiaki To: Mauro Carvalho Chehab Cc: Greg Kroah-Hartman , linux-media@vger.kernel.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, YAMANE Toshiaki Subject: [PATCH] Staging/media: Use dev_ printks in go7007/wis-uda1342.c Date: Wed, 7 Nov 2012 04:39:54 +0900 Message-Id: <1352230794-9406-1-git-send-email-yamanetoshi@gmail.com> X-Mailer: git-send-email 1.7.9.5 Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org X-PMX-Version: 5.6.1.2065439, Antispam-Engine: 2.7.2.376379, Antispam-Data: 2012.11.6.193024 X-PMX-Spam: Gauge=IIIIIIIII, Probability=9%, Report=' FORGED_FROM_GMAIL 0.1, MULTIPLE_RCPTS 0.1, HTML_00_01 0.05, HTML_00_10 0.05, BODYTEXTP_SIZE_3000_LESS 0, BODY_SIZE_1500_1599 0, BODY_SIZE_2000_LESS 0, BODY_SIZE_5000_LESS 0, BODY_SIZE_7000_LESS 0, DKIM_SIGNATURE 0, URI_ENDS_IN_HTML 0, __ANY_URI 0, __CP_URI_IN_BODY 0, __FRAUD_BODY_WEBMAIL 0, __FRAUD_WEBMAIL 0, __FRAUD_WEBMAIL_FROM 0, __FROM_GMAIL 0, __HAS_FROM 0, __HAS_MSGID 0, __HAS_X_MAILER 0, __HAS_X_MAILING_LIST 0, __MIME_TEXT_ONLY 0, __MULTIPLE_RCPTS_CC_X2 0, __PHISH_SPEAR_STRUCTURE_1 0, __SANE_MSGID 0, __TO_MALFORMED_2 0, __URI_NO_WWW 0, __URI_NS , __YOUTUBE_RCVD 0' fixed below checkpatch warning. - WARNING: Prefer netdev_dbg(netdev, ... then dev_dbg(dev, ... then pr_debug(... to printk(KERN_DEBUG ... - WARNING: Prefer netdev_err(netdev, ... then dev_err(dev, ... then pr_err(... to printk(KERN_ERR ... Signed-off-by: YAMANE Toshiaki --- drivers/staging/media/go7007/wis-uda1342.c | 7 +++---- 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/drivers/staging/media/go7007/wis-uda1342.c b/drivers/staging/media/go7007/wis-uda1342.c index 0127be2..48e1407 100644 --- a/drivers/staging/media/go7007/wis-uda1342.c +++ b/drivers/staging/media/go7007/wis-uda1342.c @@ -47,8 +47,8 @@ static int wis_uda1342_command(struct i2c_client *client, write_reg(client, 0x00, 0x1241); /* select input 1 */ break; default: - printk(KERN_ERR "wis-uda1342: input %d not supported\n", - *inp); + dev_err(&client->dev, "input %d not supported\n", + *inp); break; } break; @@ -67,8 +67,7 @@ static int wis_uda1342_probe(struct i2c_client *client, if (!i2c_check_functionality(adapter, I2C_FUNC_SMBUS_WORD_DATA)) return -ENODEV; - printk(KERN_DEBUG - "wis-uda1342: initializing UDA1342 at address %d on %s\n", + dev_dbg(&client->dev, "initializing UDA1342 at address %d on %s\n", client->addr, adapter->name); write_reg(client, 0x00, 0x8000); /* reset registers */