From patchwork Tue Nov 6 12:34:02 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: YAMANE Toshiaki X-Patchwork-Id: 15360 Received: from mail.tu-berlin.de ([130.149.7.33]) by www.linuxtv.org with esmtp (Exim 4.72) (envelope-from ) id 1TViMM-0000X7-37 for patchwork@linuxtv.org; Tue, 06 Nov 2012 13:34:26 +0100 X-tubIT-Incoming-IP: 209.132.180.67 Received: from vger.kernel.org ([209.132.180.67]) by mail.tu-berlin.de (exim-4.75/mailfrontend-4) with esmtp for id 1TViML-00018L-B6; Tue, 06 Nov 2012 13:34:25 +0100 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751208Ab2KFMeM (ORCPT ); Tue, 6 Nov 2012 07:34:12 -0500 Received: from mail-pa0-f46.google.com ([209.85.220.46]:53156 "EHLO mail-pa0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751118Ab2KFMeJ (ORCPT ); Tue, 6 Nov 2012 07:34:09 -0500 Received: by mail-pa0-f46.google.com with SMTP id hz1so305738pad.19 for ; Tue, 06 Nov 2012 04:34:08 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:x-mailer:in-reply-to:references; bh=P6zvYa4+Lmn+hv0NfKMl72NKvDC3c3DJHd/DW9HvJqQ=; b=yJ9QrYvnO6gLA1D148Hu4TXqZozOweayf/XrYmJB0jHzWIQSc8QtYlPC+50genljhs dmn5/anU6DN45DFox+l0EI613mWYYabe5JdfLoyrrxzueX01whUf39OuYFm9QHAojGWN AZQwK1naUb29NEQOZLwd5zks91DOxUqKCQ51hdk9XPHA1wSyLlYJbwpGc4eVxsTXZpvH XKCRQcG9gog5AUY48b1Om028K3duIBjYRI2znJZdlbKCGNPTSP+xCwXz043WEpPq9S5g 2vnc+eHLXJQZ9rYyh6ZG/HB/2O7GyJFD1Tv6MlQOJ9cXrizIRzND4TugYJm+ioqwpivJ CBYQ== Received: by 10.66.88.133 with SMTP id bg5mr2098446pab.80.1352205248605; Tue, 06 Nov 2012 04:34:08 -0800 (PST) Received: from localhost (softbank220057059032.bbtec.net. [220.57.59.32]) by mx.google.com with ESMTPS id gv9sm12298756pbc.21.2012.11.06.04.34.05 (version=TLSv1/SSLv3 cipher=OTHER); Tue, 06 Nov 2012 04:34:07 -0800 (PST) From: YAMANE Toshiaki To: Mauro Carvalho Chehab Cc: Greg Kroah-Hartman , linux-media@vger.kernel.org, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org, YAMANE Toshiaki Subject: [PATCH 2/2] Staging/media: Use dev_ printks in go7007/wis-tw9903.c Date: Tue, 6 Nov 2012 21:34:02 +0900 Message-Id: <1352205243-5829-1-git-send-email-yamanetoshi@gmail.com> X-Mailer: git-send-email 1.7.9.5 In-Reply-To: <1352205206-5794-1-git-send-email-yamanetoshi@gmail.com> References: <1352205206-5794-1-git-send-email-yamanetoshi@gmail.com> Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org X-PMX-Version: 5.6.1.2065439, Antispam-Engine: 2.7.2.376379, Antispam-Data: 2012.11.6.122417 X-PMX-Spam: Gauge=IIIIIIIII, Probability=9%, Report=' FORGED_FROM_GMAIL 0.1, MULTIPLE_RCPTS 0.1, HTML_00_01 0.05, HTML_00_10 0.05, BODYTEXTP_SIZE_3000_LESS 0, BODY_SIZE_1700_1799 0, BODY_SIZE_2000_LESS 0, BODY_SIZE_5000_LESS 0, BODY_SIZE_7000_LESS 0, DKIM_SIGNATURE 0, URI_ENDS_IN_HTML 0, __ANY_URI 0, __CP_URI_IN_BODY 0, __FRAUD_BODY_WEBMAIL 0, __FRAUD_WEBMAIL 0, __FRAUD_WEBMAIL_FROM 0, __FROM_GMAIL 0, __HAS_FROM 0, __HAS_MSGID 0, __HAS_X_MAILER 0, __HAS_X_MAILING_LIST 0, __MIME_TEXT_ONLY 0, __MULTIPLE_RCPTS_CC_X2 0, __PHISH_SPEAR_STRUCTURE_1 0, __SANE_MSGID 0, __STOCK_PHRASE_7 0, __TO_MALFORMED_2 0, __URI_NO_WWW 0, __URI_NS , __YOUTUBE_RCVD 0' fixed below checkpatch warning. - WARNING: Prefer netdev_dbg(netdev, ... then dev_dbg(dev, ... then pr_debug(... to printk(KERN_DEBUG ... - WARNING: Prefer netdev_err(netdev, ... then dev_err(dev, ... then pr_err(... to printk(KERN_ERR ... Signed-off-by: YAMANE Toshiaki --- drivers/staging/media/go7007/wis-tw9903.c | 9 ++++----- 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/drivers/staging/media/go7007/wis-tw9903.c b/drivers/staging/media/go7007/wis-tw9903.c index 3821cd5..246ce17 100644 --- a/drivers/staging/media/go7007/wis-tw9903.c +++ b/drivers/staging/media/go7007/wis-tw9903.c @@ -127,8 +127,8 @@ static int wis_tw9903_command(struct i2c_client *client, 0x06, 0xc0, /* reset device */ 0, 0, }; - printk(KERN_DEBUG "vscale is %04x, hscale is %04x\n", - vscale, hscale); + dev_dbg(&client->dev, "vscale is %04x, hscale is %04x\n", + vscale, hscale); /*write_regs(client, regs);*/ break; } @@ -287,12 +287,11 @@ static int wis_tw9903_probe(struct i2c_client *client, dec->hue = 0; i2c_set_clientdata(client, dec); - printk(KERN_DEBUG - "wis-tw9903: initializing TW9903 at address %d on %s\n", + dev_dbg(&client->dev, "initializing TW9903 at address %d on %s\n", client->addr, adapter->name); if (write_regs(client, initial_registers) < 0) { - printk(KERN_ERR "wis-tw9903: error initializing TW9903\n"); + dev_err(&client->dev, "error initializing TW9903\n"); kfree(dec); return -ENODEV; }