From patchwork Tue Oct 30 12:16:34 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Javier Martin X-Patchwork-Id: 15291 Received: from mail.tu-berlin.de ([130.149.7.33]) by www.linuxtv.org with esmtp (Exim 4.72) (envelope-from ) id 1TTAkk-0007Om-42 for patchwork@linuxtv.org; Tue, 30 Oct 2012 13:17:06 +0100 X-tubIT-Incoming-IP: 209.132.180.67 Received: from vger.kernel.org ([209.132.180.67]) by mail.tu-berlin.de (exim-4.75/mailfrontend-4) with esmtp for id 1TTAkj-0005vk-Az; Tue, 30 Oct 2012 13:17:05 +0100 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933462Ab2J3MQ4 (ORCPT ); Tue, 30 Oct 2012 08:16:56 -0400 Received: from mail-ee0-f46.google.com ([74.125.83.46]:44791 "EHLO mail-ee0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S933419Ab2J3MQv (ORCPT ); Tue, 30 Oct 2012 08:16:51 -0400 Received: by mail-ee0-f46.google.com with SMTP id b15so112185eek.19 for ; Tue, 30 Oct 2012 05:16:51 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=from:to:cc:subject:date:message-id:x-mailer:in-reply-to:references :x-gm-message-state; bh=og20yjMUndAi7IVITQwOCE3KXdmyTbLzxAnufzzLXtg=; b=i5eNc2YxEop4QqiAWrPJPGa5a/SJJ9TOB9gdiY79qMs2JJxRhhL8+p+kHo5dz/MHil n2pu9TU36EFoVye9GireF1gsrfcxEbR2TdLlP+wJAVme/mteEh5s1dLiSLt+osyv6MzK rqj+QENw9Kwn4DHhXZTJXIZIvGlaCgkYOuv3GSuFBSEoj0LwXYJCP3Ey4NrHEzr/arQ7 6OooEYotkjcR8t/NKYfTOH4iNM5wA19jra6AG7SV00eJVzn3PulBD4F5A7r41MVTWtJB cH0wxR9d11+ppxAqVgvg2klT8p5dizAK9JaGJy8HHI+eCjj+rPVD+hRW2zgqubltcfE+ ZXCQ== Received: by 10.14.200.194 with SMTP id z42mr64786513een.13.1351599411256; Tue, 30 Oct 2012 05:16:51 -0700 (PDT) Received: from piscis.vsilicon.net (149.93.18.95.dynamic.jazztel.es. [95.18.93.149]) by mx.google.com with ESMTPS id f3sm1139497eeo.13.2012.10.30.05.16.49 (version=TLSv1/SSLv3 cipher=OTHER); Tue, 30 Oct 2012 05:16:50 -0700 (PDT) From: Javier Martin To: linux-media@vger.kernel.org Cc: g.liakhovetski@gmx.de, fabio.estevam@freescale.com, Javier Martin Subject: [PATCH 3/4] media: mx2_camera: Remove 'buf_cleanup' callback. Date: Tue, 30 Oct 2012 13:16:34 +0100 Message-Id: <1351599395-16833-4-git-send-email-javier.martin@vista-silicon.com> X-Mailer: git-send-email 1.7.9.5 In-Reply-To: <1351599395-16833-1-git-send-email-javier.martin@vista-silicon.com> References: <1351599395-16833-1-git-send-email-javier.martin@vista-silicon.com> X-Gm-Message-State: ALoCoQlkU07EcoM0n+pYbvolXgJ3ibwISZahzfoV+6LmtdGY88MR8Cs1Y/eMvsrtbs2s+XTWUN+k Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org X-PMX-Version: 5.6.1.2065439, Antispam-Engine: 2.7.2.376379, Antispam-Data: 2012.10.30.120619 X-PMX-Spam: Gauge=IIIIIIII, Probability=8%, Report=' MULTIPLE_RCPTS 0.1, HTML_00_01 0.05, HTML_00_10 0.05, BODYTEXTP_SIZE_3000_LESS 0, BODY_SIZE_2000_2999 0, BODY_SIZE_5000_LESS 0, BODY_SIZE_7000_LESS 0, URI_ENDS_IN_HTML 0, __ANY_URI 0, __CP_URI_IN_BODY 0, __HAS_FROM 0, __HAS_MSGID 0, __HAS_X_MAILER 0, __HAS_X_MAILING_LIST 0, __MIME_TEXT_ONLY 0, __MULTIPLE_RCPTS_CC_X2 0, __SANE_MSGID 0, __TO_MALFORMED_2 0, __TO_NO_NAME 0, __URI_NO_WWW 0, __URI_NS ' All necessary tasks to end the streaming properly are already implemented in mx2_stop_streaming() and nothing remains to be done in this callback. Furthermore, it only included debug messages so it can be removed. Signed-off-by: Javier Martin --- drivers/media/platform/soc_camera/mx2_camera.c | 34 ------------------------ 1 file changed, 34 deletions(-) diff --git a/drivers/media/platform/soc_camera/mx2_camera.c b/drivers/media/platform/soc_camera/mx2_camera.c index bf1178c..8202cb9 100644 --- a/drivers/media/platform/soc_camera/mx2_camera.c +++ b/drivers/media/platform/soc_camera/mx2_camera.c @@ -551,39 +551,6 @@ static void mx2_videobuf_queue(struct vb2_buffer *vb) spin_unlock_irqrestore(&pcdev->lock, flags); } -static void mx2_videobuf_release(struct vb2_buffer *vb) -{ -#ifdef DEBUG - struct soc_camera_device *icd = soc_camera_from_vb2q(vb->vb2_queue); - struct soc_camera_host *ici = to_soc_camera_host(icd->parent); - struct mx2_camera_dev *pcdev = ici->priv; - struct mx2_buffer *buf = container_of(vb, struct mx2_buffer, vb); - - dev_dbg(icd->parent, "%s (vb=0x%p) 0x%p %lu\n", __func__, - vb, vb2_plane_vaddr(vb, 0), vb2_get_plane_payload(vb, 0)); - - switch (buf->state) { - case MX2_STATE_ACTIVE: - dev_info(icd->parent, "%s (active)\n", __func__); - break; - case MX2_STATE_QUEUED: - dev_info(icd->parent, "%s (queued)\n", __func__); - break; - default: - dev_info(icd->parent, "%s (unknown) %d\n", __func__, - buf->state); - break; - } -#endif - - /* - * FIXME: implement forced termination of active buffers for mx27 and - * mx27 eMMA, so that the user won't get stuck in an uninterruptible - * state. This requires a specific handling for each of the these DMA - * types. - */ -} - static void mx27_camera_emma_buf_init(struct soc_camera_device *icd, int bytesperline) { @@ -814,7 +781,6 @@ static struct vb2_ops mx2_videobuf_ops = { .queue_setup = mx2_videobuf_setup, .buf_prepare = mx2_videobuf_prepare, .buf_queue = mx2_videobuf_queue, - .buf_cleanup = mx2_videobuf_release, .start_streaming = mx2_start_streaming, .stop_streaming = mx2_stop_streaming, };