From patchwork Wed Sep 26 07:18:04 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sachin Kamat X-Patchwork-Id: 14650 Received: from mail.tu-berlin.de ([130.149.7.33]) by www.linuxtv.org with esmtp (Exim 4.72) (envelope-from ) id 1TGlx5-0000N3-5R for patchwork@linuxtv.org; Wed, 26 Sep 2012 09:22:35 +0200 X-tubIT-Incoming-IP: 209.132.180.67 Received: from vger.kernel.org ([209.132.180.67]) by mail.tu-berlin.de (exim-4.75/mailfrontend-4) with esmtp for id 1TGlx4-0007aF-BG; Wed, 26 Sep 2012 09:22:35 +0200 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752861Ab2IZHW3 (ORCPT ); Wed, 26 Sep 2012 03:22:29 -0400 Received: from mail-pb0-f46.google.com ([209.85.160.46]:65236 "EHLO mail-pb0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750835Ab2IZHVt (ORCPT ); Wed, 26 Sep 2012 03:21:49 -0400 Received: by pbbrr4 with SMTP id rr4so1445093pbb.19 for ; Wed, 26 Sep 2012 00:21:49 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=from:to:cc:subject:date:message-id:x-mailer:in-reply-to:references :x-gm-message-state; bh=qk5iJih1VQysHN01SQB6eTmxD1WBGn4OzGCWMruPGA4=; b=hIP/WLGyjctUwnids41cg5j2vJkThIqjGsLUFhORHXJNKwMGLb/cU1sNgF9j+T9RM7 6K7jQ+Yx/gLqxZoxpRMvIg+xsjlFsrV15C7ZSEzT0nmyN38a6obtNozK+mwSxBycZrlY m776Lb4HTSGPmXrsfJzVP3dORuo0yEbgptqdgnJ4HPrnOisV8m3G2yQ2f2u9F9lGtrkF 8q4NybTPljYQqrwsLISpyXbI7KaqfbEqgNkDSjJT1H3xG6J5IruAQpmCYsmKcfQfP8S4 8/bLIDor0Rb/uyhk3Rubh6A4gAEqr7Snqe8U4ytzzezvLnGoHxcBg3MAByOxvg45uph7 ITfA== Received: by 10.66.72.197 with SMTP id f5mr46630820pav.20.1348644108851; Wed, 26 Sep 2012 00:21:48 -0700 (PDT) Received: from localhost.localdomain ([115.113.119.130]) by mx.google.com with ESMTPS id ru4sm1633623pbc.25.2012.09.26.00.21.46 (version=TLSv1/SSLv3 cipher=OTHER); Wed, 26 Sep 2012 00:21:48 -0700 (PDT) From: Sachin Kamat To: linux-media@vger.kernel.org Cc: s.nawrocki@samsung.com, shaik.ameer@samsung.com, sachin.kamat@linaro.org, patches@linaro.org Subject: [PATCH 2/2] [media] exynos-gsc: Add missing static storage class specifiers Date: Wed, 26 Sep 2012 12:48:04 +0530 Message-Id: <1348643884-4005-2-git-send-email-sachin.kamat@linaro.org> X-Mailer: git-send-email 1.7.4.1 In-Reply-To: <1348643884-4005-1-git-send-email-sachin.kamat@linaro.org> References: <1348643884-4005-1-git-send-email-sachin.kamat@linaro.org> X-Gm-Message-State: ALoCoQlwVXxAeu601vF6ljRtbXd0pfbn7/e6yCQkg6ZbZwuPX5XI2Rh5LdCSQt79uuqeqb5hSvfJ Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org X-PMX-Version: 5.6.1.2065439, Antispam-Engine: 2.7.2.376379, Antispam-Data: 2012.9.26.71221 X-PMX-Spam: Gauge=IIIIIIII, Probability=8%, Report=' MULTIPLE_RCPTS 0.1, HTML_00_01 0.05, HTML_00_10 0.05, BODYTEXTP_SIZE_3000_LESS 0, BODY_SIZE_2000_2999 0, BODY_SIZE_5000_LESS 0, BODY_SIZE_7000_LESS 0, URI_ENDS_IN_HTML 0, __ANY_URI 0, __CP_URI_IN_BODY 0, __HAS_FROM 0, __HAS_MSGID 0, __HAS_X_MAILER 0, __HAS_X_MAILING_LIST 0, __MIME_TEXT_ONLY 0, __MULTIPLE_RCPTS_CC_X2 0, __SANE_MSGID 0, __SUBJ_ALPHA_END 0, __TO_MALFORMED_2 0, __TO_NO_NAME 0, __URI_NO_WWW 0, __URI_NS ' Fixes the following warnings: drivers/media/platform/exynos-gsc/gsc-core.c:313:5: warning: symbol 'get_plane_info' was not declared. Should it be static? drivers/media/platform/exynos-gsc/gsc-core.c:746:28: warning: symbol 'gsc_ctrl_ops' was not declared. Should it be static? drivers/media/platform/exynos-gsc/gsc-m2m.c:102:5: warning: symbol 'gsc_fill_addr' was not declared. Should it be static? drivers/media/platform/exynos-gsc/gsc-m2m.c:252:16: warning: symbol 'gsc_m2m_qops' was not declared. Should it be static? Signed-off-by: Sachin Kamat --- drivers/media/platform/exynos-gsc/gsc-core.c | 4 ++-- drivers/media/platform/exynos-gsc/gsc-m2m.c | 4 ++-- 2 files changed, 4 insertions(+), 4 deletions(-) diff --git a/drivers/media/platform/exynos-gsc/gsc-core.c b/drivers/media/platform/exynos-gsc/gsc-core.c index 90a6c55..bfec9e6 100644 --- a/drivers/media/platform/exynos-gsc/gsc-core.c +++ b/drivers/media/platform/exynos-gsc/gsc-core.c @@ -310,7 +310,7 @@ int gsc_enum_fmt_mplane(struct v4l2_fmtdesc *f) return 0; } -u32 get_plane_info(struct gsc_frame *frm, u32 addr, u32 *index) +static u32 get_plane_info(struct gsc_frame *frm, u32 addr, u32 *index) { if (frm->addr.y == addr) { *index = 0; @@ -743,7 +743,7 @@ static int gsc_s_ctrl(struct v4l2_ctrl *ctrl) return ret; } -const struct v4l2_ctrl_ops gsc_ctrl_ops = { +static const struct v4l2_ctrl_ops gsc_ctrl_ops = { .s_ctrl = gsc_s_ctrl, }; diff --git a/drivers/media/platform/exynos-gsc/gsc-m2m.c b/drivers/media/platform/exynos-gsc/gsc-m2m.c index a4f327e..3c7f005 100644 --- a/drivers/media/platform/exynos-gsc/gsc-m2m.c +++ b/drivers/media/platform/exynos-gsc/gsc-m2m.c @@ -99,7 +99,7 @@ static void gsc_m2m_job_abort(void *priv) gsc_m2m_job_finish(ctx, VB2_BUF_STATE_ERROR); } -int gsc_fill_addr(struct gsc_ctx *ctx) +static int gsc_fill_addr(struct gsc_ctx *ctx) { struct gsc_frame *s_frame, *d_frame; struct vb2_buffer *vb = NULL; @@ -249,7 +249,7 @@ static void gsc_m2m_buf_queue(struct vb2_buffer *vb) v4l2_m2m_buf_queue(ctx->m2m_ctx, vb); } -struct vb2_ops gsc_m2m_qops = { +static struct vb2_ops gsc_m2m_qops = { .queue_setup = gsc_m2m_queue_setup, .buf_prepare = gsc_m2m_buf_prepare, .buf_queue = gsc_m2m_buf_queue,