From patchwork Mon Sep 24 10:58:52 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Federico Vaga X-Patchwork-Id: 14615 Received: from mail.tu-berlin.de ([130.149.7.33]) by www.linuxtv.org with esmtp (Exim 4.72) (envelope-from ) id 1TG6LX-0002Kg-OA for patchwork@linuxtv.org; Mon, 24 Sep 2012 12:57:03 +0200 X-tubIT-Incoming-IP: 209.132.180.67 Received: from vger.kernel.org ([209.132.180.67]) by mail.tu-berlin.de (exim-4.75/mailfrontend-3) with esmtp for id 1TG6LX-0001np-Dd; Mon, 24 Sep 2012 12:57:03 +0200 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754188Ab2IXK4p (ORCPT ); Mon, 24 Sep 2012 06:56:45 -0400 Received: from mail-ee0-f46.google.com ([74.125.83.46]:65158 "EHLO mail-ee0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751920Ab2IXK4n (ORCPT ); Mon, 24 Sep 2012 06:56:43 -0400 Received: by eekb15 with SMTP id b15so134582eek.19 for ; Mon, 24 Sep 2012 03:56:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:x-mailer:in-reply-to:references; bh=RclNMhlcicgnJfhWIm2goKiq58Wznobgag0ljIgM9AQ=; b=NwoaPS29BL0/9dgTZrYdRoeGZRsdip/iI4nmSe/RtHENkaIzpoaNUF4Q++KwyR5P21 KQibdp676P8tVg4mOzIufFlvolh2jGXogissF6UBiVWIUmDAAW77gr6lPFvdGNbKlln3 EhNhPcXsp2gNZrnaKBuQR1usv39g7af90kkAkjksYXbC2dPFuxxi/largjodm7NLn7/Q bpNsBqobQ/L+zOuiMn0PiDxf/RSc3vx+z6k+XSetQe3DRa5sVSGfgTyTZUPZWHZyc/7+ wRfP9IfbTYQOG7darvRENx1tOPn3JKWCF3Y5m2MYt3r0M9I5iIqp34jgTrdHeZo4R67n yR1Q== Received: by 10.14.179.136 with SMTP id h8mr14101326eem.6.1348484202171; Mon, 24 Sep 2012 03:56:42 -0700 (PDT) Received: from harkonnen.fastwebnet.it (2-225-41-194.ip174.fastwebnet.it. [2.225.41.194]) by mx.google.com with ESMTPS id k49sm45299591een.4.2012.09.24.03.56.38 (version=SSLv3 cipher=OTHER); Mon, 24 Sep 2012 03:56:41 -0700 (PDT) From: Federico Vaga To: Mauro Carvalho Chehab , Pawel Osciak , Marek Szyprowski , Hans Verkuil Cc: Giancarlo Asnaghi , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, Jonathan Corbet , Federico Vaga Subject: [PATCH v3 4/4] adv7180: remove {query/g_/s_}ctrl Date: Mon, 24 Sep 2012 12:58:52 +0200 Message-Id: <1348484332-8106-4-git-send-email-federico.vaga@gmail.com> X-Mailer: git-send-email 1.7.11.4 In-Reply-To: <1348484332-8106-1-git-send-email-federico.vaga@gmail.com> References: <1348484332-8106-1-git-send-email-federico.vaga@gmail.com> Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org X-PMX-Version: 5.6.1.2065439, Antispam-Engine: 2.7.2.376379, Antispam-Data: 2012.9.24.104515 X-PMX-Spam: Gauge=IIIIIIIII, Probability=9%, Report=' FORGED_FROM_GMAIL 0.1, MULTIPLE_RCPTS 0.1, HTML_00_01 0.05, HTML_00_10 0.05, BODYTEXTP_SIZE_3000_LESS 0, BODY_SIZE_1000_1099 0, BODY_SIZE_2000_LESS 0, BODY_SIZE_5000_LESS 0, BODY_SIZE_7000_LESS 0, DKIM_SIGNATURE 0, URI_ENDS_IN_HTML 0, __ANY_URI 0, __CP_URI_IN_BODY 0, __FRAUD_BODY_WEBMAIL 0, __FRAUD_WEBMAIL 0, __FRAUD_WEBMAIL_FROM 0, __FROM_GMAIL 0, __HAS_FROM 0, __HAS_MSGID 0, __HAS_X_MAILER 0, __HAS_X_MAILING_LIST 0, __MIME_TEXT_ONLY 0, __MULTIPLE_RCPTS_CC_X2 0, __PHISH_SPEAR_STRUCTURE_1 0, __SANE_MSGID 0, __TO_MALFORMED_2 0, __URI_NO_WWW 0, __URI_NS ' All drivers which use this subdevice use also the control framework. The v4l2_subdev_core_ops operations {query/g_/s_}ctrl are useless because device drivers will inherit controls from this subdevice. Signed-off-by: Federico Vaga --- drivers/media/i2c/adv7180.c | 3 --- 1 file modificato, 3 rimozioni(-) diff --git a/drivers/media/i2c/adv7180.c b/drivers/media/i2c/adv7180.c index 45ecf8d..43bc2b9 100644 --- a/drivers/media/i2c/adv7180.c +++ b/drivers/media/i2c/adv7180.c @@ -402,9 +402,6 @@ static const struct v4l2_subdev_video_ops adv7180_video_ops = { static const struct v4l2_subdev_core_ops adv7180_core_ops = { .g_chip_ident = adv7180_g_chip_ident, .s_std = adv7180_s_std, - .queryctrl = v4l2_subdev_queryctrl, - .g_ctrl = v4l2_subdev_g_ctrl, - .s_ctrl = v4l2_subdev_s_ctrl, }; static const struct v4l2_subdev_ops adv7180_ops = {