From patchwork Fri Sep 21 09:21:38 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Federico Vaga X-Patchwork-Id: 14571 Received: from mail.tu-berlin.de ([130.149.7.33]) by www.linuxtv.org with esmtp (Exim 4.72) (envelope-from ) id 1TEzS1-0005fO-Fm for patchwork@linuxtv.org; Fri, 21 Sep 2012 11:23:09 +0200 X-tubIT-Incoming-IP: 209.132.180.67 Received: from vger.kernel.org ([209.132.180.67]) by mail.tu-berlin.de (exim-4.75/mailfrontend-4) with esmtp for id 1TEzS0-0002t5-CK; Fri, 21 Sep 2012 11:23:09 +0200 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751138Ab2IUJWt (ORCPT ); Fri, 21 Sep 2012 05:22:49 -0400 Received: from mail-ey0-f174.google.com ([209.85.215.174]:35563 "EHLO mail-ey0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932102Ab2IUJWV (ORCPT ); Fri, 21 Sep 2012 05:22:21 -0400 Received: by mail-ey0-f174.google.com with SMTP id c11so993295eaa.19 for ; Fri, 21 Sep 2012 02:22:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:x-mailer:in-reply-to:references; bh=qJgRsBzSMjFUix89jRmMHnuZMnlQ4ESAHz5rqG4IBVs=; b=BA/QKkpKHhikdV2k8MCZXPrc5HeBB+yqej77mc+dtvMp23KSuLVH5KcIIXI4MsGSW/ LHh+O3hiJW4y24K2MQUTwJr9FVWIU/AUQoFMnMAwFKrrinFr3ncHIFs9kqbO5X2yJ1cI WLFGUKfjetZUwdTT3UPMe5/2neOkhUgx+eVzul31Li0aldNdKY7Lr3z4wiany29w6LyW olCirPWXPMrF+o8YzGEko9DkbPsEicG3KtuOcvncc5/Z/3RY7W6aVveDZFqpkN6AklfW 9hP7M7GLX6vtfOR7MrNYZB6pAw1j7l0FD2XRbCMo9GWakM2kmnVSUaKL33GgKLN01dIW 3qbA== Received: by 10.14.201.73 with SMTP id a49mr4897529eeo.39.1348219340744; Fri, 21 Sep 2012 02:22:20 -0700 (PDT) Received: from harkonnen.fastwebnet.it (2-225-41-194.ip174.fastwebnet.it. [2.225.41.194]) by mx.google.com with ESMTPS id a7sm22241920eep.14.2012.09.21.02.22.18 (version=SSLv3 cipher=OTHER); Fri, 21 Sep 2012 02:22:19 -0700 (PDT) From: Federico Vaga To: Mauro Carvalho Chehab , Pawel Osciak , Marek Szyprowski , Hans Verkuil Cc: Giancarlo Asnaghi , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, Jonathan Corbet , Federico Vaga Subject: [PATCH v2 4/4] adv7180: remove {query/g_/s_}ctrl Date: Fri, 21 Sep 2012 11:21:38 +0200 Message-Id: <1348219298-23273-4-git-send-email-federico.vaga@gmail.com> X-Mailer: git-send-email 1.7.11.4 In-Reply-To: <1348219298-23273-1-git-send-email-federico.vaga@gmail.com> References: <1348219298-23273-1-git-send-email-federico.vaga@gmail.com> Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org X-PMX-Version: 5.6.1.2065439, Antispam-Engine: 2.7.2.376379, Antispam-Data: 2012.9.21.91236 X-PMX-Spam: Gauge=IIIIIIIII, Probability=9%, Report=' FORGED_FROM_GMAIL 0.1, MULTIPLE_RCPTS 0.1, HTML_00_01 0.05, HTML_00_10 0.05, BODYTEXTP_SIZE_3000_LESS 0, BODY_SIZE_1000_1099 0, BODY_SIZE_2000_LESS 0, BODY_SIZE_5000_LESS 0, BODY_SIZE_7000_LESS 0, DKIM_SIGNATURE 0, URI_ENDS_IN_HTML 0, __ANY_URI 0, __CP_URI_IN_BODY 0, __FRAUD_BODY_WEBMAIL 0, __FRAUD_WEBMAIL 0, __FRAUD_WEBMAIL_FROM 0, __FROM_GMAIL 0, __HAS_FROM 0, __HAS_MSGID 0, __HAS_X_MAILER 0, __HAS_X_MAILING_LIST 0, __MIME_TEXT_ONLY 0, __MULTIPLE_RCPTS_CC_X2 0, __PHISH_SPEAR_STRUCTURE_1 0, __SANE_MSGID 0, __TO_MALFORMED_2 0, __URI_NO_WWW 0, __URI_NS ' All drivers which use this subdevice use also the control framework. The v4l2_subdev_core_ops operations {query/g_/s_}ctrl are useless because device drivers will inherit the controls from this subdevice. Signed-off-by: Federico Vaga --- drivers/media/i2c/adv7180.c | 3 --- 1 file modificato, 3 rimozioni(-) diff --git a/drivers/media/i2c/adv7180.c b/drivers/media/i2c/adv7180.c index 45ecf8d..43bc2b9 100644 --- a/drivers/media/i2c/adv7180.c +++ b/drivers/media/i2c/adv7180.c @@ -402,9 +402,6 @@ static const struct v4l2_subdev_video_ops adv7180_video_ops = { static const struct v4l2_subdev_core_ops adv7180_core_ops = { .g_chip_ident = adv7180_g_chip_ident, .s_std = adv7180_s_std, - .queryctrl = v4l2_subdev_queryctrl, - .g_ctrl = v4l2_subdev_g_ctrl, - .s_ctrl = v4l2_subdev_s_ctrl, }; static const struct v4l2_subdev_ops adv7180_ops = {