From patchwork Fri Sep 14 09:20:17 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Sachin Kamat X-Patchwork-Id: 14362 Received: from mail.tu-berlin.de ([130.149.7.33]) by www.linuxtv.org with esmtp (Exim 4.72) (envelope-from ) id 1TCS7e-0003oI-VI for patchwork@linuxtv.org; Fri, 14 Sep 2012 11:23:38 +0200 X-tubIT-Incoming-IP: 209.132.180.67 Received: from vger.kernel.org ([209.132.180.67]) by mail.tu-berlin.de (exim-4.75/mailfrontend-4) with esmtp for id 1TCS7e-0005nA-Aj; Fri, 14 Sep 2012 11:23:38 +0200 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758462Ab2INJXb (ORCPT ); Fri, 14 Sep 2012 05:23:31 -0400 Received: from mail-pb0-f46.google.com ([209.85.160.46]:44056 "EHLO mail-pb0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1759326Ab2INJX3 (ORCPT ); Fri, 14 Sep 2012 05:23:29 -0400 Received: by pbbrr13 with SMTP id rr13so5348526pbb.19 for ; Fri, 14 Sep 2012 02:23:29 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=from:to:cc:subject:date:message-id:x-mailer:x-gm-message-state; bh=p/4l4vqnQ+6oHBMYFQzCUmFh7SVBWxqy/H+ek/uZZS8=; b=P9Jpn5zGEMcbJBwkJapJ1YSMGftYIfuqlkpKg9HscmvWoFcVAubOQSXqO5rFuJ6Gak rUN8AeXZrfR9+Nd/9ZHa7Ep3x0PyBQmeJq6LwYYIsV/q2/heIzlu0s4587w/bFh5/8x1 VnDGysl/1FBxiwqhjiFNg9/I0JdNwTk9jUfrCXx/R0DptnJIwR2TUHLIvAote2yroa9N R9zE6nfZ8d76i7uO4NFjJhz+MPeAu11jjsqce1JjlX/SMIFhx4wYFqC6MiK51xRxJS1h rPAf/2MJCsTr5HlGkQyF8DlBBdN1zfYucZdoYmTmzQ3ddA5RBcO9QW+3y9RjHRExf1uW Lvvw== Received: by 10.68.223.164 with SMTP id qv4mr4538167pbc.20.1347614609109; Fri, 14 Sep 2012 02:23:29 -0700 (PDT) Received: from localhost.localdomain ([115.113.119.130]) by mx.google.com with ESMTPS id ou6sm703517pbc.9.2012.09.14.02.23.25 (version=TLSv1/SSLv3 cipher=OTHER); Fri, 14 Sep 2012 02:23:28 -0700 (PDT) From: Sachin Kamat To: linux-media@vger.kernel.org Cc: mchehab@infradead.org, s.nawrocki@samsung.com, k.debski@samsung.com, sachin.kamat@linaro.org, patches@linaro.org Subject: [PATCH] [media] s5p-mfc: Remove unreachable code Date: Fri, 14 Sep 2012 14:50:17 +0530 Message-Id: <1347614417-19343-1-git-send-email-sachin.kamat@linaro.org> X-Mailer: git-send-email 1.7.4.1 X-Gm-Message-State: ALoCoQmd62rMC7wEMIL38VC7nBjLtBFMdLOXHmjXEUT6pxwzQm+3BbJLOWxMXLWGN4yAHepFToK5 Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org X-PMX-Version: 5.6.1.2065439, Antispam-Engine: 2.7.2.376379, Antispam-Data: 2012.9.14.91218 X-PMX-Spam: Gauge=IIIIIIII, Probability=8%, Report=' MULTIPLE_RCPTS 0.1, HTML_00_01 0.05, HTML_00_10 0.05, BODYTEXTP_SIZE_3000_LESS 0, BODY_SIZE_1600_1699 0, BODY_SIZE_2000_LESS 0, BODY_SIZE_5000_LESS 0, BODY_SIZE_7000_LESS 0, URI_ENDS_IN_HTML 0, __ANY_URI 0, __CP_URI_IN_BODY 0, __HAS_FROM 0, __HAS_MSGID 0, __HAS_X_MAILER 0, __HAS_X_MAILING_LIST 0, __MIME_TEXT_ONLY 0, __MULTIPLE_RCPTS_CC_X2 0, __SANE_MSGID 0, __SUBJ_ALPHA_END 0, __TO_MALFORMED_2 0, __TO_NO_NAME 0, __URI_NO_WWW 0, __URI_NS ' Code after return statement never gets executed. Hence can be deleted. Signed-off-by: Sachin Kamat --- drivers/media/platform/s5p-mfc/s5p_mfc.c | 21 +-------------------- 1 files changed, 1 insertions(+), 20 deletions(-) diff --git a/drivers/media/platform/s5p-mfc/s5p_mfc.c b/drivers/media/platform/s5p-mfc/s5p_mfc.c index e3e616d..56876be 100644 --- a/drivers/media/platform/s5p-mfc/s5p_mfc.c +++ b/drivers/media/platform/s5p-mfc/s5p_mfc.c @@ -1144,30 +1144,11 @@ static int s5p_mfc_suspend(struct device *dev) { struct platform_device *pdev = to_platform_device(dev); struct s5p_mfc_dev *m_dev = platform_get_drvdata(pdev); - int ret; if (m_dev->num_inst == 0) return 0; - return s5p_mfc_sleep(m_dev); - if (test_and_set_bit(0, &m_dev->enter_suspend) != 0) { - mfc_err("Error: going to suspend for a second time\n"); - return -EIO; - } - /* Check if we're processing then wait if it necessary. */ - while (test_and_set_bit(0, &m_dev->hw_lock) != 0) { - /* Try and lock the HW */ - /* Wait on the interrupt waitqueue */ - ret = wait_event_interruptible_timeout(m_dev->queue, - m_dev->int_cond || m_dev->ctx[m_dev->curr_ctx]->int_cond, - msecs_to_jiffies(MFC_INT_TIMEOUT)); - - if (ret == 0) { - mfc_err("Waiting for hardware to finish timed out\n"); - return -EIO; - } - } - return 0; + return s5p_mfc_sleep(m_dev); } static int s5p_mfc_resume(struct device *dev)