From patchwork Tue Aug 7 02:46:54 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Devin Heitmueller X-Patchwork-Id: 13636 Received: from mail.tu-berlin.de ([130.149.7.33]) by www.linuxtv.org with esmtp (Exim 4.72) (envelope-from ) id 1SyZpq-00071W-Mv for patchwork@linuxtv.org; Tue, 07 Aug 2012 04:47:54 +0200 X-tubIT-Incoming-IP: 209.132.180.67 Received: from vger.kernel.org ([209.132.180.67]) by mail.tu-berlin.de (exim-4.75/mailfrontend-3) with esmtp for id 1SyZpq-0000ST-DJ; Tue, 07 Aug 2012 04:47:54 +0200 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932504Ab2HGCru (ORCPT ); Mon, 6 Aug 2012 22:47:50 -0400 Received: from mail-vc0-f174.google.com ([209.85.220.174]:32810 "EHLO mail-vc0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932486Ab2HGCrt (ORCPT ); Mon, 6 Aug 2012 22:47:49 -0400 Received: by mail-vc0-f174.google.com with SMTP id fk26so3432645vcb.19 for ; Mon, 06 Aug 2012 19:47:49 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=from:to:cc:subject:date:message-id:x-mailer:in-reply-to:references :x-gm-message-state; bh=mXaIVY2IFqNXnD0xMBal/aSSgBFod861fOo+94VNa6s=; b=ArAQHRYQJ7+pANEfQbM5WlYjTOKo9rCNuu66n1uwcb6DPuv8mO9WvajBV3uhH9Qp3O LkDMbJnSGZ9frJ3Mj8PjN6ZGZnJcgBPlojJLQVdtoC+/+fjI57OBBMPX33tC7w8J9REU qFojiV3WXDjn/yyTw/j0IY4miSQaLzqCXMhT3Jo1YmrrzrR87y+cseC9Yvo48DtHCgVd SfWaDLoffBUy8J2kRRy85YtvAPaNn3a8a1U1B90U3yKKis9P2DB2z1KEq6wl5qU/FMPr JWhWBG5QlheyTXo7OI9er9WgHewLQ6tOwnW1gAy2gy3PMafLrizTxBsV60d/G6wSJPoX 6q0Q== Received: by 10.220.242.73 with SMTP id lh9mr9806227vcb.4.1344307669067; Mon, 06 Aug 2012 19:47:49 -0700 (PDT) Received: from localhost.localdomain (pool-108-54-72-165.nycmny.fios.verizon.net. [108.54.72.165]) by mx.google.com with ESMTPS id e9sm17555638vdf.21.2012.08.06.19.47.48 (version=TLSv1/SSLv3 cipher=OTHER); Mon, 06 Aug 2012 19:47:48 -0700 (PDT) From: Devin Heitmueller To: linux-media@vger.kernel.org Cc: Devin Heitmueller Subject: [PATCH 04/24] au0828: Make the s_reg and g_reg advanced debug calls work against the bridge Date: Mon, 6 Aug 2012 22:46:54 -0400 Message-Id: <1344307634-11673-5-git-send-email-dheitmueller@kernellabs.com> X-Mailer: git-send-email 1.7.1 In-Reply-To: <1344307634-11673-1-git-send-email-dheitmueller@kernellabs.com> References: <1344307634-11673-1-git-send-email-dheitmueller@kernellabs.com> X-Gm-Message-State: ALoCoQkJ7/h0ZkIPkqxN7sk2ppCMHiC5Ei3TbSyb8qS9QqPi19SQjbN9nxFxmFPBFXNq2gY+nDv4 Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org X-PMX-Version: 5.6.1.2065439, Antispam-Engine: 2.7.2.376379, Antispam-Data: 2012.8.7.23319 X-PMX-Spam: Gauge=IIIIIIII, Probability=8%, Report=' HTML_00_01 0.05, HTML_00_10 0.05, BODYTEXTP_SIZE_3000_LESS 0, BODY_SIZE_1500_1599 0, BODY_SIZE_2000_LESS 0, BODY_SIZE_5000_LESS 0, BODY_SIZE_7000_LESS 0, DATE_TZ_NA 0, URI_ENDS_IN_HTML 0, __ANY_URI 0, __CP_MEDIA_BODY 0, __CP_URI_IN_BODY 0, __HAS_FROM 0, __HAS_MSGID 0, __HAS_X_MAILER 0, __HAS_X_MAILING_LIST 0, __MIME_TEXT_ONLY 0, __SANE_MSGID 0, __SUBJ_ALPHA_END 0, __TO_MALFORMED_2 0, __TO_NO_NAME 0, __URI_NO_WWW 0, __URI_NS ' The g_reg and s_reg calls worked properly if acting on subdev registers (such as the au8522), but didn't work against the au0828 itself. Copy the logic over from em28xx. Signed-off-by: Devin Heitmueller --- drivers/media/video/au0828/au0828-video.c | 11 ++++++++--- 1 files changed, 8 insertions(+), 3 deletions(-) diff --git a/drivers/media/video/au0828/au0828-video.c b/drivers/media/video/au0828/au0828-video.c index ac3dd73..6e30c09 100644 --- a/drivers/media/video/au0828/au0828-video.c +++ b/drivers/media/video/au0828/au0828-video.c @@ -1717,8 +1717,12 @@ static int vidioc_g_register(struct file *file, void *priv, v4l2_device_call_all(&dev->v4l2_dev, 0, core, g_register, reg); return 0; default: - return -EINVAL; + if (!v4l2_chip_match_host(®->match)) + return -EINVAL; } + + reg->val = au0828_read(dev, reg->reg); + return 0; } static int vidioc_s_register(struct file *file, void *priv, @@ -1732,9 +1736,10 @@ static int vidioc_s_register(struct file *file, void *priv, v4l2_device_call_all(&dev->v4l2_dev, 0, core, s_register, reg); return 0; default: - return -EINVAL; + if (!v4l2_chip_match_host(®->match)) + return -EINVAL; } - return 0; + return au0828_writereg(dev, reg->reg, reg->val); } #endif