From patchwork Tue Aug 7 02:47:11 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Devin Heitmueller X-Patchwork-Id: 13649 Received: from mail.tu-berlin.de ([130.149.7.33]) by www.linuxtv.org with esmtp (Exim 4.72) (envelope-from ) id 1SyZqK-00073p-Lk for patchwork@linuxtv.org; Tue, 07 Aug 2012 04:48:24 +0200 X-tubIT-Incoming-IP: 209.132.180.67 Received: from vger.kernel.org ([209.132.180.67]) by mail.tu-berlin.de (exim-4.75/mailfrontend-4) with esmtp for id 1SyZqK-0002OB-9q; Tue, 07 Aug 2012 04:48:24 +0200 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932587Ab2HGCsT (ORCPT ); Mon, 6 Aug 2012 22:48:19 -0400 Received: from mail-vc0-f174.google.com ([209.85.220.174]:52727 "EHLO mail-vc0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932579Ab2HGCsJ (ORCPT ); Mon, 6 Aug 2012 22:48:09 -0400 Received: by mail-vc0-f174.google.com with SMTP id fk26so3432709vcb.19 for ; Mon, 06 Aug 2012 19:48:08 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=from:to:cc:subject:date:message-id:x-mailer:in-reply-to:references :x-gm-message-state; bh=ivs3VNpnSSwCfAKr8DQQBbYAar6LgFKs49YNLu8D8S8=; b=mbpVmgZ/dKVOEnUErUt2SMKzdHns6v71v1vb+8Ab6Aifi0oB7jYvU5/uFSf33yltno 1DERhxin4RFNyr0ekLYvEtTVv0Bh6wp9brvDHsvOR3aqD6XHqWKUGNxan6Kt4Jl9pY+n YyZrgQiL2sf/zCnbCqDufQN12H9fmx+SWb/Ui9yKepDBx4yQX7gd0ATuLT3MkdIgV33U sIyc1bVwHg9ADpeXlHtCtWD6FE2JOqa+ybiUYlBrl8RokI2Q29giBHmU1D0lU4itwJQv Ahdm9QHAcp0RoCIQxiSwrKKtW0lss+B54aRaIO9Tf/SRMOunQpqLHvgLZsiJys0OZXd6 y/ug== Received: by 10.52.97.230 with SMTP id ed6mr8396258vdb.65.1344307688616; Mon, 06 Aug 2012 19:48:08 -0700 (PDT) Received: from localhost.localdomain (pool-108-54-72-165.nycmny.fios.verizon.net. [108.54.72.165]) by mx.google.com with ESMTPS id e9sm17555638vdf.21.2012.08.06.19.48.07 (version=TLSv1/SSLv3 cipher=OTHER); Mon, 06 Aug 2012 19:48:07 -0700 (PDT) From: Devin Heitmueller To: linux-media@vger.kernel.org Cc: Devin Heitmueller Subject: [PATCH 21/24] xc5000: show debug version fields in decimal instead of hex Date: Mon, 6 Aug 2012 22:47:11 -0400 Message-Id: <1344307634-11673-22-git-send-email-dheitmueller@kernellabs.com> X-Mailer: git-send-email 1.7.1 In-Reply-To: <1344307634-11673-1-git-send-email-dheitmueller@kernellabs.com> References: <1344307634-11673-1-git-send-email-dheitmueller@kernellabs.com> X-Gm-Message-State: ALoCoQmmL1CYl6bq9Ek1ZFVzMz5KkURhobAsKa5X1JPRZwOe8Du1EvuNfZJDYAiUc1EzY5ufdppp Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org X-PMX-Version: 5.6.1.2065439, Antispam-Engine: 2.7.2.376379, Antispam-Data: 2012.8.7.23921 X-PMX-Spam: Gauge=IIIIIIII, Probability=8%, Report=' HTML_00_01 0.05, HTML_00_10 0.05, BODYTEXTP_SIZE_3000_LESS 0, BODY_SIZE_1200_1299 0, BODY_SIZE_2000_LESS 0, BODY_SIZE_5000_LESS 0, BODY_SIZE_7000_LESS 0, DATE_TZ_NA 0, URI_ENDS_IN_HTML 0, __ANY_URI 0, __CP_URI_IN_BODY 0, __HAS_FROM 0, __HAS_MSGID 0, __HAS_X_MAILER 0, __HAS_X_MAILING_LIST 0, __MIME_TEXT_ONLY 0, __SANE_MSGID 0, __STOCK_PHRASE_7 0, __SUBJ_ALPHA_END 0, __TO_MALFORMED_2 0, __TO_NO_NAME 0, __URI_NO_WWW 0, __URI_NS ' The driver prints out a dotted version number but it's in hex. As a result, the version doesn't visibly match the filename for the firmware, and it caused a bunch of confusion while discussing different versions with the chip manufacturer. Change the firmware printout to be in decimal. Signed-off-by: Devin Heitmueller --- drivers/media/common/tuners/xc5000.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/media/common/tuners/xc5000.c b/drivers/media/common/tuners/xc5000.c index 3e5f8cd..4bb20fa 100644 --- a/drivers/media/common/tuners/xc5000.c +++ b/drivers/media/common/tuners/xc5000.c @@ -702,7 +702,7 @@ static void xc_debug_dump(struct xc5000_priv *priv) xc_get_version(priv, &hw_majorversion, &hw_minorversion, &fw_majorversion, &fw_minorversion); xc_get_buildversion(priv, &fw_buildversion); - dprintk(1, "*** HW: V%02x.%02x, FW: V%02x.%02x.%04x\n", + dprintk(1, "*** HW: V%d.%d, FW: V %d.%d.%d\n", hw_majorversion, hw_minorversion, fw_majorversion, fw_minorversion, fw_buildversion);