From patchwork Sat Jun 23 11:59:54 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: santosh nayak X-Patchwork-Id: 13039 Received: from mail.tu-berlin.de ([130.149.7.33]) by www.linuxtv.org with esmtp (Exim 4.72) (envelope-from ) id 1SiP0n-0007pQ-Sp for patchwork@linuxtv.org; Sat, 23 Jun 2012 14:00:21 +0200 X-tubIT-Incoming-IP: 209.132.180.67 Received: from vger.kernel.org ([209.132.180.67]) by mail.tu-berlin.de (exim-4.75/mailfrontend-3) with esmtp for id 1SiP0n-0004KA-EG; Sat, 23 Jun 2012 14:00:21 +0200 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753201Ab2FWMAP (ORCPT ); Sat, 23 Jun 2012 08:00:15 -0400 Received: from mail-pz0-f46.google.com ([209.85.210.46]:38833 "EHLO mail-pz0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751808Ab2FWMAN (ORCPT ); Sat, 23 Jun 2012 08:00:13 -0400 Received: by dady13 with SMTP id y13so3404471dad.19 for ; Sat, 23 Jun 2012 05:00:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:x-mailer; bh=DBZ3jUwgvx+fWZXd4oARP6wq7s6v6WPYhyJMsVW9z3Y=; b=tdZ08sFBGdlPI8vsyTOS4SmSXpCLOxB9ZVbMBhgpCN+Pix8RcMvw/wvbftP7ctKD7x 9hBAzyGYd4ab901msHQWu9QYckQ4cwlwS5dy1/kYB+8jdQYYQJyLVo11ugTWnfPDx85V r6qzBzgnOEQTlTMrSu+9FYrfx9z9PCGkoH5pmX+yIgbxcLOi/WG3zaqbh/xUNWO0gELg ra4BQ7DLwoaYdye9b0rSFWj7n5YI8eI3dsxm2GxVCy7xhUVdQfjzmkykyszO7CqOK6Zd G87dJDt890ZwzscvN8VyQsh2RZaWqTH+7bHzRtZf4hpOIyOpqkS8zR+O9J2umvUkbj8M Nnog== Received: by 10.68.227.198 with SMTP id sc6mr19704282pbc.138.1340452813266; Sat, 23 Jun 2012 05:00:13 -0700 (PDT) Received: from localhost.localdomain ([14.97.34.17]) by mx.google.com with ESMTPS id oy8sm2157656pbc.52.2012.06.23.05.00.10 (version=TLSv1/SSLv3 cipher=OTHER); Sat, 23 Jun 2012 05:00:12 -0700 (PDT) From: santosh nayak To: mchehab@infradead.org, linux-media@vger.kernel.org Cc: viro@zeniv.linux.org.uk, kernel-janitors@vger.kernel.org, Santosh Nayak Subject: [PATCH] dvb-core: Release semaphore on error path dvb_register_device(). Date: Sat, 23 Jun 2012 17:29:54 +0530 Message-Id: <1340452794-8117-1-git-send-email-santoshprasadnayak@gmail.com> X-Mailer: git-send-email 1.7.4.4 Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org X-PMX-Version: 5.6.1.2065439, Antispam-Engine: 2.7.2.376379, Antispam-Data: 2012.6.23.115137 X-PMX-Spam: Gauge=IIIIIIIII, Probability=9%, Report=' FORGED_FROM_GMAIL 0.1, MULTIPLE_RCPTS 0.1, HTML_00_01 0.05, HTML_00_10 0.05, BODYTEXTP_SIZE_3000_LESS 0, BODY_SIZE_1000_1099 0, BODY_SIZE_2000_LESS 0, BODY_SIZE_5000_LESS 0, BODY_SIZE_7000_LESS 0, URI_ENDS_IN_HTML 0, __ANY_URI 0, __CP_URI_IN_BODY 0, __FRAUD_BODY_WEBMAIL 0, __FRAUD_WEBMAIL 0, __FRAUD_WEBMAIL_FROM 0, __FROM_GMAIL 0, __HAS_FROM 0, __HAS_MSGID 0, __HAS_X_MAILER 0, __HAS_X_MAILING_LIST 0, __MIME_TEXT_ONLY 0, __MULTIPLE_RCPTS_CC_X2 0, __PHISH_SPEAR_STRUCTURE_1 0, __SANE_MSGID 0, __TO_MALFORMED_2 0, __TO_NO_NAME 0, __URI_NO_WWW 0, __URI_NS ' From: Santosh Nayak There is a missing "up_write()" here. Semaphore should be released before returning error value. Signed-off-by: Santosh Nayak --- Destination tree "linux-next" drivers/media/dvb/dvb-core/dvbdev.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/drivers/media/dvb/dvb-core/dvbdev.c b/drivers/media/dvb/dvb-core/dvbdev.c index 00a6732..39eab73 100644 --- a/drivers/media/dvb/dvb-core/dvbdev.c +++ b/drivers/media/dvb/dvb-core/dvbdev.c @@ -243,6 +243,7 @@ int dvb_register_device(struct dvb_adapter *adap, struct dvb_device **pdvbdev, if (minor == MAX_DVB_MINORS) { kfree(dvbdevfops); kfree(dvbdev); + up_write(&minor_rwsem); mutex_unlock(&dvbdev_register_lock); return -EINVAL; }