From patchwork Mon May 21 16:06:03 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Michael Krufky X-Patchwork-Id: 11362 Received: from mail.tu-berlin.de ([130.149.7.33]) by www.linuxtv.org with esmtp (Exim 4.72) (envelope-from ) id 1SWV7g-0000ET-Eb for patchwork@linuxtv.org; Mon, 21 May 2012 18:06:16 +0200 X-tubIT-Incoming-IP: 209.132.180.67 Received: from vger.kernel.org ([209.132.180.67]) by mail.tu-berlin.de (exim-4.75/mailfrontend-3) with esmtp for id 1SWV7f-0000rv-G0; Mon, 21 May 2012 18:06:16 +0200 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753162Ab2EUQGN (ORCPT ); Mon, 21 May 2012 12:06:13 -0400 Received: from mail-qa0-f49.google.com ([209.85.216.49]:61496 "EHLO mail-qa0-f49.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754862Ab2EUQGM (ORCPT ); Mon, 21 May 2012 12:06:12 -0400 Received: by qabj40 with SMTP id j40so2671429qab.1 for ; Mon, 21 May 2012 09:06:12 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20120113; h=from:to:cc:subject:date:message-id:x-mailer:x-gm-message-state; bh=2uZKS6FY1X5gDuNGv2BImz8GgLt2jy2VEm6EWxpqOh4=; b=CTSmcS76iIjn00USqwLTsKPnyvUjDiZuzlDRFlubHZCEY0zl5t+8I4e50ujrE0+Aam rq5MWew5bBgepCWXtpuDXCHzOARBz9TdT6htIDLGtMbqfffrBrEKly8hfGvb/RMecB5+ AiLJF6Dmxlx2cpdy6KDo0VjslwpRehkYaWJARihNP7hEryXPZLvyitLQ5KIiaug0GsxK u1u4Llg9c5GkP4DjpNyZ4Llz3Gv8u9y0S15KLs1/wzsVIjNEpOSWL+ix0LM7H3tv8YKW 8O00ms5Bn0NKuyM0ozAXfa6ykKYOfC2PcXqA2tj+8ajWRLm6JfSd/oa6rA+vcttYT5uw v+GQ== Received: by 10.224.194.1 with SMTP id dw1mr39003433qab.87.1337616371850; Mon, 21 May 2012 09:06:11 -0700 (PDT) Received: from outlands.localdomain6 (cpe-67-247-37-142.nyc.res.rr.com. [67.247.37.142]) by mx.google.com with ESMTPS id dx8sm6307955qab.8.2012.05.21.09.06.09 (version=TLSv1/SSLv3 cipher=OTHER); Mon, 21 May 2012 09:06:10 -0700 (PDT) From: Michael Krufky To: linux-media@vger.kernel.org Cc: Dan Carpenter , Michael Krufky Subject: [PATCH] lg2160: fix off-by-one error in lg216x_write_regs Date: Mon, 21 May 2012 12:06:03 -0400 Message-Id: <1337616363-19495-1-git-send-email-mkrufky@linuxtv.org> X-Mailer: git-send-email 1.7.9.5 X-Gm-Message-State: ALoCoQmNPpkSK3TCMQkdY922/6kO2IxS/cWyr2mPRtUZlGXwWD/7gOi65ZuxEI7g83oJy2mKffa7 Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org X-PMX-Version: 5.6.1.2065439, Antispam-Engine: 2.7.2.376379, Antispam-Data: 2012.5.21.155720 X-PMX-Spam: Gauge=IIIIIIII, Probability=8%, Report=' MULTIPLE_RCPTS 0.1, HTML_00_01 0.05, HTML_00_10 0.05, BODYTEXTP_SIZE_3000_LESS 0, BODY_SIZE_1000_1099 0, BODY_SIZE_2000_LESS 0, BODY_SIZE_5000_LESS 0, BODY_SIZE_7000_LESS 0, DATE_TZ_NA 0, URI_ENDS_IN_HTML 0, __ANY_URI 0, __CP_URI_IN_BODY 0, __HAS_MSGID 0, __HAS_X_MAILER 0, __HAS_X_MAILING_LIST 0, __MIME_TEXT_ONLY 0, __MULTIPLE_RCPTS_CC_X2 0, __SANE_MSGID 0, __TO_MALFORMED_2 0, __TO_NO_NAME 0, __URI_NO_WWW 0, __URI_NS ' Fix an off-by-one error in lg216x_write_regs, causing the last element of the lg216x init block to be ignored. Spotted by Dan Carpenter. Reported-by: Dan Carpenter Signed-off-by: Michael Krufky --- drivers/media/dvb/frontends/lg2160.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/media/dvb/frontends/lg2160.c b/drivers/media/dvb/frontends/lg2160.c index a3ab1a5..cc11260 100644 --- a/drivers/media/dvb/frontends/lg2160.c +++ b/drivers/media/dvb/frontends/lg2160.c @@ -126,7 +126,7 @@ static int lg216x_write_regs(struct lg216x_state *state, lg_reg("writing %d registers...\n", len); - for (i = 0; i < len - 1; i++) { + for (i = 0; i < len; i++) { ret = lg216x_write_reg(state, regs[i].reg, regs[i].val); if (lg_fail(ret)) return ret;