From patchwork Thu Mar 15 17:33:48 2012 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Gianluca Gennari X-Patchwork-Id: 10364 Received: from mail.tu-berlin.de ([130.149.7.33]) by www.linuxtv.org with esmtp (Exim 4.72) (envelope-from ) id 1S8EZ6-0006vO-TO for patchwork@linuxtv.org; Thu, 15 Mar 2012 18:34:16 +0100 X-tubIT-Incoming-IP: 209.132.180.67 Received: from vger.kernel.org ([209.132.180.67]) by mail.tu-berlin.de (exim-4.75/mailfrontend-3) with esmtp for id 1S8EZ6-0003nV-E7; Thu, 15 Mar 2012 18:34:16 +0100 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1756304Ab2COReN (ORCPT ); Thu, 15 Mar 2012 13:34:13 -0400 Received: from mail-ee0-f46.google.com ([74.125.83.46]:64602 "EHLO mail-ee0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754847Ab2COReM (ORCPT ); Thu, 15 Mar 2012 13:34:12 -0400 Received: by eekc41 with SMTP id c41so1790106eek.19 for ; Thu, 15 Mar 2012 10:34:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=from:to:cc:subject:date:message-id:x-mailer:in-reply-to:references; bh=MJE+rj6ntEAt+2OXA7jTwncUNs6ZxvUIuYEZWPL5UpU=; b=tDieCxTerttvxJpCgPwsoTJd1zJp/ivvliNRDBH5qHlPt6CBGvTYnZ+dybPudJTlrj vJ9STqahUkcsBmQI2Y6wKhycv1FibO++I7caxHLEDhAY8kfhd3M6Qr47gHwhIpUysB1V b4gYT/4/D5aZiS8srZwm98Qv4rmvkR58TtCEzlkbQwUjC/jzjaSPLVB5uSF5TJRkZ6bA BbwHQhnQWgb0ojFXdDriquBpQqTxL8cptcWYCXt4KnGJQg8zhrrtbtjx8PBIdO92oK3x HalgPIOFmwygOa0lWoq4ywc4UtSvOxBCoLj3PECVMyovDbjaf6gTAB6PcB4ONxp2Uh96 ZA5w== Received: by 10.213.15.143 with SMTP id k15mr564642eba.251.1331832851164; Thu, 15 Mar 2012 10:34:11 -0700 (PDT) Received: from localhost.localdomain (93-50-34-119.ip150.fastwebnet.it. [93.50.34.119]) by mx.google.com with ESMTPS id r44sm9250156eef.2.2012.03.15.10.34.09 (version=TLSv1/SSLv3 cipher=OTHER); Thu, 15 Mar 2012 10:34:10 -0700 (PDT) From: Gianluca Gennari To: linux-media@vger.kernel.org, mchehab@redhat.com Cc: crope@iki.fi, Gianluca Gennari Subject: [PATCH 2/3] em28xx-dvb: enable LNA for cxd2820r in DVB-T mode Date: Thu, 15 Mar 2012 18:33:48 +0100 Message-Id: <1331832829-4580-3-git-send-email-gennarone@gmail.com> X-Mailer: git-send-email 1.7.0.4 In-Reply-To: <1331832829-4580-1-git-send-email-gennarone@gmail.com> References: <1331832829-4580-1-git-send-email-gennarone@gmail.com> Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org X-PMX-Version: 5.6.1.2065439, Antispam-Engine: 2.7.2.376379, Antispam-Data: 2012.3.15.172421 X-PMX-Spam: Gauge=XI, Probability=11%, Report=' HASHBUSTER_BLOCK_V2 0.5, FORGED_FROM_GMAIL 0.1, MULTIPLE_RCPTS 0.1, HTML_00_01 0.05, HTML_00_10 0.05, BODYTEXTP_SIZE_3000_LESS 0, BODY_SIZE_1800_1899 0, BODY_SIZE_2000_LESS 0, BODY_SIZE_5000_LESS 0, BODY_SIZE_7000_LESS 0, __ANY_URI 0, __CP_MEDIA_BODY 0, __CP_URI_IN_BODY 0, __FRAUD_BODY_WEBMAIL 0, __FRAUD_WEBMAIL 0, __FRAUD_WEBMAIL_FROM 0, __FROM_GMAIL 0, __HASHBUSTER_BLOCK_V2_1 0, __HAS_MSGID 0, __HAS_X_MAILER 0, __HAS_X_MAILING_LIST 0, __INT_PROD_TV 0, __LINES_OF_YELLING 0, __MIME_TEXT_ONLY 0, __MULTIPLE_RCPTS_CC_X2 0, __PHISH_SPEAR_STRUCTURE_1 0, __SANE_MSGID 0, __STOCK_PHRASE_7 0, __SUBJ_ALPHA_END 0, __TO_MALFORMED_2 0, __TO_NO_NAME 0, __URI_NO_WWW 0, __URI_NS ' Enable the LNA amplifier also for DVB-T (like for DVB-T2 and DVB-C); this greatly improves reception of weak signals without affecting the reception of the strong ones. Experimental data (collected with the mipsel STB) on the weakest frequencies available in my area: LNA OFF: MUX level BER picture RAI mux 4 72% 32000 corrupted TIMB 2 75% 14 OK TVA Vicenza 68% 32000 corrupted RAI mux 2 78% 14 OK LNA ON: MUX level BER picture RAI mux 4 73% 1500 OK TIMB 2 76% 0 OK TVA Vicenza 69% 0 OK RAI mux 2 79% 0 OK Moreover, with LNA enabled, the PCTV 290e was able to pick up 2 new frequencies matching the integrated tuner of my Panasonic G20 TV, which is really good. Signed-off-by: Gianluca Gennari --- drivers/media/video/em28xx/em28xx-dvb.c | 3 ++- 1 files changed, 2 insertions(+), 1 deletions(-) diff --git a/drivers/media/video/em28xx/em28xx-dvb.c b/drivers/media/video/em28xx/em28xx-dvb.c index fbd9010..4917b71 100644 --- a/drivers/media/video/em28xx/em28xx-dvb.c +++ b/drivers/media/video/em28xx/em28xx-dvb.c @@ -502,7 +502,8 @@ static struct cxd2820r_config em28xx_cxd2820r_config = { .i2c_address = (0xd8 >> 1), .ts_mode = CXD2820R_TS_SERIAL, - /* enable LNA for DVB-T2 and DVB-C */ + /* enable LNA for DVB-T, DVB-T2 and DVB-C */ + .gpio_dvbt[0] = CXD2820R_GPIO_E | CXD2820R_GPIO_O | CXD2820R_GPIO_L, .gpio_dvbt2[0] = CXD2820R_GPIO_E | CXD2820R_GPIO_O | CXD2820R_GPIO_L, .gpio_dvbc[0] = CXD2820R_GPIO_E | CXD2820R_GPIO_O | CXD2820R_GPIO_L, };