diff mbox

[media] dvb: negative value assigned to unsigned int in CDRXD().

Message ID 1331091663-4790-1-git-send-email-santoshprasadnayak@gmail.com (mailing list archive)
State Accepted, archived
Headers

Commit Message

santosh nayak March 7, 2012, 3:41 a.m. UTC 
  From: Santosh Nayak <santoshprasadnayak@gmail.com>

In CDRXD(), Negative number is assigned to unsigned variable
'state->noise_cal.tdCal2.

Members of 'SNoiseCal' should be 'signed short'.

Signed-off-by: Santosh Nayak <santoshprasadnayak@gmail.com>
---
 drivers/media/dvb/frontends/drxd_hard.c |    6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)

Comments

Dan Carpenter March 7, 2012, 6:12 a.m. UTC | #1 
On Wed, Mar 07, 2012 at 09:11:03AM +0530, santosh nayak wrote:
> From: Santosh Nayak <santoshprasadnayak@gmail.com>
> 
> In CDRXD(), Negative number is assigned to unsigned variable
> 'state->noise_cal.tdCal2.
> 
> Members of 'SNoiseCal' should be 'signed short'.
> 

In your changelogs could you please write something about how this
change will affect what the user sees.  That way users know if it
fixes something they care about and they will apply your patch.

regards,
dan carpenter
diff mbox

Patch

diff --git a/drivers/media/dvb/frontends/drxd_hard.c b/drivers/media/dvb/frontends/drxd_hard.c
index 7bf39cd..f380eb4 100644
--- a/drivers/media/dvb/frontends/drxd_hard.c
+++ b/drivers/media/dvb/frontends/drxd_hard.c
@@ -101,9 +101,9 @@  struct SCfgAgc {
 
 struct SNoiseCal {
 	int cpOpt;
-	u16 cpNexpOfs;
-	u16 tdCal2k;
-	u16 tdCal8k;
+	short cpNexpOfs;
+	short tdCal2k;
+	short tdCal8k;
 };
 
 enum app_env {