From patchwork Fri Nov 4 17:23:21 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Javier Martinez Canillas X-Patchwork-Id: 8313 Received: from mail.tu-berlin.de ([130.149.7.33]) by www.linuxtv.org with esmtp (Exim 4.72) (envelope-from ) id 1RMNUX-0004mn-5W; Fri, 04 Nov 2011 18:23:47 +0100 X-tubIT-Incoming-IP: 209.132.180.67 Received: from vger.kernel.org ([209.132.180.67]) by mail.tu-berlin.de (exim-4.75/mailfrontend-1) with esmtp id 1RMNUW-0000RH-Kx; Fri, 04 Nov 2011 18:23:44 +0100 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932955Ab1KDRXl (ORCPT + 3 others); Fri, 4 Nov 2011 13:23:41 -0400 Received: from mail-ww0-f44.google.com ([74.125.82.44]:59078 "EHLO mail-ww0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932832Ab1KDRXl (ORCPT ); Fri, 4 Nov 2011 13:23:41 -0400 Received: by wwi36 with SMTP id 36so3804045wwi.1 for ; Fri, 04 Nov 2011 10:23:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=from:to:cc:subject:date:message-id:x-mailer; bh=09l5z+2F9UUuudscAihb8HRfbGWk1hCo/AdsbD1KB5Q=; b=WF+K9vDy+606zu2ejIE7oHftJicp3dtpTS/4RshZbK2z3XhBfqBY91IdMluFS3bexE IJVEosOPw83KLkdaw4AECYHHLcDYRTMyvef311l6KR+d1xNsniAHDXXU+HYN/HTR9CdN h0V9XGVulprDFENKhNNPVMKbUC+ia3MJVIZmY= Received: by 10.216.210.38 with SMTP id t38mr4998386weo.48.1320427419818; Fri, 04 Nov 2011 10:23:39 -0700 (PDT) Received: from localhost.localdomain ([95.214.56.18]) by mx.google.com with ESMTPS id q30sm17028738wbn.17.2011.11.04.10.23.36 (version=TLSv1/SSLv3 cipher=OTHER); Fri, 04 Nov 2011 10:23:38 -0700 (PDT) From: Javier Martinez Canillas To: Mauro Carvalho Chehab Cc: Hans Verkuil , linux-media@vger.kernel.org, Javier Martinez Canillas Subject: [PATCH 1/1] [media] tvp5150: Delete video standard magic numbers Date: Fri, 4 Nov 2011 18:23:21 +0100 Message-Id: <1320427401-5444-1-git-send-email-martinez.javier@gmail.com> X-Mailer: git-send-email 1.7.4.1 Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org X-PMX-Version: 5.6.1.2065439, Antispam-Engine: 2.7.2.376379, Antispam-Data: 2011.11.4.171222 X-PMX-Spam: Gauge=IIIIIIII, Probability=8%, Report=' FORGED_FROM_GMAIL 0.1, MULTIPLE_RCPTS 0.1, BODYTEXTP_SIZE_3000_LESS 0, BODY_SIZE_1600_1699 0, BODY_SIZE_2000_LESS 0, BODY_SIZE_5000_LESS 0, BODY_SIZE_7000_LESS 0, FROM_NAME_PHRASE 0, __ANY_URI 0, __CP_MEDIA_BODY 0, __CP_URI_IN_BODY 0, __FRAUD_BODY_WEBMAIL 0, __FRAUD_WEBMAIL 0, __FRAUD_WEBMAIL_FROM 0, __FROM_GMAIL 0, __HAS_MSGID 0, __HAS_X_MAILER 0, __HAS_X_MAILING_LIST 0, __MIME_TEXT_ONLY 0, __MULTIPLE_RCPTS_CC_X2 0, __PHISH_SPEAR_STRUCTURE_1 0, __SANE_MSGID 0, __SUBJ_ALPHA_END 0, __TO_MALFORMED_2 0, __URI_NO_WWW 0, __URI_NS ' X-LSpam-Score: -4.2 (----) X-LSpam-Report: No, score=-4.2 required=5.0 tests=BAYES_00=-1.9, FREEMAIL_FROM=0.001, RCVD_IN_DNSWL_MED=-2.3, T_DKIM_INVALID=0.01 autolearn=ham Commit: 64933337e3cb61ca555969a35ab68b477db34ee2 [media] tvp5150: Add video format registers configuration values Added constants for each video standard supported by TVP5150, so this patch get rid of the magic numbers. Signed-off-by: Javier Martinez Canillas --- drivers/media/video/tvp5150.c | 14 +++++++------- 1 files changed, 7 insertions(+), 7 deletions(-) diff --git a/drivers/media/video/tvp5150.c b/drivers/media/video/tvp5150.c index e927d25..2a10b03 100644 --- a/drivers/media/video/tvp5150.c +++ b/drivers/media/video/tvp5150.c @@ -702,21 +702,21 @@ static int tvp5150_set_std(struct v4l2_subdev *sd, v4l2_std_id std) /* First tests should be against specific std */ if (std == V4L2_STD_ALL) { - fmt = 0; /* Autodetect mode */ + fmt = VIDEO_STD_AUTO_SWITCH_BIT; /* Autodetect mode */ } else if (std & V4L2_STD_NTSC_443) { - fmt = 0xa; + fmt = VIDEO_STD_NTSC_4_43_BIT; } else if (std & V4L2_STD_PAL_M) { - fmt = 0x6; + fmt = VIDEO_STD_PAL_M_BIT; } else if (std & (V4L2_STD_PAL_N | V4L2_STD_PAL_Nc)) { - fmt = 0x8; + fmt = VIDEO_STD_PAL_COMBINATION_N_BIT; } else { /* Then, test against generic ones */ if (std & V4L2_STD_NTSC) - fmt = 0x2; + fmt = VIDEO_STD_NTSC_MJ_BIT; else if (std & V4L2_STD_PAL) - fmt = 0x4; + fmt = VIDEO_STD_PAL_BDGHIN_BIT; else if (std & V4L2_STD_SECAM) - fmt = 0xc; + fmt = VIDEO_STD_SECAM_BIT; } v4l2_dbg(1, debug, sd, "Set video std register to %d.\n", fmt);