From patchwork Sun Aug 14 00:39:34 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Chris Rankin X-Patchwork-Id: 7102 Return-path: Envelope-to: mchehab@infradead.org Delivery-date: Sun, 14 Aug 2011 00:39:53 +0000 Received: from casper.infradead.org [85.118.1.10] by localhost.localdomain with IMAP (fetchmail-6.3.17) for (single-drop); Sat, 13 Aug 2011 21:49:33 -0300 (BRT) Received: from vger.kernel.org ([209.132.180.67]) by casper.infradead.org with esmtp (Exim 4.76 #1 (Red Hat Linux)) id 1QsOk5-00031L-4I; Sun, 14 Aug 2011 00:39:53 +0000 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752679Ab1HNAjg (ORCPT + 1 other); Sat, 13 Aug 2011 20:39:36 -0400 Received: from nm3-vm4.bullet.mail.ne1.yahoo.com ([98.138.91.163]:29788 "HELO nm3-vm4.bullet.mail.ne1.yahoo.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with SMTP id S1752623Ab1HNAjf convert rfc822-to-8bit (ORCPT ); Sat, 13 Aug 2011 20:39:35 -0400 Received: from [98.138.90.56] by nm3.bullet.mail.ne1.yahoo.com with NNFMP; 14 Aug 2011 00:39:34 -0000 Received: from [98.138.89.171] by tm9.bullet.mail.ne1.yahoo.com with NNFMP; 14 Aug 2011 00:39:34 -0000 Received: from [127.0.0.1] by omp1027.mail.ne1.yahoo.com with NNFMP; 14 Aug 2011 00:39:34 -0000 X-Yahoo-Newman-Property: ymail-3 X-Yahoo-Newman-Id: 803738.3240.bm@omp1027.mail.ne1.yahoo.com Received: (qmail 800 invoked by uid 60001); 14 Aug 2011 00:39:34 -0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s1024; t=1313282374; bh=t3wvNEqDHS/raPSodEj0xmHqx79EVNMeaWozee3CJ9g=; h=X-YMail-OSG:Received:X-Mailer:Message-ID:Date:From:Subject:To:Cc:In-Reply-To:MIME-Version:Content-Type:Content-Transfer-Encoding; b=y9YxTo57QYZZA4cNX+SdSRNmhh5Y+YE/7tqK6RPzUxnBrPmvwkv+0yi4mv+ksHvfVjLxT/IFzYxbPlIYsmCdjo+5jPq9WP9o9C4Wy5Qo31rEMJRIDROr8VDmU2Ojasgmw4TiXU93eLT5ui/mxO/oTa67KYy9Y8LBXCmz30m2mPE= DomainKey-Signature: a=rsa-sha1; q=dns; c=nofws; s=s1024; d=yahoo.com; h=X-YMail-OSG:Received:X-Mailer:Message-ID:Date:From:Subject:To:Cc:In-Reply-To:MIME-Version:Content-Type:Content-Transfer-Encoding; b=mpUqXml7sOHiWgJwqbK8BJCK/QS9KCupTnU0cIaHNUgNRhlqtPPquECJvjZldRkZWtWW7agksVfu6bfyw8saqGlqrnOgIINxBlCYcqRUHltZuQCAAUJIkUqTTBFIGMx/NwRRI48hJEdcMJDcXYzs3Bu+3NdaXnsOzslNk+RQcyg=; X-YMail-OSG: RtH4VboVM1ljmSTcA3EjFNhE_fuRfam_55kmUV5PgCR.Emb gyZ.qlarGxsNChtiYMlZv5RC4VZfv4FiqyT.Wy0wo0R5CDEPCGdF8OvIS.ps e3ww3WY8TZElIc6ghZ5DqlA8tt7p9BzrciSlnB.XmfpFU7LoseCbd2iPKn.g cqr1_CCeonKtokX6w4WAOoDLMK0DwuZ8715EqWPnlsMdIxfLMhk5jZ1nJCB_ NFDBQqSjWX2ylOqd1MrjfH1bqJltwlLcbJlw_7mT0TsiYixALrgojmk9CVWH hN9FZbLnnYFbfuD871h.6dDj9iOZ5GC3JEcNCXnfoztDroAaw2Xw97uDViZo qb3rDcBMmcV6urTaDjnlSDdN1mLyp885UCRks8CyBCJCaZ8KjqS.qxaHEpa3 bYTDYY6Exxpdx8QFyu7De_oQQkW47RjiFpZuf7onunE6eS4ZpOw1genSZrLD V9Q-- Received: from [86.178.152.254] by web121715.mail.ne1.yahoo.com via HTTP; Sat, 13 Aug 2011 17:39:34 PDT X-Mailer: YahooMailClassic/14.0.4 YahooMailWebService/0.8.113.313619 Message-ID: <1313282374.97725.YahooMailClassic@web121715.mail.ne1.yahoo.com> Date: Sat, 13 Aug 2011 17:39:34 -0700 (PDT) From: Chris Rankin Subject: Re: PCTV 290e nanostick and remote control support To: Antti Palosaari Cc: linux-media@vger.kernel.org In-Reply-To: <4E46FB3C.7060402@iki.fi> MIME-Version: 1.0 Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org --- On Sat, 13/8/11, Antti Palosaari wrote: > Remote is already supported, but from the 3.1 or maybe 3.2 > (I am not sure if Mauro was hurry to sent it 3.1). Hi, This appears to be the diff from 3.1 that adds RC support: It certainly creates a new /dev/input/event? node, and allows me to program all but *one* button on the handset: the "OK" button. At this early stage, it would seem unlikely that this particular button is faulty. Could there be an error in the IR code configuration, please? Or maybe someone else *does* have a PCTV 290e device where the OK button works? Thanks, Chris --- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html --- linux-3.0/drivers/media/video/em28xx/em28xx-cards.c.orig 2011-08-13 20:37:26.000000000 +0100 +++ linux-3.0/drivers/media/video/em28xx/em28xx-cards.c 2011-08-14 00:34:59.000000000 +0100 @@ -1773,13 +1773,13 @@ /* 2013:024f PCTV Systems nanoStick T2 290e. * Empia EM28174, Sony CXD2820R and NXP TDA18271HD/C2 */ [EM28174_BOARD_PCTV_290E] = { + .name = "PCTV nanoStick T2 290e", .i2c_speed = EM2874_I2C_SECONDARY_BUS_SELECT | EM28XX_I2C_CLK_WAIT_ENABLE | EM28XX_I2C_FREQ_100_KHZ, - .xclk = EM28XX_XCLK_FREQUENCY_12MHZ, - .name = "PCTV Systems nanoStick T2 290e", .tuner_type = TUNER_ABSENT, .tuner_gpio = pctv_290e, .has_dvb = 1, + .ir_codes = RC_MAP_PINNACLE_PCTV_HD, }, }; const unsigned int em28xx_bcount = ARRAY_SIZE(em28xx_boards); --- linux-3.0/drivers/media/video/em28xx/em28xx-input.c.orig 2011-08-14 00:30:57.000000000 +0100 +++ linux-3.0/drivers/media/video/em28xx/em28xx-input.c 2011-08-14 00:31:20.000000000 +0100 @@ -372,6 +372,7 @@ ir->get_key = default_polling_getkey; break; case CHIP_ID_EM2874: + case CHIP_ID_EM28174: ir->get_key = em2874_polling_getkey; em28xx_write_regs(dev, EM2874_R50_IR_CONFIG, &ir_config, 1); break;