From patchwork Wed Aug 25 08:48:49 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Joonyoung Shim X-Patchwork-Id: 4155 Return-path: Envelope-to: mchehab@pedra Delivery-date: Wed, 25 Aug 2010 09:43:48 -0300 Received: from mchehab by pedra with local (Exim 4.72) (envelope-from ) id 1OoFKV-0005jC-Nv for mchehab@pedra; Wed, 25 Aug 2010 09:43:47 -0300 Received: from bombadil.infradead.org [18.85.46.34] by pedra with IMAP (fetchmail-6.3.17) for (single-drop); Wed, 25 Aug 2010 09:43:47 -0300 (BRT) Received: from vger.kernel.org ([209.132.180.67]) by bombadil.infradead.org with esmtp (Exim 4.72 #1 (Red Hat Linux)) id 1OoBew-0006kv-Uo; Wed, 25 Aug 2010 08:48:39 +0000 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752663Ab0HYIsg (ORCPT + 1 other); Wed, 25 Aug 2010 04:48:36 -0400 Received: from mailout1.samsung.com ([203.254.224.24]:10272 "EHLO mailout1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752618Ab0HYIsf (ORCPT ); Wed, 25 Aug 2010 04:48:35 -0400 Received: from epmmp2 (mailout1.samsung.com [203.254.224.24]) by mailout1.samsung.com (Sun Java(tm) System Messaging Server 7u3-15.01 64bit (built Feb 12 2010)) with ESMTP id <0L7P00C3P9SQSLD0@mailout1.samsung.com> for linux-media@vger.kernel.org; Wed, 25 Aug 2010 17:48:26 +0900 (KST) Received: from TNRNDGASPAPP1.tn.corp.samsungelectronics.net ([165.213.149.150]) by mmp2.samsung.com (iPlanet Messaging Server 5.2 Patch 2 (built Jul 14 2004)) with ESMTPA id <0L7P00KYW9SQMG@mmp2.samsung.com> for linux-media@vger.kernel.org; Wed, 25 Aug 2010 17:48:26 +0900 (KST) Received: from localhost.localdomain ([10.89.10.212]) by TNRNDGASPAPP1.tn.corp.samsungelectronics.net with Microsoft SMTPSVC(6.0.3790.4675); Wed, 25 Aug 2010 17:48:26 +0900 Date: Wed, 25 Aug 2010 17:48:49 +0900 From: Joonyoung Shim Subject: [PATCH 3/3] radio-si470x: Fix error handling of si470x i2c driver In-reply-to: <1282726129-28408-1-git-send-email-jy0922.shim@samsung.com> To: linux-media@vger.kernel.org Cc: mchehab@infradead.org, tobias.lorenz@gmx.net, kyungmin.park@samsung.com Message-id: <1282726129-28408-3-git-send-email-jy0922.shim@samsung.com> X-Mailer: git-send-email 1.7.0.4 Content-transfer-encoding: 7BIT References: <1282726129-28408-1-git-send-email-jy0922.shim@samsung.com> X-OriginalArrivalTime: 25 Aug 2010 08:48:26.0086 (UTC) FILETIME=[4837C860:01CB4432] Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org Sender: Mauro Carvalho Chehab We should go to err_video instead of err_all if this error is occured when probed. Signed-off-by: Joonyoung Shim --- drivers/media/radio/si470x/radio-si470x-i2c.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/drivers/media/radio/si470x/radio-si470x-i2c.c b/drivers/media/radio/si470x/radio-si470x-i2c.c index 67a4ec8..4ce541a 100644 --- a/drivers/media/radio/si470x/radio-si470x-i2c.c +++ b/drivers/media/radio/si470x/radio-si470x-i2c.c @@ -395,7 +395,7 @@ static int __devinit si470x_i2c_probe(struct i2c_client *client, radio->registers[POWERCFG] = POWERCFG_ENABLE; if (si470x_set_register(radio, POWERCFG) < 0) { retval = -EIO; - goto err_all; + goto err_video; } msleep(110);