From patchwork Mon Mar 15 08:44:08 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Huang Shijie X-Patchwork-Id: 2936 Return-path: Envelope-to: mchehab@infradead.org Delivery-date: Mon, 15 Mar 2010 08:42:07 +0000 Received: from bombadil.infradead.org [18.85.46.34] by pedra with IMAP (fetchmail-6.3.6) for (single-drop); Mon, 15 Mar 2010 07:44:34 -0300 (BRT) Received: from vger.kernel.org ([209.132.180.67]) by bombadil.infradead.org with esmtp (Exim 4.69 #1 (Red Hat Linux)) id 1Nr5sF-0006VP-Hf; Mon, 15 Mar 2010 08:42:07 +0000 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S935755Ab0COImF (ORCPT + 1 other); Mon, 15 Mar 2010 04:42:05 -0400 Received: from mail-pv0-f174.google.com ([74.125.83.174]:53844 "EHLO mail-pv0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S935693Ab0COImE (ORCPT ); Mon, 15 Mar 2010 04:42:04 -0400 Received: by pvg7 with SMTP id 7so823614pvg.19 for ; Mon, 15 Mar 2010 01:42:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:from:to:cc:subject:date :message-id:x-mailer; bh=0TJm3RKEVw0ZXIdbbY/9GRsxHtDm6E7xirXAodgiF6k=; b=Mz3Sp/aID0diGIVM3mqN4IZOvFGzeEA4hOPs4pU6fhhsSbHFMa04anybISgttIXPgU FrhITVQcMoZXig73nLnA0vGOY4k2SJFpFrQziB5wF6z/pRI9dOBx3yMy6fmemwsrpOXM FKk30D3gWVbdmr1MjlUHXVWChiohJ8Y/W1mEw= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=from:to:cc:subject:date:message-id:x-mailer; b=Uzr1EhLl4IenOwuS5ELOnuMs7PkKoM0Jt1W1C5/CBnI/FZsmmtreyU58pEVaCl6l/O c4Js7Ag+rlfNL2uO1IUKtX0sxJRmVf1ExgLdad8QKIQpM64X9XGOean7WBZJobo2+QG0 ifmE3KQf+pLOqBuxIBYgmiEQeynO0cWTvBhi0= Received: by 10.143.20.35 with SMTP id x35mr3161515wfi.116.1268642521514; Mon, 15 Mar 2010 01:42:01 -0700 (PDT) Received: from localhost.localdomain ([211.144.218.162]) by mx.google.com with ESMTPS id 23sm5474187pzk.10.2010.03.15.01.42.00 (version=SSLv3 cipher=RC4-MD5); Mon, 15 Mar 2010 01:42:01 -0700 (PDT) From: Huang Shijie To: mchehab@redhat.com, linux-media@vger.kernel.org Cc: Huang Shijie Subject: [BUGFIX][PATCH] change some parameters for tlg2300 Date: Mon, 15 Mar 2010 16:44:08 +0800 Message-Id: <1268642648-3132-1-git-send-email-shijie8@gmail.com> X-Mailer: git-send-email 1.6.6 Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org The orgin parameters may cause a bug : The audio may lost in certain situation (such as open the VLC at the first time). The origin parameters set a small stop_threshold for snd_pcm_runtime{}. So a xrun occurs in some situation. Signed-off-by: Huang Shijie --- drivers/media/video/tlg2300/pd-alsa.c | 10 ---------- 1 files changed, 0 insertions(+), 10 deletions(-) diff --git a/drivers/media/video/tlg2300/pd-alsa.c b/drivers/media/video/tlg2300/pd-alsa.c index 6f42621..e9ad715 100644 --- a/drivers/media/video/tlg2300/pd-alsa.c +++ b/drivers/media/video/tlg2300/pd-alsa.c @@ -21,9 +21,6 @@ static void complete_handler_audio(struct urb *urb); #define AUDIO_EP (0x83) #define AUDIO_BUF_SIZE (512) -#define PERIOD_SIZE (1024 * 8) -#define PERIOD_MIN (4) -#define PERIOD_MAX PERIOD_MIN static struct snd_pcm_hardware snd_pd_hw_capture = { .info = SNDRV_PCM_INFO_BLOCK_TRANSFER | @@ -38,18 +35,11 @@ static struct snd_pcm_hardware snd_pd_hw_capture = { .rate_max = 48000, .channels_min = 2, .channels_max = 2, - .buffer_bytes_max = PERIOD_SIZE * PERIOD_MIN, - .period_bytes_min = PERIOD_SIZE, - .period_bytes_max = PERIOD_SIZE, - .periods_min = PERIOD_MIN, - .periods_max = PERIOD_MAX, - /* .buffer_bytes_max = 62720 * 8, .period_bytes_min = 64, .period_bytes_max = 12544, .periods_min = 2, .periods_max = 98 - */ }; static int snd_pd_capture_open(struct snd_pcm_substream *substream)