From patchwork Wed Jan 6 22:04:07 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jiri Slaby X-Patchwork-Id: 2417 Return-path: Envelope-to: mchehab@infradead.org Delivery-date: Wed, 06 Jan 2010 22:05:01 +0000 Received: from bombadil.infradead.org [18.85.46.34] by pedra with IMAP (fetchmail-6.3.6) for (single-drop); Sat, 09 Jan 2010 17:01:33 -0200 (BRST) Received: from vger.kernel.org ([209.132.180.67]) by bombadil.infradead.org with esmtp (Exim 4.69 #1 (Red Hat Linux)) id 1NSdzw-0004vW-IM; Wed, 06 Jan 2010 22:05:01 +0000 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932946Ab0AFWER (ORCPT + 1 other); Wed, 6 Jan 2010 17:04:17 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S932934Ab0AFWEO (ORCPT ); Wed, 6 Jan 2010 17:04:14 -0500 Received: from smtp.mujha-vel.cz ([81.30.225.246]:50038 "EHLO smtp.mujha-vel.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932746Ab0AFWEN (ORCPT ); Wed, 6 Jan 2010 17:04:13 -0500 Received: from [217.66.174.142] (helo=localhost.localdomain) by smtp.mujha-vel.cz with esmtp (Exim 4.63) (envelope-from ) id 1NSdz8-0003f5-J2; Wed, 06 Jan 2010 23:04:10 +0100 From: Jiri Slaby To: mchehab@infradead.org Cc: linux-kernel@vger.kernel.org, jirislaby@gmail.com, "Igor M. Liplianin" , Mauro Carvalho Chehab , linux-media@vger.kernel.org Subject: [PATCH 1/1] media: dvb/zl10039, jump to error on error Date: Wed, 6 Jan 2010 23:04:07 +0100 Message-Id: <1262815447-4555-1-git-send-email-jslaby@suse.cz> X-Mailer: git-send-email 1.6.5.7 Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org Stanse found an unreachable statement in zl10039_attach. There is a `break' followed by `goto error'. Remove that break, so that it can handle the error. Signed-off-by: Jiri Slaby Cc: Igor M. Liplianin Cc: Mauro Carvalho Chehab Cc: linux-media@vger.kernel.org --- drivers/media/dvb/frontends/zl10039.c | 1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/drivers/media/dvb/frontends/zl10039.c b/drivers/media/dvb/frontends/zl10039.c index 11b29cb..c085e58 100644 --- a/drivers/media/dvb/frontends/zl10039.c +++ b/drivers/media/dvb/frontends/zl10039.c @@ -287,7 +287,6 @@ struct dvb_frontend *zl10039_attach(struct dvb_frontend *fe, break; default: dprintk("Chip ID=%x does not match a known type\n", state->id); - break; goto error; }