From patchwork Wed Jan 6 16:45:28 2010 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jiri Slaby X-Patchwork-Id: 2415 Return-path: Envelope-to: mchehab@infradead.org Delivery-date: Wed, 06 Jan 2010 17:17:37 +0000 Received: from bombadil.infradead.org [18.85.46.34] by pedra with IMAP (fetchmail-6.3.6) for (single-drop); Sat, 09 Jan 2010 17:01:23 -0200 (BRST) Received: from vger.kernel.org ([209.132.180.67]) by bombadil.infradead.org with esmtp (Exim 4.69 #1 (Red Hat Linux)) id 1NSZVp-0007Wn-Ni; Wed, 06 Jan 2010 17:17:37 +0000 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932166Ab0AFRRg (ORCPT + 1 other); Wed, 6 Jan 2010 12:17:36 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1755837Ab0AFRRg (ORCPT ); Wed, 6 Jan 2010 12:17:36 -0500 Received: from smtp.mujha-vel.cz ([81.30.225.246]:46786 "EHLO smtp.mujha-vel.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755820Ab0AFRRe (ORCPT ); Wed, 6 Jan 2010 12:17:34 -0500 Received: from [217.66.174.142] (helo=localhost.localdomain) by smtp.mujha-vel.cz with esmtp (Exim 4.63) (envelope-from ) id 1NSZ0k-0007iT-E6; Wed, 06 Jan 2010 17:45:30 +0100 From: Jiri Slaby To: mchehab@infradead.org Cc: linux-kernel@vger.kernel.org, jirislaby@gmail.com, linux-media@vger.kernel.org Subject: [PATCH 2/2] media: video/tuner-core, fix memory leak Date: Wed, 6 Jan 2010 17:45:28 +0100 Message-Id: <1262796328-17176-2-git-send-email-jslaby@suse.cz> X-Mailer: git-send-email 1.6.5.7 In-Reply-To: <1262796328-17176-1-git-send-email-jslaby@suse.cz> References: <1262796328-17176-1-git-send-email-jslaby@suse.cz> Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org Stanse found a memory leak in tuner_probe. t is not freed/assigned on all paths. Fix that. Signed-off-by: Jiri Slaby Cc: Mauro Carvalho Chehab Cc: linux-media@vger.kernel.org --- drivers/media/video/tuner-core.c | 1 + 1 files changed, 1 insertions(+), 0 deletions(-) diff --git a/drivers/media/video/tuner-core.c b/drivers/media/video/tuner-core.c index 5b3eaa1..c4dab6c 100644 --- a/drivers/media/video/tuner-core.c +++ b/drivers/media/video/tuner-core.c @@ -1078,6 +1078,7 @@ static int tuner_probe(struct i2c_client *client, goto register_client; } + kfree(t); return -ENODEV; case 0x42: case 0x43: