From patchwork Mon Nov 9 01:44:57 2009 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andy Walls X-Patchwork-Id: 2033 Return-path: Envelope-to: mchehab@infradead.org Delivery-date: Mon, 09 Nov 2009 01:42:54 +0000 Received: from bombadil.infradead.org [18.85.46.34] by pedra.chehab.org with IMAP (fetchmail-6.3.6) for (single-drop); Mon, 09 Nov 2009 08:15:08 -0200 (BRST) Received: from vger.kernel.org ([209.132.176.167]) by bombadil.infradead.org with esmtp (Exim 4.69 #1 (Red Hat Linux)) id 1N7JHS-0005WL-5j; Mon, 09 Nov 2009 01:42:54 +0000 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752081AbZKIBmq (ORCPT + 1 other); Sun, 8 Nov 2009 20:42:46 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751739AbZKIBmq (ORCPT ); Sun, 8 Nov 2009 20:42:46 -0500 Received: from mail1.radix.net ([207.192.128.31]:57599 "EHLO mail1.radix.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751406AbZKIBmp (ORCPT ); Sun, 8 Nov 2009 20:42:45 -0500 Received: from [192.168.1.2] (01-174.155.popsite.net [66.217.131.174]) (authenticated bits=0) by mail1.radix.net (8.13.4/8.13.4) with ESMTP id nA91giGT017101; Sun, 8 Nov 2009 20:42:45 -0500 (EST) Subject: [PATCH] v4l/scripts: Fix make checkpatch operation with in tree checkpatch.pl From: Andy Walls To: Mauro Carvalho Chehab Cc: linux-media@vger.kernel.org Date: Sun, 08 Nov 2009 20:44:57 -0500 Message-Id: <1257731097.6504.4.camel@palomino.walls.org> Mime-Version: 1.0 X-Mailer: Evolution 2.24.5 (2.24.5-2.fc10) Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org Mauro, make checkpatch wasn't working for me. I found that the new version of checkpatch.pl that's in the v4l/dvb tree doesn't emit a version number unless explicitly requested. This patch gets 'make checkpatch' working (and complaining again) for me. Regards, Andy Signed-off-by: Andy Walls --- To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html diff -r d2aaff136907 v4l/scripts/check.pl --- a/v4l/scripts/check.pl Thu Nov 05 19:51:24 2009 -0500 +++ b/v4l/scripts/check.pl Sun Nov 08 20:40:06 2009 -0500 @@ -56,11 +56,13 @@ } close IN; -my $intree_checkpatch = "scripts/checkpatch.pl --no-tree --strict"; +my $intree_checkpatch = "scripts/checkpatch.pl --version "; if (!open IN,"$intree_checkpatch|") { $intree_checkpatch = "v4l/".$intree_checkpatch; open IN,"$intree_checkpatch|"; } +$intree_checkpatch =~ s/--version/--no-tree --strict/; + while () { tr/A-Z/a-z/; if (m/version\s*:\s*([\d\.]+)/) {