From patchwork Mon Aug 10 09:46:09 2009 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Eduardo Valentin X-Patchwork-Id: 1478 Return-path: Envelope-to: mchehab@infradead.org Delivery-date: Mon, 10 Aug 2009 09:59:18 +0000 Received: from bombadil.infradead.org [18.85.46.34] by pedra.chehab.org with IMAP (fetchmail-6.3.6) for (single-drop); Mon, 10 Aug 2009 07:06:08 -0300 (BRT) Received: from vger.kernel.org ([209.132.176.167]) by bombadil.infradead.org with esmtp (Exim 4.69 #1 (Red Hat Linux)) id 1MaRew-0000Vl-Aw; Mon, 10 Aug 2009 09:59:18 +0000 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753341AbZHJJ7O (ORCPT + 1 other); Mon, 10 Aug 2009 05:59:14 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1753366AbZHJJ7O (ORCPT ); Mon, 10 Aug 2009 05:59:14 -0400 Received: from smtp.nokia.com ([192.100.122.233]:19234 "EHLO mgw-mx06.nokia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753341AbZHJJ7N (ORCPT ); Mon, 10 Aug 2009 05:59:13 -0400 Received: from vaebh105.NOE.Nokia.com (vaebh105.europe.nokia.com [10.160.244.31]) by mgw-mx06.nokia.com (Switch-3.3.3/Switch-3.3.3) with ESMTP id n7A9wl6t010001; Mon, 10 Aug 2009 12:58:52 +0300 Received: from esebh102.NOE.Nokia.com ([172.21.138.183]) by vaebh105.NOE.Nokia.com with Microsoft SMTPSVC(6.0.3790.3959); Mon, 10 Aug 2009 12:58:56 +0300 Received: from vaebe101.NOE.Nokia.com ([10.160.244.11]) by esebh102.NOE.Nokia.com with Microsoft SMTPSVC(6.0.3790.3959); Mon, 10 Aug 2009 12:58:55 +0300 Received: from localhost.localdomain ([172.21.41.99]) by vaebe101.NOE.Nokia.com with Microsoft SMTPSVC(6.0.3790.3959); Mon, 10 Aug 2009 12:58:55 +0300 From: Eduardo Valentin To: "ext Hans Verkuil" , "ext Mauro Carvalho Chehab" Cc: "ext Douglas Schilling Landgraf" , "Nurkkala Eero.An (EXT-Offcode/Oulu)" , "Aaltonen Matti.J (Nokia-D/Tampere)" , Linux-Media , Eduardo Valentin Subject: [PATCH 1/1] si4713-i2c: Fix null pointer reference in probe Date: Mon, 10 Aug 2009 12:46:09 +0300 Message-Id: <1249897569-24203-1-git-send-email-eduardo.valentin@nokia.com> X-Mailer: git-send-email 1.6.2.GIT X-OriginalArrivalTime: 10 Aug 2009 09:58:55.0591 (UTC) FILETIME=[2C3A0770:01CA19A1] X-Nokia-AV: Clean Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org Remove reference to uninitialized v4l2_subdevice pointer in fail path of probe function. Signed-off-by: Eduardo Valentin --- linux/drivers/media/radio/si4713-i2c.c | 2 +- 1 files changed, 1 insertions(+), 1 deletions(-) diff --git a/linux/drivers/media/radio/si4713-i2c.c b/linux/drivers/media/radio/si4713-i2c.c index 116555c..e45d236 100644 --- a/linux/drivers/media/radio/si4713-i2c.c +++ b/linux/drivers/media/radio/si4713-i2c.c @@ -1976,7 +1976,7 @@ static int si4713_probe(struct i2c_client *client, sdev->platform_data = client->dev.platform_data; if (!sdev->platform_data) { - v4l2_err(&sdev->sd, "No platform data registered.\n"); + dev_err(&client->dev, "No platform data registered.\n"); rval = -ENODEV; goto free_sdev; }