From patchwork Sat Aug 8 17:45:33 2009 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alexey Klimov X-Patchwork-Id: 1471 Return-path: Envelope-to: mchehab@infradead.org Delivery-date: Sat, 08 Aug 2009 17:45:38 +0000 Received: from bombadil.infradead.org [18.85.46.34] by pedra.chehab.org with IMAP (fetchmail-6.3.6) for (single-drop); Sat, 08 Aug 2009 14:46:03 -0300 (BRT) Received: from vger.kernel.org ([209.132.176.167]) by bombadil.infradead.org with esmtp (Exim 4.69 #1 (Red Hat Linux)) id 1MZpz8-0005kZ-A2; Sat, 08 Aug 2009 17:45:38 +0000 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751802AbZHHRpf (ORCPT + 1 other); Sat, 8 Aug 2009 13:45:35 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751809AbZHHRpf (ORCPT ); Sat, 8 Aug 2009 13:45:35 -0400 Received: from mail-ew0-f214.google.com ([209.85.219.214]:58910 "EHLO mail-ew0-f214.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751802AbZHHRpe (ORCPT ); Sat, 8 Aug 2009 13:45:34 -0400 Received: by ewy10 with SMTP id 10so2174232ewy.37 for ; Sat, 08 Aug 2009 10:45:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:subject:from:to:cc :content-type:date:message-id:mime-version:x-mailer :content-transfer-encoding; bh=g2k5vjWdsutfsLSlIdXWHKKWYJ+7OQiwHnw64/+gzPQ=; b=jUfmi45Qtvm+Noru1Uz46z/TVs3GW0x5aCvP8Qje40zhHTQUO1T46A6mTXPkjJSJSt BagYIx01mnX8P8oLto+Mez70EzuaHNdMBP4wxGQScZX4JOobpy02LZjQ8OlG/M4gGkXb sAPpxW8nGB2C6vt+HbLlT8C6HbGp/Y4dOhz9c= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=subject:from:to:cc:content-type:date:message-id:mime-version :x-mailer:content-transfer-encoding; b=bPE5mVK3SS0tZSBJ4e2lrPc+LD2MQi26nRXjRroQsd96sWavERFPAxA7v8WeLruL1o pVN8lQzlTXI6rX02NZnRy6TnJ8DKXKzjEUIv32lHo9iDThjwpl/PyTX+HxlqyvyXEPT6 jnIJegv0mAX4ZlBUhZ73QqJDvO3Og6c+bjyiI= Received: by 10.210.41.14 with SMTP id o14mr907988ebo.23.1249753534341; Sat, 08 Aug 2009 10:45:34 -0700 (PDT) Received: from ?95.78.132.126? ([95.78.132.126]) by mx.google.com with ESMTPS id 5sm3456623eyh.36.2009.08.08.10.45.33 (version=SSLv3 cipher=RC4-MD5); Sat, 08 Aug 2009 10:45:34 -0700 (PDT) Subject: [patch review 1/6] radio-mr800: remove redundant lock/unlock_kernel From: Alexey Klimov To: Douglas Schilling Landgraf Cc: linux-media@vger.kernel.org Date: Sat, 08 Aug 2009 21:45:33 +0400 Message-Id: <1249753533.15160.241.camel@tux.localhost> Mime-Version: 1.0 X-Mailer: Evolution 2.26.3 Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org Remove redundant lock/unlock_kernel() calls from usb_amradio_open/close functions. Signed-off-by: Alexey Klimov diff -r ee6cf88cb5d3 linux/drivers/media/radio/radio-mr800.c --- a/linux/drivers/media/radio/radio-mr800.c Wed Jul 29 01:42:02 2009 -0300 +++ b/linux/drivers/media/radio/radio-mr800.c Wed Jul 29 10:44:02 2009 +0400 @@ -540,8 +540,6 @@ struct amradio_device *radio = video_get_drvdata(video_devdata(file)); int retval; - lock_kernel(); - radio->users = 1; radio->muted = 1; @@ -550,7 +548,6 @@ amradio_dev_warn(&radio->videodev->dev, "radio did not start up properly\n"); radio->users = 0; - unlock_kernel(); return -EIO; } @@ -564,7 +561,6 @@ amradio_dev_warn(&radio->videodev->dev, "set frequency failed\n"); - unlock_kernel(); return 0; }