From patchwork Thu Jul 30 21:49:49 2009 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jiri Slaby X-Patchwork-Id: 1428 Return-path: Envelope-to: mchehab@infradead.org Delivery-date: Thu, 30 Jul 2009 21:57:46 +0000 Received: from bombadil.infradead.org [18.85.46.34] by pedra.chehab.org with IMAP (fetchmail-6.3.6) for (single-drop); Thu, 30 Jul 2009 19:09:22 -0300 (BRT) Received: from vger.kernel.org ([209.132.176.167]) by bombadil.infradead.org with esmtp (Exim 4.69 #1 (Red Hat Linux)) id 1MWddC-0006ZA-Bf; Thu, 30 Jul 2009 21:57:46 +0000 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751938AbZG3V5m (ORCPT + 1 other); Thu, 30 Jul 2009 17:57:42 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752141AbZG3V5m (ORCPT ); Thu, 30 Jul 2009 17:57:42 -0400 Received: from server1.wserver.cz ([82.113.45.157]:36184 "EHLO server1.wserver.cz" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751938AbZG3V5l (ORCPT ); Thu, 30 Jul 2009 17:57:41 -0400 Received: from localhost.localdomain (unknown [82.113.46.245]) by server1.wserver.cz (Postfix) with ESMTP id ECFA5C4788; Thu, 30 Jul 2009 23:56:10 +0200 (CEST) From: Jiri Slaby To: Andrew Morton Cc: Mauro Carvalho Chehab , linux-media@vger.kernel.org, linux-kernel@vger.kernel.org, Jiri Slaby Subject: [PATCH repost2 2/2] V4L: saa7134, fix lock imbalance Date: Thu, 30 Jul 2009 23:49:49 +0200 Message-Id: <1248990589-25005-2-git-send-email-jirislaby@gmail.com> X-Mailer: git-send-email 1.6.3.3 In-Reply-To: <1248990589-25005-1-git-send-email-jirislaby@gmail.com> References: <1248990589-25005-1-git-send-email-jirislaby@gmail.com> Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org There is one superfluos (imbalanced) unlock in a poll function. Remove it. Signed-off-by: Jiri Slaby --- drivers/media/video/saa7134/saa7134-video.c | 1 - 1 files changed, 0 insertions(+), 1 deletions(-) diff --git a/drivers/media/video/saa7134/saa7134-video.c b/drivers/media/video/saa7134/saa7134-video.c index 58854df..da26f47 100644 --- a/drivers/media/video/saa7134/saa7134-video.c +++ b/drivers/media/video/saa7134/saa7134-video.c @@ -1444,7 +1444,6 @@ video_poll(struct file *file, struct poll_table_struct *wait) fh->cap.ops->buf_queue(&fh->cap,fh->cap.read_buf); fh->cap.read_off = 0; } - mutex_unlock(&fh->cap.vb_lock); buf = fh->cap.read_buf; }