From patchwork Fri Jul 3 20:51:33 2009 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jiri Slaby X-Patchwork-Id: 1291 Return-path: Envelope-to: mchehab@infradead.org Delivery-date: Fri, 03 Jul 2009 20:52:02 +0000 Received: from bombadil.infradead.org [18.85.46.34] by pedra.chehab.org with IMAP (fetchmail-6.3.6) for (single-drop); Fri, 03 Jul 2009 17:56:27 -0300 (BRT) Received: from vger.kernel.org ([209.132.176.167]) by bombadil.infradead.org with esmtp (Exim 4.69 #1 (Red Hat Linux)) id 1MMpjl-00086n-Nc; Fri, 03 Jul 2009 20:52:01 +0000 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1757987AbZGCUvz (ORCPT + 1 other); Fri, 3 Jul 2009 16:51:55 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1757308AbZGCUvy (ORCPT ); Fri, 3 Jul 2009 16:51:54 -0400 Received: from smtp.wellnetcz.com ([212.24.148.102]:57665 "EHLO smtp.wellnetcz.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1756083AbZGCUvy (ORCPT ); Fri, 3 Jul 2009 16:51:54 -0400 Received: from localhost.localdomain ([88.208.94.142]) by smtp.wellnetcz.com (8.14.1/8.14.1) with ESMTP id n63LZbSf020380; Fri, 3 Jul 2009 23:35:37 +0200 From: Jiri Slaby To: mchehab@infradead.org Cc: linux-media@vger.kernel.org, akpm@linux-foundation.org, linux-kernel@vger.kernel.org, Jiri Slaby Subject: [PATCH repost 1/4] V4L: radio-si470x, fix lock imbalance Date: Fri, 3 Jul 2009 22:51:33 +0200 Message-Id: <1246654296-23190-1-git-send-email-jirislaby@gmail.com> X-Mailer: git-send-email 1.6.3.2 Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org There is one path with omitted unlock in si470x_fops_release. Fix that. Signed-off-by: Jiri Slaby --- drivers/media/radio/radio-si470x.c | 5 ++--- 1 files changed, 2 insertions(+), 3 deletions(-) diff --git a/drivers/media/radio/radio-si470x.c b/drivers/media/radio/radio-si470x.c index 640421c..46d2163 100644 --- a/drivers/media/radio/radio-si470x.c +++ b/drivers/media/radio/radio-si470x.c @@ -1200,7 +1200,7 @@ static int si470x_fops_release(struct file *file) video_unregister_device(radio->videodev); kfree(radio->buffer); kfree(radio); - goto done; + goto unlock; } /* stop rds reception */ @@ -1213,9 +1213,8 @@ static int si470x_fops_release(struct file *file) retval = si470x_stop(radio); usb_autopm_put_interface(radio->intf); } - +unlock: mutex_unlock(&radio->disconnect_lock); - done: return retval; }