From patchwork Tue Feb 3 01:08:02 2009 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alexey Klimov X-Patchwork-Id: 471 Return-path: Envelope-to: mchehab@infradead.org Delivery-date: Tue, 03 Feb 2009 01:08:12 +0000 Received: from vger.kernel.org ([209.132.176.167]) by bombadil.infradead.org with esmtp (Exim 4.69 #1 (Red Hat Linux)) id 1LU9lr-0005sF-Jl for mchehab@infradead.org; Tue, 03 Feb 2009 01:08:12 +0000 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752853AbZBCBIK (ORCPT ); Mon, 2 Feb 2009 20:08:10 -0500 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752979AbZBCBIK (ORCPT ); Mon, 2 Feb 2009 20:08:10 -0500 Received: from fg-out-1718.google.com ([72.14.220.157]:44655 "EHLO fg-out-1718.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752918AbZBCBIJ (ORCPT ); Mon, 2 Feb 2009 20:08:09 -0500 Received: by fg-out-1718.google.com with SMTP id 16so763430fgg.17 for ; Mon, 02 Feb 2009 17:08:07 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=domainkey-signature:received:received:subject:from:to:cc :content-type:date:message-id:mime-version:x-mailer :content-transfer-encoding; bh=xEypvIICg4okB9DDU2JNmuIFq9slNg8Jwv3ILjmTgLQ=; b=jmcW9pVqLXdc+J9S+/KOk90uC35YSZ4W9pBGnfcPXc0/+TVPCKQenX5zAg2Q05fI7W SWrm/Qf8n3id7xKHeDOFngl5wVwvNtBQcuiQaLjCuti6RtIvrRpX/K3kUmhlhypOCYkX tlhurcEa2RKqTq3VUBWTWWDMQjEMLyHKLFM94= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=gamma; h=subject:from:to:cc:content-type:date:message-id:mime-version :x-mailer:content-transfer-encoding; b=sD2onQeH2rxspJ9+vvEJEcZDb8UfVKmybIU/1iiTq/t3Nw4JZX7V4xCx3sEHQYRy+b zVj1VMVxZf0ASeij3a/lcepA4hyogHyLruKjkRwiNViSwovNiCJ8y1wlvM458hIXUgM0 cuXXmrXhStw4ezpQUvvhWtMUS5P8ux1nE2+mI= Received: by 10.86.29.8 with SMTP id c8mr1065073fgc.19.1233623287150; Mon, 02 Feb 2009 17:08:07 -0800 (PST) Received: from ?192.168.1.42? (gw.zunet.ru [217.67.117.64]) by mx.google.com with ESMTPS id e20sm1932982fga.26.2009.02.02.17.08.05 (version=SSLv3 cipher=RC4-MD5); Mon, 02 Feb 2009 17:08:06 -0800 (PST) Subject: [patch review 2/8] radio-mr800: place dev_err instead of dev_warn From: Alexey Klimov To: Douglas Schilling Landgraf Cc: linux-media@vger.kernel.org Date: Tue, 03 Feb 2009 04:08:02 +0300 Message-Id: <1233623282.17456.254.camel@tux.localhost> Mime-Version: 1.0 X-Mailer: Evolution 2.24.2 Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org There should be dev_err message if video_register_device() fails. Correct this situation. Signed-off-by: Alexey Klimov diff -r ed1aa70cfdfa linux/drivers/media/radio/radio-mr800.c --- a/linux/drivers/media/radio/radio-mr800.c Mon Feb 02 02:29:52 2009 +0300 +++ b/linux/drivers/media/radio/radio-mr800.c Mon Feb 02 02:52:52 2009 +0300 @@ -672,7 +672,7 @@ video_set_drvdata(radio->videodev, radio); retval = video_register_device(radio->videodev, VFL_TYPE_RADIO, radio_nr); if (retval < 0) { - dev_warn(&intf->dev, "could not register video device\n"); + dev_err(&intf->dev, "could not register video device\n"); video_device_release(radio->videodev); kfree(radio->buffer); kfree(radio);