mbox series

[v2,0/4] Fix critical bugs

Message ID 20241217045125.58-1-jackson.lee@chipsnmedia.com (mailing list archive)
Headers
Series Fix critical bugs |

Message

jackson.lee Dec. 17, 2024, 4:51 a.m. UTC 
iThe wave5 codec driver is a stateful encoder/decoder.
The following patches is for improving decoder performance and fix critical bugs

v4l2-compliance results:
========================

v4l2-compliance 1.26.1-5142, 64 bits, 64-bit time_t

Buffer ioctls:
                warn: v4l2-test-buffers.cpp(693): VIDIOC_CREATE_BUFS not supported
                warn: v4l2-test-buffers.cpp(693): VIDIOC_CREATE_BUFS not supported
        test VIDIOC_REQBUFS/CREATE_BUFS/QUERYBUF: OK
        test CREATE_BUFS maximum buffers: OK
        test VIDIOC_EXPBUF: OK
        test Requests: OK (Not Supported)

Total for wave5-dec device /dev/video0: 46, Succeeded: 46, Failed: 0, Warnings: 2 
Total for wave5-enc device /dev/video1: 46, Succeeded: 46, Failed: 0, Warnings: 0

Fluster test results:
=====================

Running test suite JCT-VC-HEVC_V1 with decoder GStreamer-H.265-V4L2-Gst1.0 Using 1 parallel job(s)
Ran 132/147 tests successfully               in 68.608 secs

(1 test fails because of not supporting to parse multi frames, 1 test fails because of a missing frame and slight corruption,
 2 tests fail because of sizes which are incompatible with the IP, 11 tests fail because of unsupported 10 bit format)

Running test suite JVT-AVC_V1 with decoder GStreamer-H.264-V4L2-Gst1.0 Using 1 parallel job(s)
Ran 78/135 tests successfully               in 33.238 secs

(57 fail because the hardware is unable to decode  MBAFF / FMO / Field / Extended profile streams.)

Change since v1:
=================
* For [PATCH v2 1/4] media: chips-media: wave5: Fix to display gray color
  - Add Reviewed-by tag

* For [PATCH v2 2/4] media: chips-media: wave5: Avoid race condition for
 interrupt handling
  - Add Reviewed-by tag

* For [PATCH v2 3/4] media: chips-media: wave5: Fix hang after seeking
  - Add Reviewed-by tag

* For [PATCH v2 4/4] media: chips-media: wave5: Fix timeout while testing
  - Add Reviewed-by tag

* Drop "media: chips-media: wave5: Improve performance of decoder"
  - We will try to send this patch separately next time 
  


Change since v0:
=================

* For [PATCH v1 3/5] media: chips-media: wave5: Improve performance of
  decoder
  - Fix Null reference while testing fluster for more than 2
    decoders
  - Fix timeout while testing fluster for multi instances


Jackson.lee (4):
  media: chips-media: wave5: Fix to display gray color on screen
  media: chips-media: wave5: Avoid race condition for interrupt handling
  media: chips-media: wave5: Fix hang after seeking
  media: chips-media: wave5: Fix timeout while testing 10bit hevc
    fluster

 .../platform/chips-media/wave5/wave5-hw.c     |  2 +-
 .../chips-media/wave5/wave5-vpu-dec.c         | 31 ++++++++++++++++++-
 .../platform/chips-media/wave5/wave5-vpu.c    |  4 +--
 .../platform/chips-media/wave5/wave5-vpuapi.c | 10 ++++++
 4 files changed, 43 insertions(+), 4 deletions(-)

Comments

jackson.lee Jan. 7, 2025, 1:39 a.m. UTC | #1 
Hi Sebastian and Nicolas

Can you review the following patch series?

https://patchwork.linuxtv.org/project/linux-media/cover/20241217045125.58-1-jackson.lee@chipsnmedia.com/


thanks
Jackson

> -----Original Message-----
> From: jackson.lee
> Sent: Tuesday, December 17, 2024 1:52 PM
> To: mchehab@kernel.org; hverkuil-cisco@xs4all.nl;
> sebastian.fricke@collabora.com; nicolas.dufresne@collabora.com;
> bob.beckett@collabora.com; dafna.hirschfeld@collabora.com
> Cc: linux-media@vger.kernel.org; linux-kernel@vger.kernel.org; jackson.lee
> <jackson.lee@chipsnmedia.com>; lafley.kim <lafley.kim@chipsnmedia.com>; b-
> brnich@ti.com; hverkuil@xs4all.nl; Nas Chung <nas.chung@chipsnmedia.com>
> Subject: [PATCH v2 0/4] Fix critical bugs
> 
> iThe wave5 codec driver is a stateful encoder/decoder.
> The following patches is for improving decoder performance and fix
> critical bugs
> 
> v4l2-compliance results:
> ========================
> 
> v4l2-compliance 1.26.1-5142, 64 bits, 64-bit time_t
> 
> Buffer ioctls:
>                 warn: v4l2-test-buffers.cpp(693): VIDIOC_CREATE_BUFS not
> supported
>                 warn: v4l2-test-buffers.cpp(693): VIDIOC_CREATE_BUFS not
> supported
>         test VIDIOC_REQBUFS/CREATE_BUFS/QUERYBUF: OK
>         test CREATE_BUFS maximum buffers: OK
>         test VIDIOC_EXPBUF: OK
>         test Requests: OK (Not Supported)
> 
> Total for wave5-dec device /dev/video0: 46, Succeeded: 46, Failed: 0,
> Warnings: 2 Total for wave5-enc device /dev/video1: 46, Succeeded: 46,
> Failed: 0, Warnings: 0
> 
> Fluster test results:
> =====================
> 
> Running test suite JCT-VC-HEVC_V1 with decoder GStreamer-H.265-V4L2-Gst1.0
> Using 1 parallel job(s)
> Ran 132/147 tests successfully               in 68.608 secs
> 
> (1 test fails because of not supporting to parse multi frames, 1 test
> fails because of a missing frame and slight corruption,
>  2 tests fail because of sizes which are incompatible with the IP, 11
> tests fail because of unsupported 10 bit format)
> 
> Running test suite JVT-AVC_V1 with decoder GStreamer-H.264-V4L2-Gst1.0
> Using 1 parallel job(s)
> Ran 78/135 tests successfully               in 33.238 secs
> 
> (57 fail because the hardware is unable to decode  MBAFF / FMO / Field /
> Extended profile streams.)
> 
> Change since v1:
> =================
> * For [PATCH v2 1/4] media: chips-media: wave5: Fix to display gray color
>   - Add Reviewed-by tag
> 
> * For [PATCH v2 2/4] media: chips-media: wave5: Avoid race condition for
> interrupt handling
>   - Add Reviewed-by tag
> 
> * For [PATCH v2 3/4] media: chips-media: wave5: Fix hang after seeking
>   - Add Reviewed-by tag
> 
> * For [PATCH v2 4/4] media: chips-media: wave5: Fix timeout while testing
>   - Add Reviewed-by tag
> 
> * Drop "media: chips-media: wave5: Improve performance of decoder"
>   - We will try to send this patch separately next time
> 
> 
> 
> Change since v0:
> =================
> 
> * For [PATCH v1 3/5] media: chips-media: wave5: Improve performance of
>   decoder
>   - Fix Null reference while testing fluster for more than 2
>     decoders
>   - Fix timeout while testing fluster for multi instances
> 
> 
> Jackson.lee (4):
>   media: chips-media: wave5: Fix to display gray color on screen
>   media: chips-media: wave5: Avoid race condition for interrupt handling
>   media: chips-media: wave5: Fix hang after seeking
>   media: chips-media: wave5: Fix timeout while testing 10bit hevc
>     fluster
> 
>  .../platform/chips-media/wave5/wave5-hw.c     |  2 +-
>  .../chips-media/wave5/wave5-vpu-dec.c         | 31 ++++++++++++++++++-
>  .../platform/chips-media/wave5/wave5-vpu.c    |  4 +--
>  .../platform/chips-media/wave5/wave5-vpuapi.c | 10 ++++++
>  4 files changed, 43 insertions(+), 4 deletions(-)
> 
> --
> 2.43.0
jackson.lee Feb. 3, 2025, 12:54 a.m. UTC | #2 
Hi Sebastian and Nicolas

Is there any thing for me to do for these patch series ?

Thanks
Jackson


> -----Original Message-----
> From: jackson.lee
> Sent: Tuesday, January 7, 2025 10:39 AM
> To: mchehab@kernel.org; hverkuil-cisco@xs4all.nl;
> sebastian.fricke@collabora.com; nicolas.dufresne@collabora.com
> Cc: linux-media@vger.kernel.org; linux-kernel@vger.kernel.org; lafley.kim
> <lafley.kim@chipsnmedia.com>; b-brnich@ti.com; hverkuil@xs4all.nl; Nas
> Chung <nas.chung@chipsnmedia.com>
> Subject: RE: [PATCH v2 0/4] Fix critical bugs
> 
> Hi Sebastian and Nicolas
> 
> Can you review the following patch series?
> 
> https://patchwork.linuxtv.org/project/linux-media/cover/20241217045125.58-
> 1-jackson.lee@chipsnmedia.com/
> 
> 
> thanks
> Jackson
> 
> > -----Original Message-----
> > From: jackson.lee
> > Sent: Tuesday, December 17, 2024 1:52 PM
> > To: mchehab@kernel.org; hverkuil-cisco@xs4all.nl;
> > sebastian.fricke@collabora.com; nicolas.dufresne@collabora.com;
> > bob.beckett@collabora.com; dafna.hirschfeld@collabora.com
> > Cc: linux-media@vger.kernel.org; linux-kernel@vger.kernel.org;
> > jackson.lee <jackson.lee@chipsnmedia.com>; lafley.kim
> > <lafley.kim@chipsnmedia.com>; b- brnich@ti.com; hverkuil@xs4all.nl;
> > Nas Chung <nas.chung@chipsnmedia.com>
> > Subject: [PATCH v2 0/4] Fix critical bugs
> >
> > iThe wave5 codec driver is a stateful encoder/decoder.
> > The following patches is for improving decoder performance and fix
> > critical bugs
> >
> > v4l2-compliance results:
> > ========================
> >
> > v4l2-compliance 1.26.1-5142, 64 bits, 64-bit time_t
> >
> > Buffer ioctls:
> >                 warn: v4l2-test-buffers.cpp(693): VIDIOC_CREATE_BUFS
> > not supported
> >                 warn: v4l2-test-buffers.cpp(693): VIDIOC_CREATE_BUFS
> > not supported
> >         test VIDIOC_REQBUFS/CREATE_BUFS/QUERYBUF: OK
> >         test CREATE_BUFS maximum buffers: OK
> >         test VIDIOC_EXPBUF: OK
> >         test Requests: OK (Not Supported)
> >
> > Total for wave5-dec device /dev/video0: 46, Succeeded: 46, Failed: 0,
> > Warnings: 2 Total for wave5-enc device /dev/video1: 46, Succeeded: 46,
> > Failed: 0, Warnings: 0
> >
> > Fluster test results:
> > =====================
> >
> > Running test suite JCT-VC-HEVC_V1 with decoder
> > GStreamer-H.265-V4L2-Gst1.0 Using 1 parallel job(s)
> > Ran 132/147 tests successfully               in 68.608 secs
> >
> > (1 test fails because of not supporting to parse multi frames, 1 test
> > fails because of a missing frame and slight corruption,
> >  2 tests fail because of sizes which are incompatible with the IP, 11
> > tests fail because of unsupported 10 bit format)
> >
> > Running test suite JVT-AVC_V1 with decoder GStreamer-H.264-V4L2-Gst1.0
> > Using 1 parallel job(s)
> > Ran 78/135 tests successfully               in 33.238 secs
> >
> > (57 fail because the hardware is unable to decode  MBAFF / FMO / Field
> > / Extended profile streams.)
> >
> > Change since v1:
> > =================
> > * For [PATCH v2 1/4] media: chips-media: wave5: Fix to display gray
> color
> >   - Add Reviewed-by tag
> >
> > * For [PATCH v2 2/4] media: chips-media: wave5: Avoid race condition
> > for interrupt handling
> >   - Add Reviewed-by tag
> >
> > * For [PATCH v2 3/4] media: chips-media: wave5: Fix hang after seeking
> >   - Add Reviewed-by tag
> >
> > * For [PATCH v2 4/4] media: chips-media: wave5: Fix timeout while
> testing
> >   - Add Reviewed-by tag
> >
> > * Drop "media: chips-media: wave5: Improve performance of decoder"
> >   - We will try to send this patch separately next time
> >
> >
> >
> > Change since v0:
> > =================
> >
> > * For [PATCH v1 3/5] media: chips-media: wave5: Improve performance of
> >   decoder
> >   - Fix Null reference while testing fluster for more than 2
> >     decoders
> >   - Fix timeout while testing fluster for multi instances
> >
> >
> > Jackson.lee (4):
> >   media: chips-media: wave5: Fix to display gray color on screen
> >   media: chips-media: wave5: Avoid race condition for interrupt handling
> >   media: chips-media: wave5: Fix hang after seeking
> >   media: chips-media: wave5: Fix timeout while testing 10bit hevc
> >     fluster
> >
> >  .../platform/chips-media/wave5/wave5-hw.c     |  2 +-
> >  .../chips-media/wave5/wave5-vpu-dec.c         | 31 ++++++++++++++++++-
> >  .../platform/chips-media/wave5/wave5-vpu.c    |  4 +--
> >  .../platform/chips-media/wave5/wave5-vpuapi.c | 10 ++++++
> >  4 files changed, 43 insertions(+), 4 deletions(-)
> >
> > --
> > 2.43.0