From patchwork Thu Oct 19 09:01:25 2023 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Umang Jain X-Patchwork-Id: 96026 Received: from vger.kernel.org ([23.128.96.18]) by www.linuxtv.org with esmtp (Exim 4.92) (envelope-from ) id 1qtOuX-002GJt-Tl; Thu, 19 Oct 2023 09:01:48 +0000 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232788AbjJSJBo (ORCPT + 1 other); Thu, 19 Oct 2023 05:01:44 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39264 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229998AbjJSJBn (ORCPT ); Thu, 19 Oct 2023 05:01:43 -0400 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2906FFA for ; Thu, 19 Oct 2023 02:01:41 -0700 (PDT) Received: from umang.jainideasonboard.com (unknown [103.251.226.1]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 1B88F276; Thu, 19 Oct 2023 11:01:27 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1697706091; bh=0IdmhEotctmPef8qb+I8G8sMyOBhKaSYmTmYqHHKNRg=; h=From:To:Cc:Subject:Date:From; b=Eb7cq8pmZknptTqC5uWgzTE+VmpOXWwt4fT7qEvSwQm4ocLhLRI13IqDDzuqQDj28 MtVGidYlOzDza+lv/xUgs4q56oLuLYJB5gLsQGkePvaskW+/jNHTP69DdMA0Tx3tZ8 eFBtIWUdAvJsQuWP7mtIMBwhCcjsTUmjZUTij6qc= From: Umang Jain To: linux-staging@lists.linux.dev, linux-rpi-kernel@lists.infradead.org, linux-media@vger.kernel.org, linux-arm-kernel@lists.infradead.org Cc: Stefan Wahren , Greg Kroah-Hartman , Dan Carpenter , Kieran Bingham , Laurent Pinchart , Umang Jain Subject: [PATCH v3 0/3] staging: vc04_services: Tweak module autoloading support Date: Thu, 19 Oct 2023 14:31:25 +0530 Message-Id: <20231019090128.430297-1-umang.jain@ideasonboard.com> X-Mailer: git-send-email 2.40.1 MIME-Version: 1.0 X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_BLOCKED, SPF_HELO_PASS,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org X-LSpam-Score: -4.8 (----) X-LSpam-Report: No, score=-4.8 required=5.0 tests=BAYES_00=-1.9,DKIM_SIGNED=0.1,DKIM_VALID=-0.1,DKIM_VALID_AU=-0.1,HEADER_FROM_DIFFERENT_DOMAINS=0.5,MAILING_LIST_MULTI=-1,RCVD_IN_DNSWL_MED=-2.3 autolearn=ham autolearn_force=no As explained by Greg KH in [1], we should not be using MODULE_ALIAS to auto load modules within VC04. Drop that, in favour of MODULE_DEVICE_TABLE. This series addresses the suggestion. Patch 1/3 adds vchiq_bus_device_id and supporting entries in script/mod/file2alias.c Patch 2/3 drops MODULE_ALIAS from bcm2835-audio in favour of MODULE_DEVICE_TABLE. Patch 3/3 drops MODULE_ALIAS from bcm2835-camera in favour of MODULE_DEVICE_TABLE. [1]: https://lore.kernel.org/linux-media/2023100955-stunt-equate-c6fa@gregkh/ Reviewed-by: Kieran Bingham --- Changes in v3: - Drop "_bus" suffix from all patches (and commit message) as pointed out in v2 review Changes in v2: - NULL terminate device_id_table arrays (in 2/3 and 3/3) Umang Jain (3): staging: vc04_services: Support module autoloading using MODULE_DEVICE_TABLE staging: vc04_services: bcm2835-audio: Drop MODULE_ALIAS staging: vc04_services: bcm2835-camera: Drop MODULE_ALIAS drivers/staging/vc04_services/bcm2835-audio/bcm2835.c | 8 +++++++- .../vc04_services/bcm2835-camera/bcm2835-camera.c | 8 +++++++- .../vc04_services/interface/vchiq_arm/vchiq_bus.c | 2 +- .../vc04_services/interface/vchiq_arm/vchiq_bus.h | 3 +++ include/linux/mod_devicetable.h | 4 ++++ scripts/mod/devicetable-offsets.c | 3 +++ scripts/mod/file2alias.c | 9 +++++++++ 7 files changed, 34 insertions(+), 3 deletions(-)