Message ID | 20230104162215.31194-1-laurent.pinchart@ideasonboard.com (mailing list archive) |
---|---|
Headers |
Received: from vger.kernel.org ([23.128.96.18]) by www.linuxtv.org with esmtp (Exim 4.92) (envelope-from <linux-media-owner@vger.kernel.org>) id 1pD6Xd-00BGRS-8r; Wed, 04 Jan 2023 16:23:01 +0000 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239677AbjADQWy (ORCPT <rfc822;mkrufky@linuxtv.org> + 1 other); Wed, 4 Jan 2023 11:22:54 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45888 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239663AbjADQWV (ORCPT <rfc822;linux-media@vger.kernel.org>); Wed, 4 Jan 2023 11:22:21 -0500 Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [213.167.242.64]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id DCD7D4435F for <linux-media@vger.kernel.org>; Wed, 4 Jan 2023 08:22:20 -0800 (PST) Received: from pendragon.ideasonboard.com (213-243-189-158.bb.dnainternet.fi [213.243.189.158]) by perceval.ideasonboard.com (Postfix) with ESMTPSA id 05CB91026; Wed, 4 Jan 2023 17:22:18 +0100 (CET) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=ideasonboard.com; s=mail; t=1672849339; bh=dbFdcHiTydDgtP5vNT6pBiDy173XP0n7SIZhDylU7qI=; h=From:To:Cc:Subject:Date:From; b=n2TaHU2385f6F1kHt4jG0HEVGbUT2fCfm6GSe3aqLDtk4coO8maU9IQv9pOyMJg0N lTDZnz1WFNSU4qzn+bNBc1Qctn8XTP+ctFeLmcedlKqYF9O0bB+Tlu4GJG+lR2vE30 qw8xqf4oYBgo/KlWUN/PtEQWUvMDxiHh0WC64nz8= From: Laurent Pinchart <laurent.pinchart@ideasonboard.com> To: linux-media@vger.kernel.org Cc: linux-sunxi@lists.linux.dev, Yong Deng <yong.deng@magewell.com>, Paul Kocialkowski <paul.kocialkowski@bootlin.com>, Adam Pigg <adam@piggz.co.uk> Subject: [PATCH v1 0/2] media: sun6i-csi: Fix format propagation in bridge Date: Wed, 4 Jan 2023 18:22:13 +0200 Message-Id: <20230104162215.31194-1-laurent.pinchart@ideasonboard.com> X-Mailer: git-send-email 2.38.2 MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Spam-Status: No, score=-2.1 required=5.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,SPF_HELO_PASS,SPF_PASS autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: <linux-media.vger.kernel.org> X-Mailing-List: linux-media@vger.kernel.org X-LSpam-Score: -2.5 (--) X-LSpam-Report: No, score=-2.5 required=5.0 tests=BAYES_00=-1.9,DKIM_SIGNED=0.1,DKIM_VALID=-0.1,DKIM_VALID_AU=-0.1,HEADER_FROM_DIFFERENT_DOMAINS=0.5,MAILING_LIST_MULTI=-1 autolearn=ham autolearn_force=no |
Series |
media: sun6i-csi: Fix format propagation in bridge
|
|
Message
Laurent Pinchart
Jan. 4, 2023, 4:22 p.m. UTC
Hello, This small patch series fixes format propagation in the sun6i-csi-bridge subdev from sink pad to source pad. In order to do so, it uses the V4L2 subdev active state provided by the V4L2 subdev core (patch 2/2), with a preparatory patch (1/2) that drops direct access to the bridge fields from the capture side. I haven't tested the patches myself as I lack a hardware platform for this, but Adam (on CC) has successfully tested them. Adam, if you want to reply with a Tested-by tag, that would be appreciated. Laurent Pinchart (2): media: sun6i-csi: capture: Use subdev operation to access bridge format media: sun6i-csi: subdev: Use subdev active state to store active format .../sunxi/sun6i-csi/sun6i_csi_bridge.c | 211 ++++++++---------- .../sunxi/sun6i-csi/sun6i_csi_bridge.h | 9 - .../sunxi/sun6i-csi/sun6i_csi_capture.c | 23 +- 3 files changed, 110 insertions(+), 133 deletions(-) base-commit: 6599e683db1bf22fee74302c47e31b9a42a1c3d2
Comments
On Wednesday, 4 January 2023 16:22:13 GMT Laurent Pinchart wrote: > Hello, > > This small patch series fixes format propagation in the sun6i-csi-bridge > subdev from sink pad to source pad. In order to do so, it uses the V4L2 > subdev active state provided by the V4L2 subdev core (patch 2/2), with a > preparatory patch (1/2) that drops direct access to the bridge fields > from the capture side. > > I haven't tested the patches myself as I lack a hardware platform for > this, but Adam (on CC) has successfully tested them. Adam, if you want > to reply with a Tested-by tag, that would be appreciated. > > Laurent Pinchart (2): > media: sun6i-csi: capture: Use subdev operation to access bridge > format > media: sun6i-csi: subdev: Use subdev active state to store active > format > > .../sunxi/sun6i-csi/sun6i_csi_bridge.c | 211 ++++++++---------- > .../sunxi/sun6i-csi/sun6i_csi_bridge.h | 9 - > .../sunxi/sun6i-csi/sun6i_csi_capture.c | 23 +- > 3 files changed, 110 insertions(+), 133 deletions(-) > > > base-commit: 6599e683db1bf22fee74302c47e31b9a42a1c3d2 Tested-by Adam Pigg <adam@piggz.co.uk> I have used these 2 patches, along with the other 5 here [1] to successfully capture frames on the Pinephone rear camera (ov5640) using libcamera and its cam utility. I will submit the other patches here shortly. [1] https://github.com/sailfish-on-dontbeevil/kernel-megi/commits/pinephone-libcamera
Hi Adam, On Thu, Jan 05, 2023 at 09:48:46PM +0000, Adam Pigg wrote: > On Wednesday, 4 January 2023 16:22:13 GMT Laurent Pinchart wrote: > > Hello, > > > > This small patch series fixes format propagation in the sun6i-csi-bridge > > subdev from sink pad to source pad. In order to do so, it uses the V4L2 > > subdev active state provided by the V4L2 subdev core (patch 2/2), with a > > preparatory patch (1/2) that drops direct access to the bridge fields > > from the capture side. > > > > I haven't tested the patches myself as I lack a hardware platform for > > this, but Adam (on CC) has successfully tested them. Adam, if you want > > to reply with a Tested-by tag, that would be appreciated. > > > > Laurent Pinchart (2): > > media: sun6i-csi: capture: Use subdev operation to access bridge > > format > > media: sun6i-csi: subdev: Use subdev active state to store active > > format > > > > .../sunxi/sun6i-csi/sun6i_csi_bridge.c | 211 ++++++++---------- > > .../sunxi/sun6i-csi/sun6i_csi_bridge.h | 9 - > > .../sunxi/sun6i-csi/sun6i_csi_capture.c | 23 +- > > 3 files changed, 110 insertions(+), 133 deletions(-) > > > > > > base-commit: 6599e683db1bf22fee74302c47e31b9a42a1c3d2 > > Tested-by Adam Pigg <adam@piggz.co.uk> Thank you. For the next time, note that there should be a column after Tested-by, as in Tested-by: Adam Pigg <adam@piggz.co.uk> Paul, if I could get your review on this, I'll include the patches in a pull request for v6.3. > I have used these 2 patches, along with the other 5 here [1] to successfully > capture frames on the Pinephone rear camera (ov5640) using libcamera and its > cam utility. > > I will submit the other patches here shortly. > > [1] https://github.com/sailfish-on-dontbeevil/kernel-megi/commits/pinephone-libcamera
Hi Paul, Ping for a review. I'd like to get this in v6.4. On Wed, Jan 04, 2023 at 06:22:13PM +0200, Laurent Pinchart wrote: > Hello, > > This small patch series fixes format propagation in the sun6i-csi-bridge > subdev from sink pad to source pad. In order to do so, it uses the V4L2 > subdev active state provided by the V4L2 subdev core (patch 2/2), with a > preparatory patch (1/2) that drops direct access to the bridge fields > from the capture side. > > I haven't tested the patches myself as I lack a hardware platform for > this, but Adam (on CC) has successfully tested them. Adam, if you want > to reply with a Tested-by tag, that would be appreciated. > > Laurent Pinchart (2): > media: sun6i-csi: capture: Use subdev operation to access bridge > format > media: sun6i-csi: subdev: Use subdev active state to store active > format > > .../sunxi/sun6i-csi/sun6i_csi_bridge.c | 211 ++++++++---------- > .../sunxi/sun6i-csi/sun6i_csi_bridge.h | 9 - > .../sunxi/sun6i-csi/sun6i_csi_capture.c | 23 +- > 3 files changed, 110 insertions(+), 133 deletions(-) > > > base-commit: 6599e683db1bf22fee74302c47e31b9a42a1c3d2