From patchwork Mon Jun 13 19:50:57 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Hans de Goede X-Patchwork-Id: 83879 Received: from vger.kernel.org ([23.128.96.18]) by www.linuxtv.org with esmtp (Exim 4.92) (envelope-from ) id 1o0qw2-002Id7-Qe; Mon, 13 Jun 2022 20:45:19 +0000 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344937AbiFMUpC (ORCPT + 1 other); Mon, 13 Jun 2022 16:45:02 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:52466 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1351445AbiFMUoH (ORCPT ); Mon, 13 Jun 2022 16:44:07 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTP id 95D51A1A1 for ; Mon, 13 Jun 2022 12:51:44 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1655149903; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version: content-transfer-encoding:content-transfer-encoding; bh=io8gi02VFtQOqYYTcsWBfF3YfOMtYeYi78xBqUdi22c=; b=R+7kDARxdqY9BzrtBQ3ONIPKmEVtINUznf1iHA62WsrEJo8+I9YnfFte9cZxSdv5LFF3Of 4LxS+dJKz4rDX5IFZWD0DwKTMZqMbyIpdglNOxSMBvG8NY0o0aKD7lOCsyxB9n+8fshqIH dVFRoOmJbtwStpQ4mBhYEc2DsyAIIDk= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-640-xtc6QbhHOK-Ylt8l0bQaAw-1; Mon, 13 Jun 2022 15:51:40 -0400 X-MC-Unique: xtc6QbhHOK-Ylt8l0bQaAw-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.rdu2.redhat.com [10.11.54.6]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 8553E85A583; Mon, 13 Jun 2022 19:51:39 +0000 (UTC) Received: from shalem.redhat.com (unknown [10.39.192.42]) by smtp.corp.redhat.com (Postfix) with ESMTP id CEF7B2166B26; Mon, 13 Jun 2022 19:51:37 +0000 (UTC) From: Hans de Goede To: Mauro Carvalho Chehab , Sakari Ailus Cc: Hans de Goede , Tsuchiya Yuto , Andy Shevchenko , Yury Luneff , Nable , andrey.i.trufanov@gmail.com, Fabio Aiuto , linux-media@vger.kernel.org, linux-staging@lists.linux.dev Subject: [PATCH 00/40] media: atomisp: Various hmm and other cleanups Date: Mon, 13 Jun 2022 21:50:57 +0200 Message-Id: <20220613195137.8117-1-hdegoede@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.78 on 10.11.54.6 X-Spam-Status: No, score=-3.3 required=5.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,DKIM_VALID_EF,RCVD_IN_DNSWL_NONE, SPF_HELO_NONE,SPF_NONE,T_SCC_BODY_TEXT_LINE autolearn=ham autolearn_force=no version=3.4.6 X-Spam-Checker-Version: SpamAssassin 3.4.6 (2021-04-09) on lindbergh.monkeyblade.net Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org X-LSpam-Score: -2.5 (--) X-LSpam-Report: No, score=-2.5 required=5.0 tests=BAYES_00=-1.9,DKIMWL_WL_HIGH=0.001,DKIM_SIGNED=0.1,DKIM_VALID=-0.1,DKIM_VALID_AU=-0.1,HEADER_FROM_DIFFERENT_DOMAINS=0.5,MAILING_LIST_MULTI=-1 autolearn=ham autolearn_force=no Hi All, I want to start writing a libcamera pipeline handler for the atomisp2, but before I can do that I first need to fix mmap support in atomisp2. My plan for this is to port the atomisp2 handler to videobuf2. To do that I first need to understand the existing memory/buffer management so I've started with cleaning up the hmm code (with a bit of a detour here and there). This series is the result of that. There are likely more cleanups to follow, but I've to focus on some other things for a bit. I hope to be able to return to the cleanups + an eventual videobuf2 conversion soon. Regards, Hans Hans de Goede (40): media: atomisp: remove the unused RAW_BUF_STRIDE macro media: atomisp: remove unused ia_css_frame_allocate_contiguous*() functions media: atomisp: drop contiguous argument from ia_css_frame_allocate_with_buffer_size() media: atomisp: drop contiguous argument from frame_allocate_with_data() media: atomisp: drop contiguous argument from frame_create() media: atomisp: drop IA_CSS_FRAME_FORMAT_MIPI support from ia_css_frame_init_planes() media: atomisp: drop contiguous flag from struct ia_css_frame media: atomisp: drop ATOMISP_MAP_FLAG_CONTIGUOUS media: atomisp: remove dynamic and reserved pool code media: atomisp: remove hmm_pool_[un]register() media: atomisp: remove hmm pool code media: atomisp: remove hmm_mem_stats media: atomisp: remove pool related kernel cmdline options media: atomisp: remove unused attribute argument from ia_css_frame_map() media: atomisp: drop hmm_page_type media: atomisp: removed unused hmm_bo_get_page_info() function media: atomisp: remove bogus comment above hmm_bo_allocated() prototype media: atomisp: remove private acceleration ioctls media: atomisp: remove atomisp_acc.c media: atomisp: remove unused atomisp_*css_* functions media: atomisp: asc.acc.pipeline is always NULL media: atomisp: remove no longer used atomisp_css_acc_done() function media: atomisp: remove atomisp_is_acc_enabled() media: atomisp: drop unused ATOMISP_ACC_FW_LOAD_* defines media: atomisp: drop ATOMISP_MAP_FLAG_CLEARED media: atomisp: drop unused ATOMISP_MAP_FLAG_* flags media: atomisp: remove unused hmm address translation functions media: atomisp: add hmm_create_from_userdata() helper media: atomisp: Simplify hmm_alloc() calls media: atomisp: drop highmem var/arg from the hmm code media: atomisp: drop HMM_BO_SHARE type media: atomisp: remove hmm_page_object media: atomisp: fix __get_frame_info() error handling media: atomisp: add error checking to atomisp_create_pipes_stream() media: atomisp: add error logging to atomisp_destroy_pipes_stream_force() media: atomisp: use atomisp_create_pipes_stream() in more places media: atomisp: use atomisp_css_update_stream() in more places media: atomisp: use atomisp_destroy_pipes_stream_force() in more places media: atomisp: remove force argument from __destroy_[stream[s]|pipe[s]]() media: atomisp: Add a notes.txt file drivers/staging/media/atomisp/Makefile | 3 - .../staging/media/atomisp/include/hmm/hmm.h | 32 +- .../media/atomisp/include/hmm/hmm_bo.h | 37 +- .../media/atomisp/include/hmm/hmm_common.h | 26 - .../media/atomisp/include/hmm/hmm_pool.h | 116 ---- .../media/atomisp/include/linux/atomisp.h | 146 ---- drivers/staging/media/atomisp/notes.txt | 30 + .../staging/media/atomisp/pci/atomisp_acc.c | 625 ------------------ .../staging/media/atomisp/pci/atomisp_acc.h | 120 ---- .../staging/media/atomisp/pci/atomisp_cmd.c | 33 +- .../media/atomisp/pci/atomisp_compat.h | 29 +- .../media/atomisp/pci/atomisp_compat_css20.c | 365 ++-------- .../atomisp/pci/atomisp_compat_ioctl32.h | 58 -- .../staging/media/atomisp/pci/atomisp_drvfs.c | 7 +- .../staging/media/atomisp/pci/atomisp_fops.c | 13 - .../staging/media/atomisp/pci/atomisp_ioctl.c | 73 +- .../staging/media/atomisp/pci/atomisp_ioctl.h | 1 - .../media/atomisp/pci/atomisp_subdev.c | 3 - .../media/atomisp/pci/atomisp_subdev.h | 10 - .../staging/media/atomisp/pci/atomisp_v4l2.c | 32 - drivers/staging/media/atomisp/pci/hmm/hmm.c | 186 +----- .../staging/media/atomisp/pci/hmm/hmm_bo.c | 261 ++------ .../media/atomisp/pci/hmm/hmm_dynamic_pool.c | 234 ------- .../media/atomisp/pci/hmm/hmm_reserved_pool.c | 253 ------- .../media/atomisp/pci/ia_css_frame_public.h | 40 -- .../kernels/sdis/sdis_1.0/ia_css_sdis.host.c | 2 +- .../kernels/sdis/sdis_2/ia_css_sdis2.host.c | 2 +- .../pci/isp/modes/interface/isp_const.h | 6 - .../pci/runtime/debug/src/ia_css_debug.c | 2 - .../runtime/frame/interface/ia_css_frame.h | 7 +- .../atomisp/pci/runtime/frame/src/frame.c | 105 +-- .../pci/runtime/isp_param/src/isp_param.c | 2 +- .../atomisp/pci/runtime/rmgr/src/rmgr_vbuf.c | 3 +- .../atomisp/pci/runtime/spctrl/src/spctrl.c | 2 +- drivers/staging/media/atomisp/pci/sh_css.c | 5 - .../media/atomisp/pci/sh_css_firmware.c | 2 +- .../staging/media/atomisp/pci/sh_css_mipi.c | 3 +- .../staging/media/atomisp/pci/sh_css_params.c | 47 +- 38 files changed, 205 insertions(+), 2716 deletions(-) delete mode 100644 drivers/staging/media/atomisp/include/hmm/hmm_pool.h create mode 100644 drivers/staging/media/atomisp/notes.txt delete mode 100644 drivers/staging/media/atomisp/pci/atomisp_acc.c delete mode 100644 drivers/staging/media/atomisp/pci/atomisp_acc.h delete mode 100644 drivers/staging/media/atomisp/pci/hmm/hmm_dynamic_pool.c delete mode 100644 drivers/staging/media/atomisp/pci/hmm/hmm_reserved_pool.c Reviewed-by: Andy Shevchenko Reviewed-by: Andy Shevchenko