From patchwork Thu Jul 30 15:34:57 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Daniel Almeida X-Patchwork-Id: 65921 Received: from vger.kernel.org ([23.128.96.18]) by www.linuxtv.org with esmtp (Exim 4.92) (envelope-from ) id 1k1AVj-001YZ3-Cn; Thu, 30 Jul 2020 15:30:24 +0000 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729779AbgG3Pf1 (ORCPT + 1 other); Thu, 30 Jul 2020 11:35:27 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37148 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726581AbgG3Pf0 (ORCPT ); Thu, 30 Jul 2020 11:35:26 -0400 Received: from mail-qk1-x743.google.com (mail-qk1-x743.google.com [IPv6:2607:f8b0:4864:20::743]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 7408FC061574; Thu, 30 Jul 2020 08:35:26 -0700 (PDT) Received: by mail-qk1-x743.google.com with SMTP id x69so26006954qkb.1; Thu, 30 Jul 2020 08:35:26 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=Ww+VtdoA6riXvdcxQjNRAvO2TJJKFKtGr51sohVqrlg=; b=mLH18p6FsRXXWhEsi1fYEMYmlm3hbSqTdTWG9Vg2KnurRTVgSWrzNywe9PFBUGrKhu GgnMY57pdTTtIEzcVUISk/uBXFXlaLonjnJgVFHBaT0WSJC+3zqNljViWuv56CdWFf+s XDL97RhXLxC2aR7OAn1HOFiDN2bbmL0avQgPSZWLFVir52fgi11RBJiCfoDej1bdI7dk wtOwb+N6pkfvqfQerLZMcOWMzp8B5PJ9eqs9l5JipPWuWQTTHBOIis5joYtgWFieKCn3 5ySQzQm3mR73g5UR0UPqB7ERZcohT0Nz4sR6JvwaeppoRjst0eakZHyNiwje2VfMRrDZ Npbg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=Ww+VtdoA6riXvdcxQjNRAvO2TJJKFKtGr51sohVqrlg=; b=mb6hRUmswbXLvWdjdkNu9bZaroYymZ2pqOAl77Zf+XPh+dMrwyj/ev4kRqLhkNyg0T ygOLYZF6Tdb7wnq3AnvkssD4y0tWN/cgo/o/6m01Ftx0NMKDvAeIMGcry31sTvQRbIbP rlO6FC2xuLw7cT82LLiN7aj/oEtJkOJdH3X9bMN3zyosC3dT/TKAf0H+NgfFCk9fdVIY ijrGK4Ha1H7MS6QRsi9f+wF6JUv877GN6tJ0FkXgc9L7zYNhL5wrDeeUksFlRNpBDWlI qCNrEe7hHlt0L260k/yfMhcA6v2ttCqyhwycbNVpIwZxsJiLGh4UnbU7hd8MNRzXeh22 Tl3Q== X-Gm-Message-State: AOAM5322qise0oQNg7tzC40E/Qa9iVfOLZKyCcXt14rlhJjwCDDIun/c AMB4GEgWQwEMAjAP9rZQhtY= X-Google-Smtp-Source: ABdhPJxWTkiCH9U+VuFEcwhQD6FLBSq3WDEOT3bXoozCq2UfOlTo4OVcEHYLExZtRcWh0C82ifnN3Q== X-Received: by 2002:a37:8305:: with SMTP id f5mr39702199qkd.497.1596123325201; Thu, 30 Jul 2020 08:35:25 -0700 (PDT) Received: from localhost.localdomain ([2804:14d:72b1:8920:a2ce:f815:f14d:bfac]) by smtp.gmail.com with ESMTPSA id i7sm659047qtb.27.2020.07.30.08.35.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 30 Jul 2020 08:35:24 -0700 (PDT) From: "Daniel W. S. Almeida" X-Google-Original-From: Daniel W. S. Almeida To: mchehab+huawei@kernel.org, sean@mess.org, kstewart@linuxfoundation.org, allison@lohutok.net, tglx@linutronix.de Cc: "Daniel W . S . Almeida" , linux-media@vger.kernel.org, skhan@linuxfoundation.org, linux-kernel-mentees@lists.linuxfoundation.org, linux-kernel@vger.kernel.org Subject: [v8 0/4] media: vidtv: Implement a virtual DVB driver Date: Thu, 30 Jul 2020 12:34:57 -0300 Message-Id: <20200730153501.742993-1-dwlsalmeida@gmail.com> X-Mailer: git-send-email 2.27.0 MIME-Version: 1.0 Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-media@vger.kernel.org X-LSpam-Score: -2.5 (--) X-LSpam-Report: No, score=-2.5 required=5.0 tests=BAYES_00=-1.9,DKIM_SIGNED=0.1,DKIM_VALID=-0.1,DKIM_VALID_AU=-0.1,FREEMAIL_FORGED_FROMDOMAIN=0.001,FREEMAIL_FROM=0.001,HEADER_FROM_DIFFERENT_DOMAINS=0.5,MAILING_LIST_MULTI=-1 autolearn=ham autolearn_force=no From: Daniel W. S. Almeida This series is work in progress. It represents the current work done on a virtual DVB driver for the Linux media subsystem. I am new to the media subsystem and to kernel development in general. This driver aims to: - Serve as template for new DVB driver writers - Help userspace application writers in general - Push fake audio/video to userspace for testing purposes - Push debug information to userspace via debugfs Current state for this driver: - Driver is modprobed without any errors on dmesg - Using dvbv5-scan does not cause the driver to crash - Driver feeds the demux with TS packets (PSI, PCR, AES3 audio and NULL packets for padding), but the stream is not valid yet. - Kmemleak shows no leaks. UBSAN & KASAN pick up some bugs The Virtual Digital TV Driver (vidtv) Background ---------- Vidtv is a virtual DVB driver that aims to serve as a reference for driver writers by serving as a template. It also validates the existing media DVB APIs, thus helping userspace application writers. Currently, it consists of: - A fake tuner driver, which will report a bad signal quality if the chosen frequency is too far away from a table of valid frequencies for a particular delivery system. - A fake demod driver, which will constantly poll the fake signal quality returned by the tuner, simulating a device that can lose/reacquire a lock on the signal depending on the CNR levels. - A fake bridge driver, which is the module responsible for modprobing the fake tuner and demod modules and implementing the demux logic. This module takes parameters at initialization that will dictate how the simulation behaves. - Code reponsible for encoding a valid MPEG Transport Stream, which is then passed to the bridge driver. This fake stream contains some hardcoded content. For now, we have a single, audio-only channel containing a single MPEG Elementary Stream, which in turn contains a SMPTE 302m encoded sine-wave. Note that this particular encoder was chosen because it is the easiest way to encode PCM audio data in a MPEG Transport Stream. Building vidtv -------------- vidtv is a test driver and thus is **not** enabled by default when compiling the kernel. In order to enable compilation of vidtv: - Enable **DVB_TEST_DRIVERS**, then - Enable **DVB_VIDTV** When compiled as a module, expect the following .ko files: - dvb_vidtv_tuner.ko - dvb_vidtv_demod.ko - dvb_vidtv_bridge.ko Running vidtv ------------- When compiled as a module, run:: modprobe dvb_vidtv_bridge That's it! The bridge driver will initialize the tuner and demod drivers as part of its own initialization. You can optionally define some command-line arguments to vidtv, see the documentation for more info. Testing vidtv with v4l-utils ============================ Start by installing v4l-utils and then modprobing vidtv:: modprobe dvb_vidtv_bridge If the driver is OK, it should load and its probing code will run. This will pull in the tuner and demod drivers. Using dvb-fe-tool ----------------- The first step to check whether the demod loaded successfully is to run:: $ dvb-fe-tool This should return what is currently set up at the demod struct, i.e.:: static const struct dvb_frontend_ops vidtv_demod_ops = { .delsys = { SYS_DVBT, SYS_DVBT2, SYS_DVBC_ANNEX_A, SYS_DVBS, SYS_DVBS2, }, .info = { .name = "Dummy demod for DVB-T/T2/C/S/S2", .frequency_min_hz = 51 * MHz, .frequency_max_hz = 2150 * MHz, .frequency_stepsize_hz = 62500, .frequency_tolerance_hz = 29500 * kHz, .symbol_rate_min = 1000000, .symbol_rate_max = 45000000, .caps = FE_CAN_FEC_1_2 | FE_CAN_FEC_2_3 | FE_CAN_FEC_3_4 | FE_CAN_FEC_4_5 | FE_CAN_FEC_5_6 | FE_CAN_FEC_6_7 | FE_CAN_FEC_7_8 | FE_CAN_FEC_8_9 | FE_CAN_QAM_16 | FE_CAN_QAM_64 | FE_CAN_QAM_32 | FE_CAN_QAM_128 | FE_CAN_QAM_256 | FE_CAN_QAM_AUTO | FE_CAN_QPSK | FE_CAN_FEC_AUTO | FE_CAN_INVERSION_AUTO | FE_CAN_TRANSMISSION_MODE_AUTO | FE_CAN_GUARD_INTERVAL_AUTO | FE_CAN_HIERARCHY_AUTO, } .... Using dvb-scan -------------- In order to tune into a channel and read the PSI tables, we can use dvb-scan. For this, one should provide a configuration file known as a 'scan file', here's an example:: [Channel] FREQUENCY = 330000000 MODULATION = QAM/AUTO SYMBOL_RATE = 6940000 INNER_FEC = AUTO DELIVERY_SYSTEM = DVBC/ANNEX_A NOTE: The parameters depend on the video standard you're testing. NOTE: Vidtv is a fake driver and does not validate much of the information in the scan file. Just specifying 'FREQUENCY' and 'DELIVERY_SYSTEM' should be enough for DVB-T/DVB-T2. For DVB-S/DVB-C however, you should also provide 'SYMBOL_RATE'. Assuming this channel is named 'channel.conf', you can then run:: $ dvbv5-scan dresden_dvbc_channel.conf Using dvb-zap ------------- dvbv5-zap is a command line tool that can be used to record MPEG-TS to disk. The typical use is to tune into a channel and put it into record mode. The example below - which is taken from the documentation - illustrates that:: $ dvbv5-zap -c dvb_channel.conf "trilhas sonoras" -r using demux '/dev/dvb/adapter0/demux0' reading channels from file 'dvb_channel.conf' service has pid type 05: 204 tuning to 573000000 Hz audio pid 104 dvb_set_pesfilter 104 Lock (0x1f) Quality= Good Signal= 100.00% C/N= -13.80dB UCB= 70 postBER= 3.14x10^-3 PER= 0 DVR interface '/dev/dvb/adapter0/dvr0' can now be opened The channel can be watched by playing the contents of the DVR interface, with some player that recognizes the MPEG-TS format, such as *mplayer* or *vlc*. By playing the contents of the stream one can visually inspect the workings of vidtv, e.g.:: $ mplayer /dev/dvb/adapter0/dvr0 Daniel W. S. Almeida (4): media: vidtv: implement a tuner driver media: vidtv: implement a demodulator driver media: vidtv: add a bridge driver media: Documentation: vidtv: Add ReST documentation for vidtv .../driver-api/media/drivers/index.rst | 1 + .../driver-api/media/drivers/vidtv.rst | 417 ++++++ MAINTAINERS | 8 + drivers/media/test-drivers/Kconfig | 16 + drivers/media/test-drivers/Makefile | 1 + drivers/media/test-drivers/vidtv/Kconfig | 11 + drivers/media/test-drivers/vidtv/Makefile | 9 + .../media/test-drivers/vidtv/vidtv_bridge.c | 547 ++++++++ .../media/test-drivers/vidtv/vidtv_bridge.h | 60 + .../media/test-drivers/vidtv/vidtv_channel.c | 360 ++++++ .../media/test-drivers/vidtv/vidtv_channel.h | 82 ++ .../media/test-drivers/vidtv/vidtv_common.c | 90 ++ .../media/test-drivers/vidtv/vidtv_common.h | 33 + .../media/test-drivers/vidtv/vidtv_demod.c | 440 +++++++ .../media/test-drivers/vidtv/vidtv_demod.h | 73 ++ .../media/test-drivers/vidtv/vidtv_encoder.h | 99 ++ drivers/media/test-drivers/vidtv/vidtv_mux.c | 454 +++++++ drivers/media/test-drivers/vidtv/vidtv_mux.h | 154 +++ drivers/media/test-drivers/vidtv/vidtv_pes.c | 434 +++++++ drivers/media/test-drivers/vidtv/vidtv_pes.h | 243 ++++ drivers/media/test-drivers/vidtv/vidtv_psi.c | 1131 +++++++++++++++++ drivers/media/test-drivers/vidtv/vidtv_psi.h | 686 ++++++++++ .../media/test-drivers/vidtv/vidtv_s302m.c | 663 ++++++++++ .../media/test-drivers/vidtv/vidtv_s302m.h | 136 ++ drivers/media/test-drivers/vidtv/vidtv_ts.c | 147 +++ drivers/media/test-drivers/vidtv/vidtv_ts.h | 138 ++ .../media/test-drivers/vidtv/vidtv_tuner.c | 427 +++++++ .../media/test-drivers/vidtv/vidtv_tuner.h | 43 + 28 files changed, 6903 insertions(+) create mode 100644 Documentation/driver-api/media/drivers/vidtv.rst create mode 100644 drivers/media/test-drivers/vidtv/Kconfig create mode 100644 drivers/media/test-drivers/vidtv/Makefile create mode 100644 drivers/media/test-drivers/vidtv/vidtv_bridge.c create mode 100644 drivers/media/test-drivers/vidtv/vidtv_bridge.h create mode 100644 drivers/media/test-drivers/vidtv/vidtv_channel.c create mode 100644 drivers/media/test-drivers/vidtv/vidtv_channel.h create mode 100644 drivers/media/test-drivers/vidtv/vidtv_common.c create mode 100644 drivers/media/test-drivers/vidtv/vidtv_common.h create mode 100644 drivers/media/test-drivers/vidtv/vidtv_demod.c create mode 100644 drivers/media/test-drivers/vidtv/vidtv_demod.h create mode 100644 drivers/media/test-drivers/vidtv/vidtv_encoder.h create mode 100644 drivers/media/test-drivers/vidtv/vidtv_mux.c create mode 100644 drivers/media/test-drivers/vidtv/vidtv_mux.h create mode 100644 drivers/media/test-drivers/vidtv/vidtv_pes.c create mode 100644 drivers/media/test-drivers/vidtv/vidtv_pes.h create mode 100644 drivers/media/test-drivers/vidtv/vidtv_psi.c create mode 100644 drivers/media/test-drivers/vidtv/vidtv_psi.h create mode 100644 drivers/media/test-drivers/vidtv/vidtv_s302m.c create mode 100644 drivers/media/test-drivers/vidtv/vidtv_s302m.h create mode 100644 drivers/media/test-drivers/vidtv/vidtv_ts.c create mode 100644 drivers/media/test-drivers/vidtv/vidtv_ts.h create mode 100644 drivers/media/test-drivers/vidtv/vidtv_tuner.c create mode 100644 drivers/media/test-drivers/vidtv/vidtv_tuner.h