diff mbox series

v4l2-compliance: zero mbus_code

Message ID 5cf00351-bf5f-b347-0ab5-9ea260a7bc85@xs4all.nl (mailing list archive)
State Accepted, archived
Delegated to: Hans Verkuil
Headers
Series v4l2-compliance: zero mbus_code |

Commit Message

Hans Verkuil April 23, 2020, 10:48 a.m. UTC 
The new fmtdesc.mbus_code should be zeroed by applications.

Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>
---

Comments

Laurent Pinchart April 24, 2020, 1:32 p.m. UTC | #1 
Hi Hans,

Thank you for the patch.

On Thu, Apr 23, 2020 at 12:48:20PM +0200, Hans Verkuil wrote:
> The new fmtdesc.mbus_code should be zeroed by applications.
> 
> Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>

Reviewed-by: Laurent Pinchart <laurent.pinchart@ideasonboard.com>

> ---
> diff --git a/utils/v4l2-compliance/v4l2-test-formats.cpp b/utils/v4l2-compliance/v4l2-test-formats.cpp
> index 824769b3..269a5fd9 100644
> --- a/utils/v4l2-compliance/v4l2-test-formats.cpp
> +++ b/utils/v4l2-compliance/v4l2-test-formats.cpp
> @@ -235,6 +235,7 @@ static int testEnumFormatsType(struct node *node, unsigned type)
>  		memset(&fmtdesc, 0xff, sizeof(fmtdesc));
>  		fmtdesc.type = type;
>  		fmtdesc.index = f;
> +		fmtdesc.mbus_code = 0;
> 
>  		ret = doioctl(node, VIDIOC_ENUM_FMT, &fmtdesc);
>  		if (ret == ENOTTY)
Niklas Söderlund April 28, 2020, 12:09 p.m. UTC | #2 
Hi Hans,

Thanks for your work.

On 2020-04-23 12:48:20 +0200, Hans Verkuil wrote:
> The new fmtdesc.mbus_code should be zeroed by applications.
> 
> Signed-off-by: Hans Verkuil <hverkuil-cisco@xs4all.nl>

Reviewed-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>

> ---
> diff --git a/utils/v4l2-compliance/v4l2-test-formats.cpp b/utils/v4l2-compliance/v4l2-test-formats.cpp
> index 824769b3..269a5fd9 100644
> --- a/utils/v4l2-compliance/v4l2-test-formats.cpp
> +++ b/utils/v4l2-compliance/v4l2-test-formats.cpp
> @@ -235,6 +235,7 @@ static int testEnumFormatsType(struct node *node, unsigned type)
>  		memset(&fmtdesc, 0xff, sizeof(fmtdesc));
>  		fmtdesc.type = type;
>  		fmtdesc.index = f;
> +		fmtdesc.mbus_code = 0;
> 
>  		ret = doioctl(node, VIDIOC_ENUM_FMT, &fmtdesc);
>  		if (ret == ENOTTY)
diff mbox series

Patch

diff --git a/utils/v4l2-compliance/v4l2-test-formats.cpp b/utils/v4l2-compliance/v4l2-test-formats.cpp
index 824769b3..269a5fd9 100644
--- a/utils/v4l2-compliance/v4l2-test-formats.cpp
+++ b/utils/v4l2-compliance/v4l2-test-formats.cpp
@@ -235,6 +235,7 @@  static int testEnumFormatsType(struct node *node, unsigned type)
 		memset(&fmtdesc, 0xff, sizeof(fmtdesc));
 		fmtdesc.type = type;
 		fmtdesc.index = f;
+		fmtdesc.mbus_code = 0;

 		ret = doioctl(node, VIDIOC_ENUM_FMT, &fmtdesc);
 		if (ret == ENOTTY)