Message ID | 1074d944-de6e-7483-3337-ca9acd1b1c55@xs4all.nl (mailing list archive) |
---|---|
State | Accepted, archived |
Headers |
Received: from vger.kernel.org ([209.132.180.67]) by www.linuxtv.org with esmtp (Exim 4.84_2) (envelope-from <linux-media-owner@vger.kernel.org>) id 1iKzfZ-0005DA-0u; Thu, 17 Oct 2019 06:53:57 +0000 Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2407839AbfJQGxz (ORCPT <rfc822;mkrufky@linuxtv.org> + 1 other); Thu, 17 Oct 2019 02:53:55 -0400 Received: from lb1-smtp-cloud8.xs4all.net ([194.109.24.21]:39149 "EHLO lb1-smtp-cloud8.xs4all.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2389340AbfJQGxz (ORCPT <rfc822;linux-media@vger.kernel.org>); Thu, 17 Oct 2019 02:53:55 -0400 Received: from [192.168.2.10] ([46.9.232.237]) by smtp-cloud8.xs4all.net with ESMTPA id KzfQiN66KPduvKzfTitN9r; Thu, 17 Oct 2019 08:53:51 +0200 To: Linux Media Mailing List <linux-media@vger.kernel.org> Cc: Vandana B N <bnvandana@gmail.com> From: Hans Verkuil <hverkuil@xs4all.nl> Subject: [GIT PULL FOR v5.5 (v2)] vivid: add metadata capture/output support Message-ID: <1074d944-de6e-7483-3337-ca9acd1b1c55@xs4all.nl> Date: Thu, 17 Oct 2019 08:53:48 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-CMAE-Envelope: MS4wfFHiaffoRcrQLLZJsAYkab8admDr4/xgPB4qVBNlExv7ti26SJMmpK7q+BL66ZvvUkoTs+DRU4/IaMMagSkbXrCerzwDwaQVOAIrYs/nQUf6kNrRqvxo Ef7Dmzs7GdM1WzH8RneNrMVMjjl8/J/tQVk51lPFzw0rvipNqJhu0YEEOcaci7kWKVPTGLSGo/pfDwNc/DLtE7qKnmggLfYi0b0= Sender: linux-media-owner@vger.kernel.org Precedence: bulk List-ID: <linux-media.vger.kernel.org> X-Mailing-List: linux-media@vger.kernel.org |
Series |
[GIT,PULL,FOR,v5.5,(v2)] vivid: add metadata capture/output support
|
|
Pull-request
git://linuxtv.org/hverkuil/media_tree.git tags/br-v5.5fMessage
Hans Verkuil
Oct. 17, 2019, 6:53 a.m. UTC
This series adds vivid metadata capture and output support. While working on that it was discovered that the v4l2 core didn't correctly validate the ioctls in the case of the vivid driver that has a complex mix of V4L2 devices and various video inputs, each with different properties. Some other cleanups were also done in that code to simplify the logic and the ioctl validation for touch devices was also improved. Many thanks to Vandana for working on this as part of the Linux Kernel Mentorship Program. Note: the v4l2-compliance test will fail for the metadata output. To make that work this patch is needed: https://patchwork.linuxtv.org/patch/59480/ Once this series is merged I'll apply that patch as well to v4l-utils. Changes in v2: - Updated the "v4l2:Add vivid metadata doc" patch with new dual license Regards, Hans The following changes since commit 503e59365dd134b2c63864f14e2de0476284b003: media: i2c: ov2659: Switch to SPDX Licensing (2019-10-01 17:39:16 -0300) are available in the Git repository at: git://linuxtv.org/hverkuil/media_tree.git tags/br-v5.5f for you to fetch changes up to d1c35b1d11a00b4794a7f0fbce50d754bc72ed36: vivid: Add metadata output support (2019-10-17 08:50:14 +0200) ---------------------------------------------------------------- Tag branch ---------------------------------------------------------------- Hans Verkuil (3): v4l2-dev: simplify the SDR checks v4l2-dev: fix is_tch checks v4l2-dev: disable frequency and tuner ioctls for touch Vandana BN (5): v4l2-core: correctly validate video and metadata ioctls vivid: Add metadata capture support Documentation:media:v4l2:Add vivid metadata doc v4l2-core: Add new metadata format vivid: Add metadata output support Documentation/media/uapi/v4l/meta-formats.rst | 1 + Documentation/media/uapi/v4l/pixfmt-meta-vivid.rst | 60 +++++++++++++++ drivers/media/platform/vivid/Makefile | 2 +- drivers/media/platform/vivid/vivid-core.c | 197 ++++++++++++++++++++++++++++++++++++++++++++++-- drivers/media/platform/vivid/vivid-core.h | 24 ++++++ drivers/media/platform/vivid/vivid-ctrls.c | 75 ++++++++++++++++++ drivers/media/platform/vivid/vivid-kthread-cap.c | 54 +++++++++++-- drivers/media/platform/vivid/vivid-kthread-out.c | 49 +++++++++++- drivers/media/platform/vivid/vivid-meta-cap.c | 201 +++++++++++++++++++++++++++++++++++++++++++++++++ drivers/media/platform/vivid/vivid-meta-cap.h | 29 +++++++ drivers/media/platform/vivid/vivid-meta-out.c | 174 ++++++++++++++++++++++++++++++++++++++++++ drivers/media/platform/vivid/vivid-meta-out.h | 25 ++++++ drivers/media/platform/vivid/vivid-vid-cap.c | 5 +- drivers/media/platform/vivid/vivid-vid-out.c | 5 +- drivers/media/v4l2-core/v4l2-dev.c | 112 ++++++++++++++++----------- drivers/media/v4l2-core/v4l2-ioctl.c | 17 ++++- include/uapi/linux/videodev2.h | 1 + 17 files changed, 965 insertions(+), 66 deletions(-) create mode 100644 Documentation/media/uapi/v4l/pixfmt-meta-vivid.rst create mode 100644 drivers/media/platform/vivid/vivid-meta-cap.c create mode 100644 drivers/media/platform/vivid/vivid-meta-cap.h create mode 100644 drivers/media/platform/vivid/vivid-meta-out.c create mode 100644 drivers/media/platform/vivid/vivid-meta-out.h
Comments
From: builder@linuxtv.org
Pull request: https://patchwork.linuxtv.org/patch/59516/
Build log: https://builder.linuxtv.org/job/patchwork/20785/
Build time: 00:21:46
Link: https://lore.kernel.org/linux-media/1074d944-de6e-7483-3337-ca9acd1b1c55@xs4all.nl
gpg: Signature made Thu 17 Oct 2019 06:51:01 AM UTC
gpg: using RSA key AAA7FFBA4D2D77EF4CAEA1421326E0CD23ABDCE5
gpg: Good signature from "Hans Verkuil <hverkuil-cisco@xs4all.nl>" [unknown]
gpg: aka "Hans Verkuil <hverkuil@xs4all.nl>" [full]
Summary: 5 patches and/or PDF generation with issues, being 0 at build time
Error/warnings:
Error #256 when running ./scripts/checkpatch.pl --terse --mailback --no-summary --strict patches/0003-v4l2-dev-fix-is_tch-checks.patch:
$ ./scripts/checkpatch.pl --terse --mailback --no-summary --strict patches/0003-v4l2-dev-fix-is_tch-checks.patch
patches/0003-v4l2-dev-fix-is_tch-checks.patch:40: WARNING: line over 80 characters
patches/0003-v4l2-dev-fix-is_tch-checks.patch:41: WARNING: line over 80 characters
Error #256 when running ./scripts/checkpatch.pl --terse --mailback --no-summary --strict patches/0005-vivid-Add-metadata-capture-support.patch:
$ ./scripts/checkpatch.pl --terse --mailback --no-summary --strict patches/0005-vivid-Add-metadata-capture-support.patch
patches/0005-vivid-Add-metadata-capture-support.patch:530: WARNING: line over 80 characters
patches/0005-vivid-Add-metadata-capture-support.patch:539: WARNING: line over 80 characters
patches/0005-vivid-Add-metadata-capture-support.patch:552: WARNING: line over 80 characters
patches/0005-vivid-Add-metadata-capture-support.patch:562: WARNING: line over 80 characters
patches/0005-vivid-Add-metadata-capture-support.patch:612: WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
patches/0005-vivid-Add-metadata-capture-support.patch:791: WARNING: line over 80 characters
Error #256 when running ./scripts/checkpatch.pl --terse --mailback --no-summary --strict patches/0006-Documentation-media-v4l2-Add-vivid-metadata-doc.patch:
$ ./scripts/checkpatch.pl --terse --mailback --no-summary --strict patches/0006-Documentation-media-v4l2-Add-vivid-metadata-doc.patch
patches/0006-Documentation-media-v4l2-Add-vivid-metadata-doc.patch:6: WARNING: Possible unwrapped commit description (prefer a maximum 75 chars per line)
patches/0006-Documentation-media-v4l2-Add-vivid-metadata-doc.patch:26: WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?
patches/0006-Documentation-media-v4l2-Add-vivid-metadata-doc.patch:31: WARNING: Missing or malformed SPDX-License-Identifier tag in line 1
Error #256 when running ./scripts/checkpatch.pl --terse --mailback --no-summary --strict patches/0007-v4l2-core-Add-new-metadata-format.patch:
$ ./scripts/checkpatch.pl --terse --mailback --no-summary --strict patches/0007-v4l2-core-Add-new-metadata-format.patch
patches/0007-v4l2-core-Add-new-metadata-format.patch:23: ERROR: trailing statements should be on next line
patches/0007-v4l2-core-Add-new-metadata-format.patch:35: WARNING: line over 80 characters
Error #256 when running ./scripts/checkpatch.pl --terse --mailback --no-summary --strict patches/0008-vivid-Add-metadata-output-support.patch:
$ ./scripts/checkpatch.pl --terse --mailback --no-summary --strict patches/0008-vivid-Add-metadata-output-support.patch
patches/0008-vivid-Add-metadata-output-support.patch:435: WARNING: line over 80 characters
patches/0008-vivid-Add-metadata-output-support.patch:485: WARNING: added, moved or deleted file(s), does MAINTAINERS need updating?