LinuxTV Patchwork [1/8] rcar-vin: Do not call pm_runtime_{resume,suspend}()

login
register
mail settings
Submitter Niklas Söderlund
Date April 12, 2019, 11:43 p.m.
Message ID <20190412234359.5079-2-niklas.soderlund+renesas@ragnatech.se>
Download mbox | patch
Permalink /patch/55658/
State New
Headers show

Comments

Niklas Söderlund - April 12, 2019, 11:43 p.m.
The driver do not implement runtime resume and suspend function so there
is little point in trying to call them. This is a leftover from the
drivers soc_camera beginnings.

Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>
---
 drivers/media/platform/rcar-vin/rcar-v4l2.c | 5 -----
 1 file changed, 5 deletions(-)
Ulrich Hecht - April 15, 2019, 11:21 a.m.
> On April 13, 2019 at 1:43 AM Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se> wrote:
> 
> 
> The driver do not implement runtime resume and suspend function so there

"driver does", I presume.

> is little point in trying to call them. This is a leftover from the
> drivers soc_camera beginnings.
> 
> Signed-off-by: Niklas Söderlund <niklas.soderlund+renesas@ragnatech.se>
> ---
>  drivers/media/platform/rcar-vin/rcar-v4l2.c | 5 -----
>  1 file changed, 5 deletions(-)
> 
> diff --git a/drivers/media/platform/rcar-vin/rcar-v4l2.c b/drivers/media/platform/rcar-vin/rcar-v4l2.c
> index 7cbdcbf9b090c638..b821ea01786eb1ff 100644
> --- a/drivers/media/platform/rcar-vin/rcar-v4l2.c
> +++ b/drivers/media/platform/rcar-vin/rcar-v4l2.c
> @@ -798,9 +798,6 @@ static int rvin_initialize_device(struct file *file)
>  		return ret;
>  
>  	pm_runtime_enable(&vin->vdev.dev);
> -	ret = pm_runtime_resume(&vin->vdev.dev);
> -	if (ret < 0 && ret != -ENOSYS)
> -		goto eresume;
>  
>  	/*
>  	 * Try to configure with default parameters. Notice: this is the
> @@ -817,7 +814,6 @@ static int rvin_initialize_device(struct file *file)
>  	return 0;
>  esfmt:
>  	pm_runtime_disable(&vin->vdev.dev);
> -eresume:
>  	rvin_power_off(vin);
>  
>  	return ret;
> @@ -868,7 +864,6 @@ static int rvin_release(struct file *file)
>  	 * Then de-initialize hw module.
>  	 */
>  	if (fh_singular) {
> -		pm_runtime_suspend(&vin->vdev.dev);
>  		pm_runtime_disable(&vin->vdev.dev);
>  		rvin_power_off(vin);
>  	}
> -- 
> 2.21.0
>

With typo fixed,
Reviewed-by: Ulrich Hecht <uli+renesas@fpond.eu>

CU
Uli

Patch

diff --git a/drivers/media/platform/rcar-vin/rcar-v4l2.c b/drivers/media/platform/rcar-vin/rcar-v4l2.c
index 7cbdcbf9b090c638..b821ea01786eb1ff 100644
--- a/drivers/media/platform/rcar-vin/rcar-v4l2.c
+++ b/drivers/media/platform/rcar-vin/rcar-v4l2.c
@@ -798,9 +798,6 @@  static int rvin_initialize_device(struct file *file)
 		return ret;
 
 	pm_runtime_enable(&vin->vdev.dev);
-	ret = pm_runtime_resume(&vin->vdev.dev);
-	if (ret < 0 && ret != -ENOSYS)
-		goto eresume;
 
 	/*
 	 * Try to configure with default parameters. Notice: this is the
@@ -817,7 +814,6 @@  static int rvin_initialize_device(struct file *file)
 	return 0;
 esfmt:
 	pm_runtime_disable(&vin->vdev.dev);
-eresume:
 	rvin_power_off(vin);
 
 	return ret;
@@ -868,7 +864,6 @@  static int rvin_release(struct file *file)
 	 * Then de-initialize hw module.
 	 */
 	if (fh_singular) {
-		pm_runtime_suspend(&vin->vdev.dev);
 		pm_runtime_disable(&vin->vdev.dev);
 		rvin_power_off(vin);
 	}

Privacy Policy