LinuxTV Patchwork [2/3] media: atmel: atmel-isc: fix INIT_WORK misplacement

login
register
mail settings
Submitter Eugen Hristev
Date April 12, 2019, 10:19 a.m.
Message ID <1555064098-19310-3-git-send-email-eugen.hristev@microchip.com>
Download mbox | patch
Permalink /patch/55637/
State New
Delegated to: Hans Verkuil
Headers show

Comments

Eugen Hristev - April 12, 2019, 10:19 a.m.
From: Eugen Hristev <eugen.hristev@microchip.com>


In case the completion function failes, unbind will be called
which will call cancel_work for awb_work.
This will trigger a WARN message from the workqueue.
To avoid this, move the INIT_WORK call at the start of the completion
function. This way the work is always initialized, which corresponds
to the 'always canceled' unbind code.

Fixes: 93d4a26c3d ("[media] atmel-isc: add the isc pipeline function")
Signed-off-by: Eugen Hristev <eugen.hristev@microchip.com>

---
 drivers/media/platform/atmel/atmel-isc.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

-- 
2.7.4

Patch

diff --git a/drivers/media/platform/atmel/atmel-isc.c b/drivers/media/platform/atmel/atmel-isc.c

index ea7520a..aef90db 100644

--- a/drivers/media/platform/atmel/atmel-isc.c

+++ b/drivers/media/platform/atmel/atmel-isc.c

@@ -1998,6 +1998,8 @@  static int isc_async_complete(struct v4l2_async_notifier *notifier)

 	struct vb2_queue *q = &isc->vb2_vidq;
 	int ret;
 
+	INIT_WORK(&isc->awb_work, isc_awb_work);

+

 	ret = v4l2_device_register_subdev_nodes(&isc->v4l2_dev);
 	if (ret < 0) {
 		v4l2_err(&isc->v4l2_dev, "Failed to register subdev nodes\n");
@@ -2051,8 +2053,6 @@  static int isc_async_complete(struct v4l2_async_notifier *notifier)

 		return ret;
 	}
 
-	INIT_WORK(&isc->awb_work, isc_awb_work);

-

 	/* Register video device */
 	strscpy(vdev->name, ATMEL_ISC_NAME, sizeof(vdev->name));
 	vdev->release		= video_device_release_empty;

Privacy Policy