LinuxTV Patchwork [v3,2/5] media: vsp1: Initialise partition windows

login
register
mail settings
Submitter Kieran Bingham
Date April 11, 2019, 4:12 p.m.
Message ID <20190411161256.19607-3-kieran.bingham+renesas@ideasonboard.com>
Download mbox | patch
Permalink /patch/55619/
State New
Headers show

Comments

Kieran Bingham - April 11, 2019, 4:12 p.m.
Ensure that the partition window is correctly initialised before being
utilised.

Signed-off-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
---
 drivers/media/platform/vsp1/vsp1_video.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
Laurent Pinchart - April 18, 2019, 6:32 a.m.
Hi Kieran,

Thank you for the patch.

On Thu, Apr 11, 2019 at 05:12:53PM +0100, Kieran Bingham wrote:
> Ensure that the partition window is correctly initialised before being
> utilised.
> 
> Signed-off-by: Kieran Bingham <kieran.bingham+renesas@ideasonboard.com>
> ---
>  drivers/media/platform/vsp1/vsp1_video.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/media/platform/vsp1/vsp1_video.c b/drivers/media/platform/vsp1/vsp1_video.c
> index ee2fb8261a6a..563f9a02c373 100644
> --- a/drivers/media/platform/vsp1/vsp1_video.c
> +++ b/drivers/media/platform/vsp1/vsp1_video.c
> @@ -189,7 +189,7 @@ static void vsp1_video_calculate_partition(struct vsp1_pipeline *pipe,
>  					   unsigned int index)
>  {
>  	const struct v4l2_mbus_framefmt *format;
> -	struct vsp1_partition_window window;
> +	struct vsp1_partition_window window = { 0, };

This isn't needed as-is. If this change is required by a patch further
in this series, you can squash it there.

>  	unsigned int modulus;
>  
>  	/*

Patch

diff --git a/drivers/media/platform/vsp1/vsp1_video.c b/drivers/media/platform/vsp1/vsp1_video.c
index ee2fb8261a6a..563f9a02c373 100644
--- a/drivers/media/platform/vsp1/vsp1_video.c
+++ b/drivers/media/platform/vsp1/vsp1_video.c
@@ -189,7 +189,7 @@  static void vsp1_video_calculate_partition(struct vsp1_pipeline *pipe,
 					   unsigned int index)
 {
 	const struct v4l2_mbus_framefmt *format;
-	struct vsp1_partition_window window;
+	struct vsp1_partition_window window = { 0, };
 	unsigned int modulus;
 
 	/*

Privacy Policy