LinuxTV Patchwork [2/3] media: smiapp: regs: add range to usleep_range

login
register
mail settings
Submitter Nicholas Mc Guire
Date April 7, 2019, 2:16 a.m.
Message ID <1554603364-10500-2-git-send-email-hofrat@opentech.at>
Download mbox | patch
Permalink /patch/55494/
State New
Delegated to: Sakari Ailus
Headers show

Comments

Nicholas Mc Guire - April 7, 2019, 2:16 a.m.
As this is a retry loop for a sender not responding there is no reason
to mandate a high accuracy delay - extend the sleep range to 2-4ms
so that the hrtimer subsystem can work efficiently.

Signed-off-by: Nicholas Mc Guire <hofrat@opentech.at>
---

Problem located by an experimental coccinelle script

Patch was compile tested with: x86_64_defconfig + MEDIA_SUPPORT=m,
MEDIA_CAMERA_SUPPORT=y, MEDIA_CONTROLLER=y, VIDEO_V4L2_SUBDEV_API=y,
VIDEO_SMIAPP=m

Patch is against 5.1-rc3 (localversion-next is next-20190405)

 drivers/media/i2c/smiapp/smiapp-regs.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Patch

diff --git a/drivers/media/i2c/smiapp/smiapp-regs.c b/drivers/media/i2c/smiapp/smiapp-regs.c
index 145653d..dfa4f99 100644
--- a/drivers/media/i2c/smiapp/smiapp-regs.c
+++ b/drivers/media/i2c/smiapp/smiapp-regs.c
@@ -276,7 +276,7 @@  int smiapp_write_no_quirk(struct smiapp_sensor *sensor, u32 reg, u32 val)
 			return 0;
 		}
 
-		usleep_range(2000, 2000);
+		usleep_range(2000, 4000);
 	}
 
 	dev_err(&client->dev,

Privacy Policy